Re: RFR: JDK-8200357 Inline SoundLibraries.gmk into Lib-java.desktop.gmk

2018-03-28 Thread Thomas Stüfe
Oh, change also looks fine to me. ..Thomas On Wed, Mar 28, 2018 at 3:19 PM, Thomas Stüfe wrote: > Thanks Magnus, > > this fixes AIX (in the sense that it does not attempt anymore to build > libjsound). > > Best Regards, Thomas > > On Wed, Mar 28, 2018 at 12:46 PM,

Re: RFR: JDK-8200357 Inline SoundLibraries.gmk into Lib-java.desktop.gmk

2018-03-28 Thread Erik Joelsson
Looks good to me. /Erik On 2018-03-28 03:46, Magnus Ihse Bursie wrote: With some further simplifications, the code for building libjsound is very small. There is no longer any reason to have that in a separate file. Instead it should be inlined into Lib-java.desktop.gmk. This patch also

Re: RFR: JDK-8200357 Inline SoundLibraries.gmk into Lib-java.desktop.gmk

2018-03-28 Thread Thomas Stüfe
Thanks Magnus, this fixes AIX (in the sense that it does not attempt anymore to build libjsound). Best Regards, Thomas On Wed, Mar 28, 2018 at 12:46 PM, Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > With some further simplifications, the code for building libjsound is very >

RFR: JDK-8200357 Inline SoundLibraries.gmk into Lib-java.desktop.gmk

2018-03-28 Thread Magnus Ihse Bursie
With some further simplifications, the code for building libjsound is very small. There is no longer any reason to have that in a separate file. Instead it should be inlined into Lib-java.desktop.gmk. This patch also includes code to stop building libjsig on AIX, as requested by Thomas Stüfe.