Re: RFR: JDK-8200738 Use --hash-style=gnu for gcc

2020-06-16 Thread Ioi Lam
On 6/15/20 2:08 AM, Magnus Ihse Bursie wrote: On 2020-06-15 07:46, David Holmes wrote: Hi Magnus, On 13/06/2020 1:42 am, Magnus Ihse Bursie wrote: When support for gnu hash tables were added to the gcc toolchains, the OpenJDK build system added a hack to change --hash-style=gnu to

Re: RFR: JDK-8200738 Use --hash-style=gnu for gcc

2020-06-15 Thread Magnus Ihse Bursie
On 2020-06-15 07:46, David Holmes wrote: Hi Magnus, On 13/06/2020 1:42 am, Magnus Ihse Bursie wrote: When support for gnu hash tables were added to the gcc toolchains, the OpenJDK build system added a hack to change --hash-style=gnu to --hash-style=both unconditionally, citing compatibility

Re: RFR: JDK-8200738 Use --hash-style=gnu for gcc

2020-06-14 Thread David Holmes
Hi Magnus, On 13/06/2020 1:42 am, Magnus Ihse Bursie wrote: When support for gnu hash tables were added to the gcc toolchains, the OpenJDK build system added a hack to change --hash-style=gnu to --hash-style=both unconditionally, citing compatibility concerns. Exactly how are these "hash

Re: RFR: JDK-8200738 Use --hash-style=gnu for gcc

2020-06-12 Thread Erik Joelsson
Looks good. /Erik On 2020-06-12 08:42, Magnus Ihse Bursie wrote: When support for gnu hash tables were added to the gcc toolchains, the OpenJDK build system added a hack to change --hash-style=gnu to --hash-style=both unconditionally, citing compatibility concerns. --hash-style=gnu has a

RFR: JDK-8200738 Use --hash-style=gnu for gcc

2020-06-12 Thread Magnus Ihse Bursie
When support for gnu hash tables were added to the gcc toolchains, the OpenJDK build system added a hack to change --hash-style=gnu to --hash-style=both unconditionally, citing compatibility concerns. --hash-style=gnu has a very slight performance advantage over --hash-style=both (very small