Re: RFR: JDK-8213227: Update jib src excludes to filter webrev and Jreg directories

2018-11-05 Thread David Holmes
Erik, I think this has broken the creation of the "release" file in the build. It no longer contains the "hg" tag, presumably because all the .hg directories that would have indicated hg was used have been stripped. CI tests are failing for test/jdk/build/releaseFile/CheckSource.java David

Re: RFR: JDK-8213227: Update jib src excludes to filter webrev and Jreg directories

2018-11-01 Thread Magnus Ihse Bursie
On 2018-11-01 01:22, Erik Joelsson wrote: This patch adds some useful excludes for jib source bundle creation, which will help avoid sending in too much junk in Mach 5 jobs. The strings are rewritten as arrays, which are now supported, as well as using ** globs to match arbitrary directory

Re: RFR: JDK-8213227: Update jib src excludes to filter webrev and Jreg directories

2018-10-31 Thread Tim Bell
Erik- Looks good to me as well. Tim On 10/31/18 17:33, David Holmes wrote: Hi Erik, This looks good to me. Thanks, David On 1/11/2018 10:22 AM, Erik Joelsson wrote: This patch adds some useful excludes for jib source bundle creation, which will help avoid sending in too much junk in Mach

Re: RFR: JDK-8213227: Update jib src excludes to filter webrev and Jreg directories

2018-10-31 Thread David Holmes
Hi Erik, This looks good to me. Thanks, David On 1/11/2018 10:22 AM, Erik Joelsson wrote: This patch adds some useful excludes for jib source bundle creation, which will help avoid sending in too much junk in Mach 5 jobs. The strings are rewritten as arrays, which are now supported, as well

RFR: JDK-8213227: Update jib src excludes to filter webrev and Jreg directories

2018-10-31 Thread Erik Joelsson
This patch adds some useful excludes for jib source bundle creation, which will help avoid sending in too much junk in Mach 5 jobs. The strings are rewritten as arrays, which are now supported, as well as using ** globs to match arbitrary directory depths. I've also removed the no longer used