Re: RFR: JDK-8240228 "make hotspot-ide-project" on Windows creates a Visual Studio project with empty preprocessor defines

2020-05-15 Thread Erik Joelsson
Looks good. /Erik On 2020-05-15 11:16, Magnus Ihse Bursie wrote: After JDK-8239450 (Overhaul JVM feature handling in configure), the Hotspot Visual Studio project creator did not properly pick up compiler defines. This turned out to be due to it hard-coding JVM_VARIANT to client (which is

RFR: JDK-8240228 "make hotspot-ide-project" on Windows creates a Visual Studio project with empty preprocessor defines

2020-05-15 Thread Magnus Ihse Bursie
After JDK-8239450 (Overhaul JVM feature handling in configure), the Hotspot Visual Studio project creator did not properly pick up compiler defines. This turned out to be due to it hard-coding JVM_VARIANT to client (which is most often not built), and thus it got not JVM features for client,