LGTM
— Igor
> On Jun 23, 2020, at 11:13 AM, Erik Joelsson wrote:
>
> That looks much better! :)
>
> /Erik
>
>> On 2020-06-23 09:53, Magnus Ihse Bursie wrote:
>>> On 2020-06-23 17:05, Erik Joelsson wrote:
>>> Looks good, but that was the worst way of posting a patch I've seen to date.
>> The
That looks much better! :)
/Erik
On 2020-06-23 09:53, Magnus Ihse Bursie wrote:
On 2020-06-23 17:05, Erik Joelsson wrote:
Looks good, but that was the worst way of posting a patch I've seen
to date.
The mail you quoted looked awful, yes! :-( I tried a new way of
formatting the mail so the
On 2020-06-23 17:05, Erik Joelsson wrote:
Looks good, but that was the worst way of posting a patch I've seen to
date.
The mail you quoted looked awful, yes! :-( I tried a new way of
formatting the mail so the patch and log should be fixed space.
Apparently it failed horribly.
Also, I
Looks good, but that was the worst way of posting a patch I've seen to date.
/Erik
On 2020-06-23 07:37, Magnus Ihse Bursie wrote:
If you run |make test TEST=jtreg:gtest/GTestWrapper.java| but had not
built using the gtest framework, you would just get a result like this:
|STDERR:
If you run |make test TEST=jtreg:gtest/GTestWrapper.java| but had not
built using the gtest framework, you would just get a result like this:
|STDERR: java.lang.Error: TESTBUG: the library has not been found in
