Re: RFR: JDK-8284858: Start of release updates for JDK 20 [v2]

2022-05-27 Thread Iris Clark 
On Thu, 26 May 2022 23:05:32 GMT, Joe Darcy  wrote:

>> Time to start getting ready for JDK 20...
>
> Joe Darcy has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Respond to review feedback.

Marked as reviewed by iris (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/8236

Re: RFR: JDK-8284858: Start of release updates for JDK 20 [v2]

2022-05-27 Thread Erik Joelsson 
On Thu, 26 May 2022 23:05:32 GMT, Joe Darcy  wrote:

>> Time to start getting ready for JDK 20...
>
> Joe Darcy has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Respond to review feedback.

Marked as reviewed by erikj (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/8236

Re: RFR: JDK-8284858: Start of release updates for JDK 20 [v2]

2022-05-27 Thread David Holmes 
On Thu, 26 May 2022 23:05:32 GMT, Joe Darcy  wrote:

>> Time to start getting ready for JDK 20...
>
> Joe Darcy has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Respond to review feedback.

Marked as reviewed by dholmes (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/8236

Re: RFR: JDK-8284858: Start of release updates for JDK 20 [v2]

2022-05-26 Thread Iris Clark 
On Thu, 26 May 2022 23:05:32 GMT, Joe Darcy  wrote:

>> Time to start getting ready for JDK 20...
>
> Joe Darcy has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Respond to review feedback.

Marked as reviewed by iris (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/8236

Re: RFR: JDK-8284858: Start of release updates for JDK 20 [v2]

2022-05-26 Thread Kevin Rushforth 
On Thu, 26 May 2022 23:05:32 GMT, Joe Darcy  wrote:

>> Time to start getting ready for JDK 20...
>
> Joe Darcy has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Respond to review feedback.

Marked as reviewed by kcr (Author).

-

PR: https://git.openjdk.java.net/jdk/pull/8236

Re: RFR: JDK-8284858: Start of release updates for JDK 20 [v2]

2022-05-26 Thread Joe Darcy 
On Thu, 26 May 2022 22:38:12 GMT, David Holmes  wrote:

>> Joe Darcy has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Respond to review feedback.
>
> src/java.base/share/classes/jdk/internal/org/objectweb/asm/Opcodes.java line 
> 312:
> 
>> 310: int V18 = 0 << 16 | 62;
>> 311: int V19 = 0 << 16 | 63;
>> 312: int V20 = 0 << 17 | 64;
> 
> 17 ??
> 
> Though why do we even bother with this when the minor version is zero? Simple 
> assignment works.

Doh! Will fix in the next pushed.

-

PR: https://git.openjdk.java.net/jdk/pull/8236

Re: RFR: JDK-8284858: Start of release updates for JDK 20 [v2]

2022-05-26 Thread Joe Darcy 
> Time to start getting ready for JDK 20...

Joe Darcy has updated the pull request incrementally with one additional commit 
since the last revision:

  Respond to review feedback.

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8236/files
  - new: https://git.openjdk.java.net/jdk/pull/8236/files/49c871d9..96be1787

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=8236=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=8236=00-01

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8236.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8236/head:pull/8236

PR: https://git.openjdk.java.net/jdk/pull/8236