RE: RFR [XS]: 8248334: hs build errors on ppc64 and s390x platforms

2020-06-26 Thread Baesken, Matthias
HI David and Martin, thanks for the reviews ! > >Hi Matthias, > >Looks good. Thanks for fixing it. > >Best regards, >Martin >> >> Hi Matthias, >> >> That all seems fine to me. >> >> David >>

Re: RFR [XS]: 8248334: hs build errors on ppc64 and s390x platforms

2020-06-26 Thread Doerr, Martin
Hi Matthias, Looks good. Thanks for fixing it. Best regards, Martin > Am 26.06.2020 um 09:59 schrieb David Holmes : > > Hi Matthias, > > That all seems fine to me. > > David > >> On 26/06/2020 5:06 pm, Baesken, Matthias wrote: >> Hello, please review this small patch that fixes the

Re: RFR [XS]: 8248334: hs build errors on ppc64 and s390x platforms

2020-06-26 Thread Lindenmaier, Goetz
Hi, I didn't get the RFR mails. Probably the known hotspot-dev Mailing List Problem? But I saw the RFR in the pipermail archive. I had a look at the change. It looks good, and I consider it trivial. Best regards, Goetz.

Re: RFR [XS]: 8248334: hs build errors on ppc64 and s390x platforms

2020-06-26 Thread David Holmes
Hi Matthias, That all seems fine to me. David On 26/06/2020 5:06 pm, Baesken, Matthias wrote: Hello, please review this small patch that fixes the ppc64(le) and s390x builds . ( They started to break since the 24th June, looks like some inclusions were missing after recent HS

RFR [XS]: 8248334: hs build errors on ppc64 and s390x platforms

2020-06-26 Thread Baesken, Matthias
Hello, please review this small patch that fixes the ppc64(le) and s390x builds . ( They started to break since the 24th June, looks like some inclusions were missing after recent HS changes ) Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8248334