Re: RFR 8239782: CC_INTERP is only used by Zero interpreter

2020-06-24 Thread coleen . phillimore
Hi Adrian, Thank you for replying and having a look.  I hope you like the patch, but if not, we'll fix it. Sorry for rushing the push.  I was sitting on too many changed files. Thanks, Coleen On 6/24/20 4:03 PM, John Paul Adrian Glaubitz wrote: Hi Coleen! On 6/24/20 8:42 PM,

Re: RFR 8239782: CC_INTERP is only used by Zero interpreter

2020-06-24 Thread John Paul Adrian Glaubitz
Hi Coleen! On 6/24/20 8:42 PM, coleen.phillim...@oracle.com wrote: > Thank you for replying! > I was going to wait for Adrian but it's a big enough change that it would bit > rot if I > waited too long, and I didn't know how long it would be.  We can fix anything > that is > disagreeable with a

Re: RFR 8239782: CC_INTERP is only used by Zero interpreter

2020-06-24 Thread coleen . phillimore
Hi Chris, Thank you for replying! I was going to wait for Adrian but it's a big enough change that it would bit rot if I waited too long, and I didn't know how long it would be.  We can fix anything that is disagreeable with a future patch, I think.  So I pushed it today. Thanks, Coleen On

Re: RFR 8239782: CC_INTERP is only used by Zero interpreter

2020-06-24 Thread Chris Phillips
Hi Coleen, On 2020-06-23 16:35, coleen.phillim...@oracle.com wrote: > > Including build-dev. > > On 6/23/20 12:17 AM, David Holmes wrote: >> Hi Coleen, >> >> Cleanup is looking good but a few comments: >> >> - if the bytecodeInterpreter is also zero-only can we rename its files >> too? (I

Re: RFR 8239782: CC_INTERP is only used by Zero interpreter

2020-06-24 Thread coleen . phillimore
Thank you, David! Coleen On 6/24/20 12:13 AM, David Holmes wrote: I thoroughly applaud the introduction of interpreter/zero directory! Thank you. :) Updates look good to me. Thanks, David On 24/06/2020 6:35 am, coleen.phillim...@oracle.com wrote: Including build-dev. On 6/23/20 12:17 AM,

Re: RFR 8239782: CC_INTERP is only used by Zero interpreter

2020-06-23 Thread David Holmes
I thoroughly applaud the introduction of interpreter/zero directory! Thank you. :) Updates look good to me. Thanks, David On 24/06/2020 6:35 am, coleen.phillim...@oracle.com wrote: Including build-dev. On 6/23/20 12:17 AM, David Holmes wrote: Hi Coleen, Cleanup is looking good but a few

Re: RFR 8239782: CC_INTERP is only used by Zero interpreter

2020-06-23 Thread coleen . phillimore
Thanks, Magnus. Coleen On 6/23/20 7:04 PM, Magnus Ihse Bursie wrote: On 2020-06-23 22:35, coleen.phillim...@oracle.com wrote: Including build-dev. On 6/23/20 12:17 AM, David Holmes wrote: Hi Coleen, Cleanup is looking good but a few comments: - if the bytecodeInterpreter is also

Re: RFR 8239782: CC_INTERP is only used by Zero interpreter

2020-06-23 Thread Magnus Ihse Bursie
On 2020-06-23 22:35, coleen.phillim...@oracle.com wrote: Including build-dev. On 6/23/20 12:17 AM, David Holmes wrote: Hi Coleen, Cleanup is looking good but a few comments: - if the bytecodeInterpreter is also zero-only can we rename its files too? (I really find it hard to figure out

Re: RFR 8239782: CC_INTERP is only used by Zero interpreter

2020-06-23 Thread coleen . phillimore
Including build-dev. On 6/23/20 12:17 AM, David Holmes wrote: Hi Coleen, Cleanup is looking good but a few comments: - if the bytecodeInterpreter is also zero-only can we rename its files too? (I really find it hard to figure out which files are really needed/used for a given build.)

Re: RFR 8239782: CC_INTERP is only used by Zero interpreter

2020-06-23 Thread Magnus Ihse Bursie
On 2020-06-23 06:17, David Holmes wrote: Hi Coleen, Cleanup is looking good but a few comments: - if the bytecodeInterpreter is also zero-only can we rename its files too? (I really find it hard to figure out which files are really needed/used for a given build.) - you are excluding shared