Re: RFR 8241749: Remove the Nashorn JavaScript Engine

2020-04-15 Thread sundararajan . athijegannathan
Thanks Mandy. I'll add bug id next to @ignore before push. Thanks, -Sundar On 16/04/20 2:50 am, Mandy Chung wrote: This looks okay to me. Can you add the bug ID next to @ignore that will make it easier to find the JBS issue?   These test bugs are filed with P4 but I think they should be

Re: RFR 8241749: Remove the Nashorn JavaScript Engine

2020-04-15 Thread sundararajan . athijegannathan
Thanks for spotting this Magnus! I'll fix this before push. Thanks. -Sundar On 15/04/20 10:44 pm, Magnus Ihse Bursie wrote: On 2020-04-15 17:56, sundararajan.athijegannat...@oracle.com wrote: Please review. Nashorn script engine modules (jdk.scripting.nashorn, jdk.scripting.nashorn.shell)

Re: RFR 8241749: Remove the Nashorn JavaScript Engine

2020-04-15 Thread Mandy Chung
This looks okay to me. Can you add the bug ID next to @ignore that will make it easier to find the JBS issue?   These test bugs are filed with P4 but I think they should be fixed in 15. Mandy On 4/15/20 8:56 AM, sundararajan.athijegannat...@oracle.com wrote: Please review. Nashorn script

Re: RFR 8241749: Remove the Nashorn JavaScript Engine

2020-04-15 Thread Magnus Ihse Bursie
On 2020-04-15 17:56, sundararajan.athijegannat...@oracle.com wrote: Please review. Nashorn script engine modules (jdk.scripting.nashorn, jdk.scripting.nashorn.shell) and jjs tool are removed. Bug: https://bugs.openjdk.java.net/browse/JDK-8241749 JEP: https://openjdk.java.net/jeps/372 CSR:

Re: RFR 8241749: Remove the Nashorn JavaScript Engine

2020-04-15 Thread Jim Laskey
+1 > On Apr 15, 2020, at 12:56 PM, sundararajan.athijegannat...@oracle.com wrote: > > Please review. > > Nashorn script engine modules (jdk.scripting.nashorn, > jdk.scripting.nashorn.shell) and jjs tool are removed. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8241749 > > JEP:

RFR 8241749: Remove the Nashorn JavaScript Engine

2020-04-15 Thread sundararajan . athijegannathan
Please review. Nashorn script engine modules (jdk.scripting.nashorn, jdk.scripting.nashorn.shell) and jjs tool are removed. Bug: https://bugs.openjdk.java.net/browse/JDK-8241749 JEP: https://openjdk.java.net/jeps/372 CSR: https://bugs.openjdk.java.net/browse/JDK-8241751 Webrev: