Re: Review Request: JDK-8173608: Separate JDK management agent from java.management module

On 30/01/2017 23:48, Mandy Chung wrote: Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173608/webrev.00/index.html Just catching up this. It looks like the native methods for jdk.internal.agent.FileSystemImpl have been moved to libmanagemtn_rmi.so, shouldn't this be

Re: Review Request: JDK-8173608: Separate JDK management agent from java.management module

On 1/02/2017 12:57 AM, Mandy Chung wrote: On Jan 30, 2017, at 11:00 PM, David Holmes wrote: Hi Mandy, On 31/01/2017 9:48 AM, Mandy Chung wrote: Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173608/webrev.00/index.html This all seems okay. Thanks

Re: Review Request: JDK-8173608: Separate JDK management agent from java.management module

On 2017-01-31 17:04, Mandy Chung wrote: On Jan 31, 2017, at 12:20 AM, Erik Joelsson wrote: Are all the libraries added to LIBS still needed for this breakout lib? And are all of them still needed for libmanagement.so from which this was split out? Good catch. I

Re: Review Request: JDK-8173608: Separate JDK management agent from java.management module

> On Jan 31, 2017, at 7:35 AM, Daniel Fuchs wrote: > > Hi Mandy, > > Looks good to me in general. > > Suggestion: FileLoginModule.java > > 112 private static final String PASSWORD_FILE_NAME = "jmxremote.password"; > > Maybe the constant could be public, then it

Re: Review Request: JDK-8173608: Separate JDK management agent from java.management module

> On Jan 31, 2017, at 12:20 AM, Erik Joelsson wrote: > > Hello Mandy, > > In Lib-jdk.management.agent.gmk: > > OPENJDK_TARGET_OS and OPENJDK_TARGET_OS_TYPE are both "windows" on Windows > platforms, so no need to treat Windows differently when defining the src dirs.

Re: Review Request: JDK-8173608: Separate JDK management agent from java.management module

Hi Mandy, Looks good to me in general. Suggestion: FileLoginModule.java 112 private static final String PASSWORD_FILE_NAME = "jmxremote.password"; Maybe the constant could be public, then it could be referred to by ConnectorBootstrap? I see that com.sun.jmx.remote.internal is already

Re: Review Request: JDK-8173608: Separate JDK management agent from java.management module

> On Jan 30, 2017, at 11:00 PM, David Holmes wrote: > > Hi Mandy, > > On 31/01/2017 9:48 AM, Mandy Chung wrote: >> Webrev at: >> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173608/webrev.00/index.html > > This all seems okay. > Thanks for the review. > But we

Re: Review Request: JDK-8173608: Separate JDK management agent from java.management module

Hello Mandy, In Lib-jdk.management.agent.gmk: OPENJDK_TARGET_OS and OPENJDK_TARGET_OS_TYPE are both "windows" on Windows platforms, so no need to treat Windows differently when defining the src dirs. The -DPSAPI_VERSION=1 seems to be copied from Lib-jdk.management.gmk and/or

Re: Review Request: JDK-8173608: Separate JDK management agent from java.management module

Hi Mandy, On 31/01/2017 9:48 AM, Mandy Chung wrote: Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173608/webrev.00/index.html This all seems okay. But we have quite a few hotspot tests that include: @modules java.management/sun.management that would seem to need updating as

Re: Review Request: JDK-8173608: Separate JDK management agent from java.management module

Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173608/webrev.00/index.html Mandy > On Jan 30, 2017, at 3:42 PM, Mandy Chung wrote: > > java.management is the module for JMX and JMX remote API and > java.lang.management. JDK management agent provides the

Review Request: JDK-8173608: Separate JDK management agent from java.management module

java.management is the module for JMX and JMX remote API and java.lang.management. JDK management agent provides the JDK-specific out-of-the-box monitoring and management support and it’s cleaner for it to live in its own module. It is proposed to move it to a new module named