Re: [OpenJDK 2D-Dev] build fails on macOS 10.12 after 8214578: [macos] Problem with backslashes on macOS/JIS keyboard: Java ignores system settings

2019-11-25 Thread Phil Race

I expect we could as it would help with backports but how much longer
can we support 10.12 SDK to build ? Project Lanai is already finding it
hard to keep to the 10.13 SDK ... and 10.12 as an O/S is already EOSL.

So it should just be a stop gap measure.

-phil.

On 11/25/19 4:48 AM, Baesken, Matthias wrote:


Hello,  any comments on the issue ?

Could we maybe switch from using

NSTextInputSourceIdentifier

to

String  (NSString* ?) , because 
https://developer.apple.com/documentation/appkit/nstextinputsourceidentifier


says  NSTextInputSourceIdentifier    is a typealias for String  ?

Best regards ,Matthias

Hello, I noticed  that since today our  jdk/jdk  build fails on macOS 
. We run it on macOS 10.12 .


It seems

https://hg.openjdk.java.net/jdk/jdk/rev/d0bfaae2ff33

8214578: [macos] Problem with backslashes on macOS/JIS keyboard: Java 
ignores system settings


Brought a  dependency on 10.13.  Was that intended ? Could we keep 
10.12  compatibility ?


At least  the doc of NSTextInputSourceIdentifier  : 
https://developer.apple.com/documentation/appkit/nstextinputsourceidentifier


mentions  macOS 10.13+  .

Build errors are :



/jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.h:41:5: 
error: unknown type name 'NSTextInputSourceIdentifier'


NSTextInputSourceIdentifier kbdLayout;

    ^

/jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m:93:23: 
error: assignment to readonly property


    self.cglLayer = windowLayer;

    ~ ^ ~~~

/jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m:110:19: 
error: assignment to readonly property


    self.cglLayer = nil;

    ~ ^ ~~~

3 errors generated.

…

/jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.m:454:18: 
error: incompatible pointer to integer conversion initializing 'BOOL' 
(aka 'signed char') with an expression of type 'id' 
[-Werror,-Wint-conversion]


    BOOL mouseIsOver = [[window contentView] mouseIsOver];

^ ~~

2 errors generated.

Best regards, Matthias





Re: build fails on macOS 10.12 after 8214578: [macos] Problem with backslashes on macOS/JIS keyboard: Java ignores system settings

2019-11-25 Thread Erik Joelsson
If there is a simple fix, I would very much like to see it done. I'm not 
familiar enough with this area to know what the implications would be 
though.


/Erik

On 2019-11-25 04:48, Baesken, Matthias wrote:

Hello,  any comments on the issue ?

Could we maybe switch from using

NSTextInputSourceIdentifier

to

String  (NSString* ?)   , because 
https://developer.apple.com/documentation/appkit/nstextinputsourceidentifier

says  NSTextInputSourceIdentifieris a typealias for String  ?

Best regards ,Matthias




Hello, I noticed  that since today our  jdk/jdk  build fails on macOS . We run 
it on macOS 10.12 .

It seems
https://hg.openjdk.java.net/jdk/jdk/rev/d0bfaae2ff33

8214578: [macos] Problem with backslashes on macOS/JIS keyboard: Java ignores 
system settings

Brought a  dependency on 10.13.  Was that intended ? Could we keep 10.12  
compatibility ?
At least  the doc of  NSTextInputSourceIdentifier  :   
https://developer.apple.com/documentation/appkit/nstextinputsourceidentifier
mentions  macOS 10.13+  .



Build errors are :


/jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.h:41:5: error: 
unknown type name 'NSTextInputSourceIdentifier'
 NSTextInputSourceIdentifier kbdLayout;
 ^
/jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m:93:23: error: 
assignment to readonly property
 self.cglLayer = windowLayer;
 ~ ^ ~~~
/jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m:110:19: error: 
assignment to readonly property
 self.cglLayer = nil;
 ~ ^ ~~~
3 errors generated.


...
/jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.m:454:18: error: 
incompatible pointer to integer conversion initializing 'BOOL' (aka 'signed 
char') with an expression of type 'id' [-Werror,-Wint-conversion]
 BOOL mouseIsOver = [[window contentView] mouseIsOver];
  ^ ~~
2 errors generated.



Best regards, Matthias


RE: build fails on macOS 10.12 after 8214578: [macos] Problem with backslashes on macOS/JIS keyboard: Java ignores system settings

2019-11-25 Thread Baesken, Matthias
Hello,  any comments on the issue ?

Could we maybe switch from using

NSTextInputSourceIdentifier

to

String  (NSString* ?)   , because 
https://developer.apple.com/documentation/appkit/nstextinputsourceidentifier

says  NSTextInputSourceIdentifieris a typealias for String  ?

Best regards ,Matthias




Hello, I noticed  that since today our  jdk/jdk  build fails on macOS . We run 
it on macOS 10.12 .

It seems
https://hg.openjdk.java.net/jdk/jdk/rev/d0bfaae2ff33

8214578: [macos] Problem with backslashes on macOS/JIS keyboard: Java ignores 
system settings

Brought a  dependency on 10.13.  Was that intended ? Could we keep 10.12  
compatibility ?
At least  the doc of  NSTextInputSourceIdentifier  :   
https://developer.apple.com/documentation/appkit/nstextinputsourceidentifier
mentions  macOS 10.13+  .



Build errors are :


/jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.h:41:5: error: 
unknown type name 'NSTextInputSourceIdentifier'
NSTextInputSourceIdentifier kbdLayout;
^
/jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m:93:23: error: 
assignment to readonly property
self.cglLayer = windowLayer;
~ ^ ~~~
/jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m:110:19: error: 
assignment to readonly property
self.cglLayer = nil;
~ ^ ~~~
3 errors generated.


...
/jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.m:454:18: error: 
incompatible pointer to integer conversion initializing 'BOOL' (aka 'signed 
char') with an expression of type 'id' [-Werror,-Wint-conversion]
BOOL mouseIsOver = [[window contentView] mouseIsOver];
 ^ ~~
2 errors generated.



Best regards, Matthias


build fails on macOS 10.12 after 8214578: [macos] Problem with backslashes on macOS/JIS keyboard: Java ignores system settings

2019-11-21 Thread Baesken, Matthias
Hello, I noticed  that since today our  jdk/jdk  build fails on macOS . We run 
it on macOS 10.12 .

It seems
https://hg.openjdk.java.net/jdk/jdk/rev/d0bfaae2ff33

8214578: [macos] Problem with backslashes on macOS/JIS keyboard: Java ignores 
system settings

Brought a  dependency on 10.13.  Was that intended ? Could we keep 10.12  
compatibility ?
At least  the doc of  NSTextInputSourceIdentifier  :   
https://developer.apple.com/documentation/appkit/nstextinputsourceidentifier
mentions  macOS 10.13+  .



Build errors are :


/jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.h:41:5: error: 
unknown type name 'NSTextInputSourceIdentifier'
NSTextInputSourceIdentifier kbdLayout;
^
/jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m:93:23: error: 
assignment to readonly property
self.cglLayer = windowLayer;
~ ^ ~~~
/jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m:110:19: error: 
assignment to readonly property
self.cglLayer = nil;
~ ^ ~~~
3 errors generated.


...
/jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.m:454:18: error: 
incompatible pointer to integer conversion initializing 'BOOL' (aka 'signed 
char') with an expression of type 'id' [-Werror,-Wint-conversion]
BOOL mouseIsOver = [[window contentView] mouseIsOver];
 ^ ~~
2 errors generated.



Best regards, Matthias