The support for Link Time Optimization in the JDK's make system could do with
some cleaning up, at the moment it simply assumes the compiler is gcc and sets
the flags as such. Instead of introducing changes in bulk, as a first step, it
would be good to simply supply the appropriate flags dependi
On Thu, 11 Aug 2022 02:31:21 GMT, David Holmes wrote:
>> Please review this fix for a problem discovered by @stuart-marks in the
>> course of examining the VM shutdown behaviour. The VM code assumed that only
>> unattached threads called JNI's DestroyJavaVM and so they were always
>> attached
On Tue, 9 Aug 2022 09:31:59 GMT, Thomas Stuefe wrote:
>> David Holmes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed `if` block indentation per Magnus's request
>
> Hi David,
>
> that was interesting. I always thought you have to
> Please review this fix for a problem discovered by @stuart-marks in the
> course of examining the VM shutdown behaviour. The VM code assumed that only
> unattached threads called JNI's DestroyJavaVM and so they were always
> attached as non-daemon threads. But it is perfectly valid to call
>
On Tue, 9 Aug 2022 12:43:36 GMT, Magnus Ihse Bursie wrote:
>> David Holmes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed `if` block indentation per Magnus's request
>
> make/test/JtregNativeHotspot.gmk line 869:
>
>> 867: BU
> Please review this fix for a problem discovered by @stuart-marks in the
> course of examining the VM shutdown behaviour. The VM code assumed that only
> unattached threads called JNI's DestroyJavaVM and so they were always
> attached as non-daemon threads. But it is perfectly valid to call
>
On Tue, 9 Aug 2022 09:26:44 GMT, Thomas Stuefe wrote:
>> Please review this fix for a problem discovered by @stuart-marks in the
>> course of examining the VM shutdown behaviour. The VM code assumed that only
>> unattached threads called JNI's DestroyJavaVM and so they were always
>> attached
On Tue, 9 Aug 2022 08:25:49 GMT, Thomas Stuefe wrote:
>> Please review this fix for a problem discovered by @stuart-marks in the
>> course of examining the VM shutdown behaviour. The VM code assumed that only
>> unattached threads called JNI's DestroyJavaVM and so they were always
>> attached
While setting up the build environment (using WSL 1 (running Debian 11)
on Windows 11), I encountered the following hiccups:
In `BOOTJDK_CHECK_JAVA_IN_PATH_IS_SYMLINK`, the following tests failed
and the boot JDK wasn't detected:
if test -x "$BOOT_JDK/bin/javac" && test -x "$BOOT_JDK/bin/j
