Hi all,
Let's disable `-Werror=strict-overflow` to get it build with gcc7 on Linux/x86.
bytecodeAssembler.cpp
instanceKlass.cpp
klassVtable.cpp
Thanks.
Best regards,
Jie
-
Commit messages:
- 8295435: Build failure with GCC7 after JDK-8294314 due to strict-overflow
warnings
On Wed, 12 Oct 2022 17:00:15 GMT, Andrew Haley wrote:
>> A bug in GCC causes shared libraries linked with -ffast-math to disable
>> denormal arithmetic. This breaks Java's floating-point semantics.
>>
>> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522
>>
>> One solution is to
On Mon, 17 Oct 2022 13:40:23 GMT, Aleksey Shipilev wrote:
>> After [JDK-8294314](https://bugs.openjdk.org/browse/JDK-8294314), we would
>> have signals_posix.cpp excluded with cast-function-type warning:
>
> Aleksey Shipilev has updated the pull request with a new target base due to a
> merge
On Wed, 12 Oct 2022 17:00:15 GMT, Andrew Haley wrote:
>> A bug in GCC causes shared libraries linked with -ffast-math to disable
>> denormal arithmetic. This breaks Java's floating-point semantics.
>>
>> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522
>>
>> One solution is to
On Mon, 10 Oct 2022 14:15:37 GMT, Julian Waters wrote:
> Some external libraries required by native code are linked via linker
> comments embedded in pragmas. Searching for which libraries are linked can
> then become frustrating and confusing since they may be included in an
> obscure place,
On Mon, 17 Oct 2022 18:08:21 GMT, Aleksey Shipilev wrote:
>> There seem to be the only place in Hotspot where this warning fires, yet the
>> warning is disabled wholesale for Hotspot. This is not good.
>>
>> I can trace the addition of char-subscripts exclusion to
>>
On Wed, 12 Oct 2022 17:00:15 GMT, Andrew Haley wrote:
>> A bug in GCC causes shared libraries linked with -ffast-math to disable
>> denormal arithmetic. This breaks Java's floating-point semantics.
>>
>> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522
>>
>> One solution is to
> There are number of places where misleading-indentation is reported by GCC.
> Currently, the warning is disabled for the entirety of Hotspot, which is not
> good.
>
> C1 does an unusual style here. Changing it globally would touch a lot of
> lines. Instead of doing that, I fit the existing
> There seem to be the only place in Hotspot where this warning fires, yet the
> warning is disabled wholesale for Hotspot. This is not good.
>
> I can trace the addition of sequence-point exclusion to
> [JDK-8211029](https://bugs.openjdk.org/browse/JDK-8211029) (Sep 2018), yet
> the only
> After [JDK-8294314](https://bugs.openjdk.org/browse/JDK-8294314), we would
> have `templateTable.cpp` excluded with cast-function-type warning. The
> underlying cause for it is casting functions for `ldc` bytecodes, which take
> `bool`-typed handlers:
Aleksey Shipilev has updated the pull
> There seem to be the only place in Hotspot where this warning fires, yet the
> warning is disabled wholesale for Hotspot. This is not good.
>
> I can trace the addition of char-subscripts exclusion to
> [JDK-8211029](https://bugs.openjdk.org/browse/JDK-8211029) (Sep 2018). The
> only place
On Mon, 17 Oct 2022 17:37:11 GMT, Erik Joelsson wrote:
> I believe this is part of the effort for
> https://bugs.openjdk.org/browse/JDK-8288293.
Agree. I'd prefer to have a different description of the bug though to make it
clear that this is necessary for decoupling a compiler and an OS.
On Mon, 17 Oct 2022 17:16:21 GMT, Alexey Semenyuk wrote:
> The change looks harmless. Howevere I don't understand how searching for the
> standard Windows libs can then become frustrating.
I believe this is part of the effort for
https://bugs.openjdk.org/browse/JDK-8288293.
-
On Mon, 17 Oct 2022 15:46:11 GMT, Aleksey Shipilev wrote:
> While adapting my CI to build hsdis automatically, I realized that sometimes
> we miss the proper $AR for binutils cross-build. Configure would then fail
> like:
>
>
> $ CXX=aarch64-linux-gnu-g++ CC=aarch64-linux-gnu-gcc sh
On Mon, 17 Oct 2022 14:41:06 GMT, Julian Waters wrote:
>> Some external libraries required by native code are linked via linker
>> comments embedded in pragmas. Searching for which libraries are linked can
>> then become frustrating and confusing since they may be included in an
>> obscure
On Mon, 17 Oct 2022 14:41:06 GMT, Julian Waters wrote:
>> Some external libraries required by native code are linked via linker
>> comments embedded in pragmas. Searching for which libraries are linked can
>> then become frustrating and confusing since they may be included in an
>> obscure
While adapting my CI to build hsdis automatically, I realized that sometimes we
miss the proper $AR for binutils cross-build. Configure would then fail like:
$ CXX=aarch64-linux-gnu-g++ CC=aarch64-linux-gnu-gcc sh ./configure
--with-debug-level=fastdebug --openjdk-target=aarch64-linux-gnu
> Some external libraries required by native code are linked via linker
> comments embedded in pragmas. Searching for which libraries are linked can
> then become frustrating and confusing since they may be included in an
> obscure place, and for all relevant compilers there is no difference
On Mon, 17 Oct 2022 14:31:46 GMT, Julian Waters wrote:
>> Some external libraries required by native code are linked via linker
>> comments embedded in pragmas. Searching for which libraries are linked can
>> then become frustrating and confusing since they may be included in an
>> obscure
> Some external libraries required by native code are linked via linker
> comments embedded in pragmas. Searching for which libraries are linked can
> then become frustrating and confusing since they may be included in an
> obscure place, and for all relevant compilers there is no difference
> Some external libraries required by native code are linked via linker
> comments embedded in pragmas. Searching for which libraries are linked can
> then become frustrating and confusing since they may be included in an
> obscure place, and for all relevant compilers there is no difference
> Some external libraries required by native code are linked via linker
> comments embedded in pragmas. Searching for which libraries are linked can
> then become frustrating and confusing since they may be included in an
> obscure place, and for all relevant compilers there is no difference
On Sun, 16 Oct 2022 13:18:14 GMT, Alan Bateman wrote:
>> Julian Waters has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update Guid.cpp
>
> src/java.base/windows/native/libnio/ch/FileDispatcherImpl.c line 38:
>
>> 36:
>> 37: #include
> Some external libraries required by native code are linked via linker
> comments embedded in pragmas. Searching for which libraries are linked can
> then become frustrating and confusing since they may be included in an
> obscure place, and for all relevant compilers there is no difference
On Mon, 17 Oct 2022 09:24:58 GMT, Magnus Ihse Bursie wrote:
> @TheShermanTanker Question: is this a Windows-specific thing, or are there
> pragma-loaded libraries for other compilers as well?
To my knowledge only Visual C++ has the ability to perform linking through
pragmas, the comment
On Thu, 13 Oct 2022 07:43:33 GMT, Ludovic Henry wrote:
> Currently, when passing --with-binutils-src, binutils is built in the source
> tree. That leads to conflicting targets when compiling for different
> architectures (ex: amd64 on the host, and riscv64 or aarch64 for the target)
> from
> After [JDK-8294314](https://bugs.openjdk.org/browse/JDK-8294314), we would
> have `templateTable.cpp` excluded with cast-function-type warning. The
> underlying cause for it is casting functions for `ldc` bytecodes, which take
> `bool`-typed handlers:
Aleksey Shipilev has updated the pull
On Mon, 17 Oct 2022 13:40:23 GMT, Aleksey Shipilev wrote:
>> After [JDK-8294314](https://bugs.openjdk.org/browse/JDK-8294314), we would
>> have signals_posix.cpp excluded with cast-function-type warning:
>
> Aleksey Shipilev has updated the pull request with a new target base due to a
> merge
> After [JDK-8294314](https://bugs.openjdk.org/browse/JDK-8294314), we would
> have signals_posix.cpp excluded with cast-function-type warning:
Aleksey Shipilev has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains five commits:
- Merge
> Currently, when passing --with-binutils-src, binutils is built in the source
> tree. That leads to conflicting targets when compiling for different
> architectures (ex: amd64 on the host, and riscv64 or aarch64 for the target)
> from the same jdk source tree.
>
> The simplest solution is to
On Mon, 17 Oct 2022 09:17:09 GMT, Magnus Ihse Bursie wrote:
>> Ludovic Henry has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
On Wed, 12 Oct 2022 08:07:35 GMT, Magnus Ihse Bursie wrote:
> Sometimes, the configure script is not called directly, but indirectly, using
> e.g. a wrapper script. This happens for instance in the case of using jib.sh.
>
> In such cases, calling "make reconfigure" will not re-execute the
On Mon, 10 Oct 2022 14:15:37 GMT, Julian Waters wrote:
> Some external libraries required by native code are linked via linker
> comments embedded in pragmas. Searching for which libraries are linked can
> then become frustrating and confusing since they may be included in an
> obscure place,
On Mon, 10 Oct 2022 15:29:16 GMT, Julian Waters wrote:
>> Several parts of the make system in the JDK has large parts of cluttered if
>> branches dedicated to setting flags for the specific compiler used in the
>> build. This could be more neatly accomplished by instead adding more target
>>
On Thu, 13 Oct 2022 08:41:35 GMT, Ludovic Henry wrote:
>> Currently, when passing --with-binutils-src, binutils is built in the source
>> tree. That leads to conflicting targets when compiling for different
>> architectures (ex: amd64 on the host, and riscv64 or aarch64 for the target)
>>
On Tue, 11 Oct 2022 08:18:08 GMT, Christian Hagedorn
wrote:
>> The DWARF debugging symbols emitted by Clang is different from what GCC is
>> emitting. While GCC produces a complete `.debug_aranges` section (which is
>> required in the DWARF parser), Clang does not. As a result, the DWARF
On Sat, 15 Oct 2022 08:11:39 GMT, Kim Barrett wrote:
> Looks good.
I think you want to do the actual "Approve" to supersede your previous "Request
changes" review.
Anyway, I think we are good for integration here, @magicus?
-
PR: https://git.openjdk.org/jdk/pull/10414
On Mon, 10 Oct 2022 14:15:37 GMT, Julian Waters wrote:
> Some external libraries required by native code are linked via linker
> comments embedded in pragmas. Searching for which libraries are linked can
> then become frustrating and confusing since they may be included in an
> obscure place,
38 matches
Mail list logo
