Integrated: 8297088: Update LCMS to 2.14

2022-11-18 Thread Alisen Chung
On Thu, 17 Nov 2022 19:05:36 GMT, Alisen Chung wrote: > Redo of 8295369: Update LCMS to 2.14 > Update LCMS to newest release. > Updated DISABLED_WARNINGS_gcc for LCMS to include type limits to prevent a > build error in linux. > Automatic tests and J2D demo tests were run. This pull request has

Re: RFR: 8297088: Update LCMS to 2.14

2022-11-18 Thread Harshitha Onkar
On Thu, 17 Nov 2022 19:05:36 GMT, Alisen Chung wrote: > Redo of 8295369: Update LCMS to 2.14 > Update LCMS to newest release. > Updated DISABLED_WARNINGS_gcc for LCMS to include type limits to prevent a > build error in linux. > Automatic tests and J2D demo tests were run. Marked as reviewed by

Re: RFR: 8297088: Update LCMS to 2.14

2022-11-18 Thread Phil Race
On Thu, 17 Nov 2022 19:05:36 GMT, Alisen Chung wrote: > Redo of 8295369: Update LCMS to 2.14 > Update LCMS to newest release. > Updated DISABLED_WARNINGS_gcc for LCMS to include type limits to prevent a > build error in linux. > Automatic tests and J2D demo tests were run. Marked as reviewed by

Re: RFR: 8296904: Improve handling of macos xcode toolchain [v8]

2022-11-18 Thread Magnus Ihse Bursie
On Fri, 18 Nov 2022 12:06:39 GMT, Christoph Langer wrote: >> With this PR I'd like to make it easier to use dedicated installations of >> Xcode on Mac OS for OpenJDK builds without having to switch the active Xcode >> globally via `xcode-select`. >> >> I propose adding a new configure flag `--

Re: RFR: 8293422: DWARF emitted by Clang cannot be parsed [v6]

2022-11-18 Thread Thomas Stuefe
On Fri, 18 Nov 2022 16:06:38 GMT, Christian Hagedorn wrote: >> The DWARF debugging symbols emitted by Clang is different from what GCC is >> emitting. While GCC produces a complete `.debug_aranges` section (which is >> required in the DWARF parser), Clang does not. As a result, the DWARF parse

Re: RFR: 8293422: DWARF emitted by Clang cannot be parsed [v4]

2022-11-18 Thread Christian Hagedorn
On Wed, 16 Nov 2022 08:48:51 GMT, Thomas Stuefe wrote: >> Yes, I think it would be good to get a second review of the DWARF parser >> changes. Maybe @tstuefe? > >> Yes, I think it would be good to get a second review of the DWARF parser >> changes. Maybe @tstuefe? > > I'm a bit swamped, but tr

Re: RFR: 8293422: DWARF emitted by Clang cannot be parsed [v6]

2022-11-18 Thread Christian Hagedorn
> The DWARF debugging symbols emitted by Clang is different from what GCC is > emitting. While GCC produces a complete `.debug_aranges` section (which is > required in the DWARF parser), Clang does not. As a result, the DWARF parser > cannot find the necessary information to proceed and create t

Re: RFR: 8293422: DWARF emitted by Clang cannot be parsed [v5]

2022-11-18 Thread Christian Hagedorn
> The DWARF debugging symbols emitted by Clang is different from what GCC is > emitting. While GCC produces a complete `.debug_aranges` section (which is > required in the DWARF parser), Clang does not. As a result, the DWARF parser > cannot find the necessary information to proceed and create t

Re: RFR: 8293422: DWARF emitted by Clang cannot be parsed [v4]

2022-11-18 Thread Christian Hagedorn
On Wed, 16 Nov 2022 16:07:36 GMT, Thomas Stuefe wrote: >> In theory, they don't need to be exposed in the sense of being declared in >> the header. But in terms of readability, I've decided to put them in the >> private block of class `LineNumberProgram` which is the only user of these >> meth

Re: RFR: 8296904: Improve handling of macos xcode toolchain [v8]

2022-11-18 Thread Magnus Ihse Bursie
On Fri, 18 Nov 2022 12:06:39 GMT, Christoph Langer wrote: >> With this PR I'd like to make it easier to use dedicated installations of >> Xcode on Mac OS for OpenJDK builds without having to switch the active Xcode >> globally via `xcode-select`. >> >> I propose adding a new configure flag `--

Re: RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v5]

2022-11-18 Thread Julian Waters
On Fri, 18 Nov 2022 11:27:14 GMT, Magnus Ihse Bursie wrote: > Aaaahhh, **that** bug. I've run into that before. I did attempt to fix it but > after wasting too many hours I gave up. :-( It seems to be a limitation in m4 > that I cannot understand how to get around. At some point, the string >

Re: RFR: 8296904: Improve handling of macos xcode toolchain [v8]

2022-11-18 Thread Christoph Langer
On Fri, 18 Nov 2022 12:06:39 GMT, Christoph Langer wrote: >> With this PR I'd like to make it easier to use dedicated installations of >> Xcode on Mac OS for OpenJDK builds without having to switch the active Xcode >> globally via `xcode-select`. >> >> I propose adding a new configure flag `--

Re: RFR: 8296904: Improve handling of macos xcode toolchain [v8]

2022-11-18 Thread Christoph Langer
> With this PR I'd like to make it easier to use dedicated installations of > Xcode on Mac OS for OpenJDK builds without having to switch the active Xcode > globally via `xcode-select`. > > I propose adding a new configure flag `--with-xcode-path` that takes the path > to an Xcode installation.

Re: RFR: 8296904: Improve handling of macos xcode toolchain [v7]

2022-11-18 Thread Christoph Langer
> With this PR I'd like to make it easier to use dedicated installations of > Xcode on Mac OS for OpenJDK builds without having to switch the active Xcode > globally via `xcode-select`. > > I propose adding a new configure flag `--with-xcode-path` that takes the path > to an Xcode installation.

Re: RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v5]

2022-11-18 Thread Magnus Ihse Bursie
On Thu, 17 Nov 2022 06:36:50 GMT, Julian Waters wrote: >> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available >> when both 8282948 and 8282700 were written. They can now be moved to using >> the cleaner logic that UTIL_ARG_WITH grants. >> >> There are many more options

Re: RFR: 8296904: Improve handling of macos xcode toolchain [v6]

2022-11-18 Thread Magnus Ihse Bursie
On Thu, 17 Nov 2022 21:54:53 GMT, Christoph Langer wrote: >> With this PR I'd like to make it easier to use dedicated installations of >> Xcode on Mac OS for OpenJDK builds without having to switch the active Xcode >> globally via `xcode-select`. >> >> I propose adding a new configure flag `--

Re: RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v5]

2022-11-18 Thread Julian Waters
On Thu, 17 Nov 2022 06:36:50 GMT, Julian Waters wrote: >> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available >> when both 8282948 and 8282700 were written. They can now be moved to using >> the cleaner logic that UTIL_ARG_WITH grants. >> >> There are many more options

Re: RFR: 8297088: Update LCMS to 2.14

2022-11-18 Thread Sergey Bylokhov
On Thu, 17 Nov 2022 19:05:36 GMT, Alisen Chung wrote: > Redo of 8295369: Update LCMS to 2.14 > Update LCMS to newest release. > Updated DISABLED_WARNINGS_gcc for LCMS to include type limits to prevent a > build error in linux. > Automatic tests and J2D demo tests were run. Marked as reviewed by

Re: RFR: 8297088: Update LCMS to 2.14

2022-11-18 Thread Sergey Bylokhov
On Thu, 17 Nov 2022 19:05:36 GMT, Alisen Chung wrote: > Redo of 8295369: Update LCMS to 2.14 > Update LCMS to newest release. > Updated DISABLED_WARNINGS_gcc for LCMS to include type limits to prevent a > build error in linux. > Automatic tests and J2D demo tests were run. make/modules/java.des