Re: RFR: 8307652: sealed class hierarchy graph doesn't distinguish non-sealed classes

2023-05-14 Thread Per Minborg
On Tue, 9 May 2023 04:11:03 GMT, Chen Liang wrote: > `@sealedGraph` had a mechanism to render non-sealed classes differently, but > it's useless because the graph nodes are not bordered. This patch converts > the non-sealed classes to be rendered in italics instead. > > An example of `Constant

Re: RFR: 8307855: update for deprecated sprintf for src/utils [v2]

2023-05-14 Thread Xue-Lei Andrew Fan
On Sun, 14 May 2023 00:44:45 GMT, Kim Barrett wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> update typo in copyright statement > > src/utils/hsdis/binutils/hsdis-binutils.c line 251: > >> 249: if (type)

Re: RFR: 8307855: update for deprecated sprintf for src/utils [v2]

2023-05-14 Thread Xue-Lei Andrew Fan
On Sun, 14 May 2023 00:43:51 GMT, Kim Barrett wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> update typo in copyright statement > > src/utils/hsdis/binutils/hsdis-binutils.c line 222: > >> 220: const decode

Re: RFR: 8307855: update for deprecated sprintf for src/utils [v2]

2023-05-14 Thread Xue-Lei Andrew Fan
On Fri, 12 May 2023 14:52:59 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because >> of security concerns. The issue was addressed in >> [JDK-8296812](https://bugs.openjdk.org/browse/JDK

Integrated: 8308072: [BACKOUT] update for deprecated sprintf for src/utils

2023-05-14 Thread Tobias Hartmann
On Mon, 15 May 2023 05:13:00 GMT, Tobias Hartmann wrote: > Clean backout of https://github.com/openjdk/jdk/pull/13915 / > [JDK-8307855](https://bugs.openjdk.org/browse/JDK-8307855) because > @kimbarrett noticed some issues after integration. Also the change is > non-trivial and therefore missi

Re: RFR: 8308072: [BACKOUT] update for deprecated sprintf for src/utils

2023-05-14 Thread Tobias Hartmann
On Mon, 15 May 2023 05:13:00 GMT, Tobias Hartmann wrote: > Clean backout of https://github.com/openjdk/jdk/pull/13915 / > [JDK-8307855](https://bugs.openjdk.org/browse/JDK-8307855) because > @kimbarrett noticed some issues after integration. Also the change is > non-trivial and therefore missi

Re: RFR: 8308072: [BACKOUT] update for deprecated sprintf for src/utils

2023-05-14 Thread Iris Clark
On Mon, 15 May 2023 05:13:00 GMT, Tobias Hartmann wrote: > Clean backout of https://github.com/openjdk/jdk/pull/13915 / > [JDK-8307855](https://bugs.openjdk.org/browse/JDK-8307855) because > @kimbarrett noticed some issues after integration. Also the change is > non-trivial and therefore missi

RFR: 8308072: [BACKOUT] update for deprecated sprintf for src/utils

2023-05-14 Thread Tobias Hartmann
Clean backout of https://github.com/openjdk/jdk/pull/13915 / [JDK-8307855](https://bugs.openjdk.org/browse/JDK-8307855) because @kimbarrett noticed some issues after integration. Also the change is non-trivial and therefore missing a second review. Thanks, Tobias - Commit messages

Re: RFR: 8307855: update for deprecated sprintf for src/utils [v2]

2023-05-14 Thread Tobias Hartmann
On Fri, 12 May 2023 14:52:59 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because >> of security concerns. The issue was addressed in >> [JDK-8296812](https://bugs.openjdk.org/browse/JDK

Withdrawn: JDK-8300531: Update MSVC optimization flags to match GCC/Clang

2023-05-14 Thread duke
On Wed, 18 Jan 2023 14:32:20 GMT, Justin King wrote: > Update MSVC CFlags to be more consistent with other compilers. Also disables > RTTI in a simliar manner to GCC/Clang for the JVM. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pu