Re: RFR: 8309468: Remove jvmti Allocate locker test case

2023-06-12 Thread Serguei Spitsyn
On Mon, 12 Jun 2023 16:39:12 GMT, Leo Korinth wrote: > There is a bunch of tests that are used to test critical section/gc locker. > One of the test is named jvmti locker. In that test, JNI code is doing a loop > of ` jvmti->Allocate()` followed `sleep()` followed by a > `jvmti->Deallocate()`.

Re: RFR: 8309468: Remove jvmti Allocate locker test case

2023-06-12 Thread Leonid Mesnik
On Mon, 12 Jun 2023 16:39:12 GMT, Leo Korinth wrote: > There is a bunch of tests that are used to test critical section/gc locker. > One of the test is named jvmti locker. In that test, JNI code is doing a loop > of ` jvmti->Allocate()` followed `sleep()` followed by a > `jvmti->Deallocate()`.

Re: RFR: 8309468: Remove jvmti Allocate locker test case

2023-06-12 Thread David Holmes
On Mon, 12 Jun 2023 16:39:12 GMT, Leo Korinth wrote: > There is a bunch of tests that are used to test critical section/gc locker. > One of the test is named jvmti locker. In that test, JNI code is doing a loop > of ` jvmti->Allocate()` followed `sleep()` followed by a > `jvmti->Deallocate()`.

Re: RFR: 8307527: MacOS Zero builds fail with undefined FFI_GO_CLOSURES after JDK-8304265 [v2]

2023-06-12 Thread Jorn Vernee
On Mon, 8 May 2023 10:18:35 GMT, Aleksey Shipilev wrote: >> See the bug. Actually, I am not sure why JDK-8304265 changed the `#ifndef >> FFI_GO_CLOSURES` to `#ifdef _APPLE_`. That seems too intrusive if >> `FFI_GO_CLOSURES` *is* enabled. So I rewrote the block to something more >> safe. >> >>

Re: RFR: 8306281: function isWsl() returns false on WSL2

2023-06-12 Thread Erik Joelsson
On Mon, 12 Jun 2023 09:46:50 GMT, Ivan Bereziuk wrote: > Currently _isWsl()_ function is looking for "Microsoft" string in the _kernel > release_ string (`$ uname -r`). > That's not always true. Namely, on Ubuntu 22.04 - currently the newest Ubuntu > LTS and default OS for WSL in Microsoft Sto

RFR: 8306281: function isWsl() returns false on WSL2

2023-06-12 Thread Ivan Bereziuk
Currently _isWsl()_ function is looking for "Microsoft" string in the _kernel release_ string (`$ uname -r`). That's not always true. Namely, on Ubuntu 22.04 - currently the newest Ubuntu LTS and default OS for WSL in Microsoft Store. In there `$ uname -r` command outputs "5.10.102.1-microsoft-

Withdrawn: 8295146: Clean up native code with newer C/C++ language features

2023-06-12 Thread duke
On Thu, 10 Nov 2022 06:20:41 GMT, Julian Waters wrote: > After [JDK-8292008](https://bugs.openjdk.org/browse/JDK-8292008) and > [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283), some C and C++ > code across the JDK can be replaced and simplified with cleaner language > features that

RFR: 8309468: Remove jvmti Allocate locker test case

2023-06-12 Thread Leo Korinth
There is a bunch of tests that are used to test critical section/gc locker. One of the test is named jvmti locker. In that test, JNI code is doing a loop of ` jvmti->Allocate()` followed `sleep()` followed by a `jvmti->Deallocate()`. There is no JVM lock implementation to be tested on jvmti Allo

Integrated: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries

2023-06-12 Thread Jiangli Zhou
On Fri, 19 May 2023 20:18:53 GMT, Jiangli Zhou wrote: > Original description for JDK-8307194 change: > - > This PR is branched from the makefile changes for > https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for > handling the JDK/hotspot static libraries: > > - Buil

Re: RFR: 8308286 Fix clang warnings in linux code [v5]

2023-06-12 Thread Erik Joelsson
On Sun, 11 Jun 2023 16:38:31 GMT, Artem Semenov wrote: >> When using the clang compiler to build OpenJDk on Linux, we encounter >> various "warnings as errors". >> They can be fixed with small changes. > > Artem Semenov has updated the pull request with a new target base due to a > merge or a r