Integrated: 8355249: Remove the use of WMIC from the entire source code

2025-05-06 Thread Daishi Tabata
On Tue, 22 Apr 2025 07:29:08 GMT, Daishi Tabata wrote: > After searching the entire JDK source code, I found that WMIC is only used in > four files. These WMIC calls can be replaced with PowerShell for WMI. > > The primary challenge in this replacement is to make it work the same as > before,

Integrated: 8354257: xctracenorm profiler not working with JDK JMH benchmarks

2025-05-06 Thread Galder Zamarreño
On Thu, 10 Apr 2025 12:02:45 GMT, Galder Zamarreño wrote: > Avoid filtering out xml files at the root of the JMH folder, in order to get > the `default.instruments.template.xml` file bundled in the JMH core jar to > support xtrace profiler. This pull request has now been integrated. Changeset

Re: RFR: 8354257: xctracenorm profiler not working with JDK JMH benchmarks

2025-05-06 Thread duke
On Thu, 10 Apr 2025 12:02:45 GMT, Galder Zamarreño wrote: > Avoid filtering out xml files at the root of the JMH folder, in order to get > the `default.instruments.template.xml` file bundled in the JMH core jar to > support xtrace profiler. @galderz Your change (at version a2b73be2533635ee169

Re: RFR: 8301971: Make JDK source code UTF-8 [v3]

2025-05-06 Thread Yi Yang
On Thu, 17 Apr 2025 16:26:59 GMT, Naoto Sato wrote: >>> We will probably need to make sure things are ok on Windows as well (they >>> are the other confusing environment) >> >> Windows is much more painful to work with, since there is no correspondence >> of `LC_ALL`; you must set the user's l

Re: RFR: 8355249: Remove the use of WMIC from the entire source code [v2]

2025-05-06 Thread Daishi Tabata
On Tue, 22 Apr 2025 07:41:43 GMT, Daishi Tabata wrote: >> After searching the entire JDK source code, I found that WMIC is only used >> in four files. These WMIC calls can be replaced with PowerShell for WMI. >> >> The primary challenge in this replacement is to make it work the same as >> bef

Re: RFR: 8355249: Remove the use of WMIC from the entire source code [v2]

2025-05-06 Thread duke
On Tue, 22 Apr 2025 07:41:43 GMT, Daishi Tabata wrote: >> After searching the entire JDK source code, I found that WMIC is only used >> in four files. These WMIC calls can be replaced with PowerShell for WMI. >> >> The primary challenge in this replacement is to make it work the same as >> bef

Re: RFR: 8282493: Add --with-jcov-modules convenience option [v3]

2025-05-06 Thread Erik Joelsson
On Tue, 6 May 2025 15:06:36 GMT, Magnus Ihse Bursie wrote: >> Allow the user to set "--with-jcov-modules=java.desktop", instead of >> "--with-jcov-filters=--include-modules java.desktop", since this is one of >> the common use cases for the filtering. > > Magnus Ihse Bursie has updated the pull

Re: RFR: 8282493: Add --with-jcov-modules convenience option [v3]

2025-05-06 Thread Erik Joelsson
On Tue, 6 May 2025 20:59:35 GMT, Sergey Bylokhov wrote: >> make/RunTests.gmk line 1376: >> >>> 1374: jcov-gen-report: jcov-stop-grabber >>> 1375: $(call LogWarn, Generating JCov report ...) >>> 1376: $(call ExecuteWithLog, $(JCOV_SUPPORT_DIR)/run-jcov-repgen, >> >> Shouldn't there

Re: RFR: 8355003: Implement Ahead-of-Time Method Profiling [v14]

2025-05-06 Thread Igor Veresov
> Improve warm-up time by making profile data from a previous run of an > application instantly available, when the HotSpot Java Virtual Machine > starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483) > to store method execution profiles from training runs, reducing profili

Re: RFR: 8355003: Implement Ahead-of-Time Method Profiling [v13]

2025-05-06 Thread Igor Veresov
On Tue, 6 May 2025 18:48:03 GMT, Chris Plummer wrote: >> Igor Veresov has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 43 commits: >> >> - Merge branch 'master' into pp2 >> - Fix compile >> - Fix additional issues >> - Make sur

Re: RFR: 8282493: Add --with-jcov-modules convenience option [v3]

2025-05-06 Thread Sergey Bylokhov
On Tue, 6 May 2025 15:06:36 GMT, Magnus Ihse Bursie wrote: >> Allow the user to set "--with-jcov-modules=java.desktop", instead of >> "--with-jcov-filters=--include-modules java.desktop", since this is one of >> the common use cases for the filtering. > > Magnus Ihse Bursie has updated the pull

Re: RFR: 8282493: Add --with-jcov-modules convenience option [v3]

2025-05-06 Thread Sergey Bylokhov
On Tue, 6 May 2025 20:58:17 GMT, Sergey Bylokhov wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update copyright year >> - Update testing documentation > > make/RunTests.gmk line 1376: > >> 1374: jcov-

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v13]

2025-05-06 Thread Brian Burkhalter
> This proposed change would move the native objects required for NIO file > interaction from the libnio native library to the libjava native library on > Linux, macOS, and Windows. Brian Burkhalter has updated the pull request with a new target base due to a merge or a rebase. The pull request

Re: RFR: 8282493: Add --with-jcov-modules convenience option [v3]

2025-05-06 Thread Sergey Bylokhov
On Tue, 6 May 2025 15:06:36 GMT, Magnus Ihse Bursie wrote: >> Allow the user to set "--with-jcov-modules=java.desktop", instead of >> "--with-jcov-filters=--include-modules java.desktop", since this is one of >> the common use cases for the filtering. > > Magnus Ihse Bursie has updated the pull

Integrated: 8356226: JCov Grabber server didn't respond

2025-05-06 Thread Alexandre Iline
On Tue, 6 May 2025 03:23:19 GMT, Alexandre Iline wrote: > Fix is to allow bigger XML files. This pull request has now been integrated. Changeset: e2df9cde Author:Alexandre Iline URL: https://git.openjdk.org/jdk/commit/e2df9cdeb081735bddd24ac2622f59e20cda47ad Stats: 5 lines in 1

Re: RFR: 8355003: Implement Ahead-of-Time Method Profiling [v13]

2025-05-06 Thread Chris Plummer
On Tue, 6 May 2025 06:31:43 GMT, Igor Veresov wrote: >> Improve warm-up time by making profile data from a previous run of an >> application instantly available, when the HotSpot Java Virtual Machine >> starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483) >> to store met

Re: RFR: 8301971: Make JDK source code UTF-8 [v5]

2025-05-06 Thread Erik Joelsson
On Tue, 6 May 2025 15:39:04 GMT, Magnus Ihse Bursie wrote: >> Most of the JDK code base has been transitioned to UTF-8, but not all. This >> has recently become an acute problem, since our mixing of iso-8859-1 and >> utf-8 in properties files confused the version of `sed` that is shipped with

Re: RFR: 8356226: JCov Grabber server didn't respond [v2]

2025-05-06 Thread Erik Joelsson
On Tue, 6 May 2025 16:38:54 GMT, Alexandre Iline wrote: >> Fix is to allow bigger XML files. > > Alexandre Iline has updated the pull request incrementally with two > additional commits since the last revision: > > - Recover spaces > - Declare JCOV_VM_OPTS, set the XML options to 0 Marked as

Re: RFR: 8282493: Add --with-jcov-modules convenience option [v3]

2025-05-06 Thread Erik Joelsson
On Tue, 6 May 2025 15:06:36 GMT, Magnus Ihse Bursie wrote: >> Allow the user to set "--with-jcov-modules=java.desktop", instead of >> "--with-jcov-filters=--include-modules java.desktop", since this is one of >> the common use cases for the filtering. > > Magnus Ihse Bursie has updated the pull

Re: RFR: 8355249: Remove the use of WMIC from the entire source code [v2]

2025-05-06 Thread Alexey Semenyuk
On Tue, 22 Apr 2025 07:41:43 GMT, Daishi Tabata wrote: >> After searching the entire JDK source code, I found that WMIC is only used >> in four files. These WMIC calls can be replaced with PowerShell for WMI. >> >> The primary challenge in this replacement is to make it work the same as >> bef

Re: RFR: 8356226: JCov Grabber server didn't respond [v2]

2025-05-06 Thread Alexandre Iline
> Fix is to allow bigger XML files. Alexandre Iline has updated the pull request incrementally with two additional commits since the last revision: - Recover spaces - Declare JCOV_VM_OPTS, set the XML options to 0 - Changes: - all: https://git.openjdk.org/jdk/pull/25056/files

Re: RFR: 8355452: GHA: Test jtreg tier1 on linux-x64 static-jdk

2025-05-06 Thread Magnus Ihse Bursie
On Mon, 5 May 2025 21:39:15 GMT, Jiangli Zhou wrote: >> .github/workflows/test.yml line 95: >> >>> 93: - test-name: 'hs/tier1 common' >>> 94: test-suite: 'test/hotspot/jtreg/:tier1_common' >>> 95: debug-suffix: ${{ inputs.debug-suffix }} >> >> I don't understan

Re: RFR: 8301971: Make JDK source code UTF-8 [v5]

2025-05-06 Thread Magnus Ihse Bursie
> Most of the JDK code base has been transitioned to UTF-8, but not all. This > has recently become an acute problem, since our mixing of iso-8859-1 and > utf-8 in properties files confused the version of `sed` that is shipped with > the new macOS 15.4. > > The fix is basically simple, and incl

Re: RFR: 8301971: Make JDK source code UTF-8 [v3]

2025-05-06 Thread Magnus Ihse Bursie
On Wed, 16 Apr 2025 10:35:02 GMT, Matthias Baesken wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Also document UTF-8 requirements (solves JDK-8338973) >> - Let configure only accept utf-8 locales >> -

Re: RFR: 8301971: Make JDK source code UTF-8 [v4]

2025-05-06 Thread Magnus Ihse Bursie
> Most of the JDK code base has been transitioned to UTF-8, but not all. This > has recently become an acute problem, since our mixing of iso-8859-1 and > utf-8 in properties files confused the version of `sed` that is shipped with > the new macOS 15.4. > > The fix is basically simple, and incl

Re: RFR: 8301971: Make JDK source code UTF-8 [v3]

2025-05-06 Thread Magnus Ihse Bursie
On Thu, 17 Apr 2025 16:26:59 GMT, Naoto Sato wrote: >>> We will probably need to make sure things are ok on Windows as well (they >>> are the other confusing environment) >> >> Windows is much more painful to work with, since there is no correspondence >> of `LC_ALL`; you must set the user's l

Re: RFR: 8282493: Add --with-jcov-modules convenience option

2025-05-06 Thread Magnus Ihse Bursie
On Mon, 21 Apr 2025 06:58:52 GMT, Sergey Bylokhov wrote: >> Allow the user to set "--with-jcov-modules=java.desktop", instead of >> "--with-jcov-filters=--include-modules java.desktop", since this is one of >> the common use cases for the filtering. > > Description of the new option can be adde

Re: RFR: 8282493: Add --with-jcov-modules convenience option [v3]

2025-05-06 Thread Magnus Ihse Bursie
On Sun, 20 Apr 2025 03:52:38 GMT, SendaoYan wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update copyright year >> - Update testing documentation > > Should we update the copyright year from 2024 to 2025

Re: RFR: 8282493: Add --with-jcov-modules convenience option [v3]

2025-05-06 Thread Magnus Ihse Bursie
> Allow the user to set "--with-jcov-modules=java.desktop", instead of > "--with-jcov-filters=--include-modules java.desktop", since this is one of > the common use cases for the filtering. Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last

Re: RFR: 8282493: Add --with-jcov-modules convenience option [v2]

2025-05-06 Thread Magnus Ihse Bursie
> Allow the user to set "--with-jcov-modules=java.desktop", instead of > "--with-jcov-filters=--include-modules java.desktop", since this is one of > the common use cases for the filtering. Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The in