Integrated: 8317376: Minor improvements to the 'this' escape analyzer

2024-04-17 Thread Archie Cobbs
On Mon, 16 Oct 2023 22:08:53 GMT, Archie Cobbs wrote: > Please review several fixes and improvements to the `this-escape` lint > warning analyzer. > > The goal here is to apply some relatively simple logical fixes that improve > the precision and accuracy of the analyzer,

Re: RFR: 8317376: Minor improvements to the 'this' escape analyzer [v4]

2024-04-16 Thread Archie Cobbs
On Tue, 16 Apr 2024 18:00:50 GMT, Vicente Romero wrote: >> Archie Cobbs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains eight commits: >> >> - Merge branch 'master' into JDK-8317376 >>

Re: RFR: 8317376: Minor improvements to the 'this' escape analyzer [v5]

2024-04-16 Thread Archie Cobbs
nce. > > In other words, we should be treating "via an outer instance" as just another > flavor of indirection along with "direct" and "indirect". > > As a result, with this patch the `OuterRef` class goes away and a new > `Indirection` enum has been

Re: RFR: 8317376: Minor improvements to the 'this' escape analyzer [v4]

2024-04-09 Thread Archie Cobbs
nce. > > In other words, we should be treating "via an outer instance" as just another > flavor of indirection along with "direct" and "indirect". > > As a result, with this patch the `OuterRef` class goes away and a new > `Indirection` enum has been

Re: RFR: 8317376: Minor improvements to the 'this' escape analyzer [v3]

2024-02-16 Thread Archie Cobbs
nce. > > In other words, we should be treating "via an outer instance" as just another > flavor of indirection along with "direct" and "indirect". > > As a result, with this patch the `OuterRef` class goes away and a new > `Indirection` enum has been

Re: RFR: 8317376: Minor improvements to the 'this' escape analyzer [v2]

2024-01-19 Thread Archie Cobbs
nce. > > In other words, we should be treating "via an outer instance" as just another > flavor of indirection along with "direct" and "indirect". > > As a result, with this patch the `OuterRef` class goes away and a new > `Indirection` enum has been

Re: RFR: 8317376: Minor improvements to the 'this' escape analyzer

2023-12-20 Thread Archie Cobbs
On Wed, 20 Dec 2023 09:03:34 GMT, Daniel Fuchs wrote: > I assume these were the reason why this-escape analysis had been disabled on > java.net.http, and I expect the reason why the analysis can be reenabled by > default is because of point 3 above? No, the goal here is simply to remove unnece

RFR: 8317376: Minor improvements to the 'this' escape analyzer

2023-12-19 Thread Archie Cobbs
Please review several fixes and improvements to the `this-escape` lint warning analyzer. The goal here is to apply some relatively simple logical fixes that improve the precision and accuracy of the analyzer, and capture the remaining low-hanging fruit so we can consider the analyzer relatively