On Sat, 29 Oct 2022 23:08:38 GMT, Sergey Bylokhov wrote:
> What about possibility to run additional group of the test by passing somehow
> the name of group to the GA, via label or via /test cmd, or via parameter to
> the specific task in GA?
Well, it sounds good to run specific tests via labe
On Sat, 29 Oct 2022 07:58:49 GMT, Alan Bateman wrote:
> I realise there are already some test lists in both the hotspot and jdk
> TEST.groups but it feels like it needs something better so that
> RunTests.gmk/jtreg can select the sanity tests to run.
Thanks @AlanBateman for this comment.
Is th
On Fri, 28 Oct 2022 07:19:31 GMT, Jie Fu wrote:
>> Hi all,
>>
>> As discussed here
>> https://github.com/openjdk/jdk/pull/10807#pullrequestreview-1150314487 , it
>> would be better to add the vector api tests in GHA.
>>
>> Thanks.
>> Best regards,
>> Jie
>
> Jie Fu has updated the pull reques
On Fri, 28 Oct 2022 07:21:05 GMT, Jie Fu wrote:
> Good suggestion!
> And the `jdk_vector_sanity` test group had been added.
In general, running a few fast sanity tests from several areas in tier1 seems a
good idea. Having test lists in the TEST.group files isn't very appealing as
they easily g
On Fri, 28 Oct 2022 13:41:28 GMT, Erik Joelsson wrote:
> I think you need to add at least one other label than `build` to this now to
> make sure the right people can have a say in the change.
Done.
Thanks @erikj79 .
-
PR: https://git.openjdk.org/jdk/pull/10879
On Fri, 28 Oct 2022 07:19:31 GMT, Jie Fu wrote:
>> Hi all,
>>
>> As discussed here
>> https://github.com/openjdk/jdk/pull/10807#pullrequestreview-1150314487 , it
>> would be better to add the vector api tests in GHA.
>>
>> Thanks.
>> Best regards,
>> Jie
>
> Jie Fu has updated the pull reques
On Thu, 27 Oct 2022 17:01:12 GMT, Vladimir Kozlov wrote:
> I think we can meet all requests by adding `jdk_vector_sanity` subset of
> vector tests similar to existing `jdk_svc_sanity`. The motivation for that is
> to catch obvious bugs in vector code generation on 32-bit platforms and
> aarch6
> Hi all,
>
> As discussed here
> https://github.com/openjdk/jdk/pull/10807#pullrequestreview-1150314487 , it
> would be better to add the vector api tests in GHA.
>
> Thanks.
> Best regards,
> Jie
Jie Fu has updated the pull request with a new target base due to a merge or a
rebase. The incr
On Thu, 27 Oct 2022 03:53:13 GMT, Jie Fu wrote:
> Hi all,
>
> As discussed here
> https://github.com/openjdk/jdk/pull/10807#pullrequestreview-1150314487 , it
> would be better to add the vector api tests in GHA.
>
> Thanks.
> Best regards,
> Jie
I think we can meet all requests by adding `jd
On Thu, 27 Oct 2022 13:57:47 GMT, Erik Joelsson wrote:
> The default set of tests included in GHA is currently defined to be exactly
> tier1. That is the set of tests that we have collectively agreed on
> represents a reasonably sized set that gives the best coverage for the time
> spent (at l
On Thu, 27 Oct 2022 03:53:13 GMT, Jie Fu wrote:
> Hi all,
>
> As discussed here
> https://github.com/openjdk/jdk/pull/10807#pullrequestreview-1150314487 , it
> would be better to add the vector api tests in GHA.
>
> Thanks.
> Best regards,
> Jie
The default set of tests included in GHA is cu
On Thu, 27 Oct 2022 07:24:45 GMT, Sergey Bylokhov wrote:
> Probably it will be possible to select an additional tests dynamically based
> on changed module? Using the same logic as the labels in the PR?
Thanks @mrserb for your suggestion.
Dynamical testing configuration would increase the GHA
On Thu, 27 Oct 2022 03:53:13 GMT, Jie Fu wrote:
> Hi all,
>
> As discussed here
> https://github.com/openjdk/jdk/pull/10807#pullrequestreview-1150314487 , it
> would be better to add the vector api tests in GHA.
>
> Thanks.
> Best regards,
> Jie
Probably it will be possible to select an addi
On Thu, 27 Oct 2022 06:13:05 GMT, Aleksey Shipilev wrote:
> Sorry, but I don't think this is a good idea. If there are tests that are
> important for pre-integration testing, they should just be in `tier1`.
Since vector api is still in incubation, I'm not sure if it's OK to go into
tier1.
I'm
On Thu, 27 Oct 2022 03:53:13 GMT, Jie Fu wrote:
> Hi all,
>
> As discussed here
> https://github.com/openjdk/jdk/pull/10807#pullrequestreview-1150314487 , it
> would be better to add the vector api tests in GHA.
>
> Thanks.
> Best regards,
> Jie
Sorry, but I don't think this is a good idea.
Hi all,
As discussed here
https://github.com/openjdk/jdk/pull/10807#pullrequestreview-1150314487 , it
would be better to add the vector api tests in GHA.
Thanks.
Best regards,
Jie
-
Commit messages:
- 8295970: Add jdk_vector tests in GHA
Changes: https://git.openjdk.org/jdk/pull
16 matches
Mail list logo