On Tue, 27 Feb 2024 22:04:47 GMT, Erik Joelsson wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Only show runtime image suffix for JDK modules
>
> make/autoconf/jdk-options.m4 line 596:
>
>> 594:
>>
On Tue, 12 Mar 2024 14:07:32 GMT, Magnus Ihse Bursie wrote:
>> I don't see a race. The `rm` was there in the original code and is no
>> scarier in the modified version. The jdk image is constructed by a
>> combination of targets and recipes. The first one to run has to be jlink,
>> then we
On Tue, 27 Feb 2024 22:06:12 GMT, Erik Joelsson wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Only show runtime image suffix for JDK modules
>
> make/autoconf/spec.gmk.template line 904:
>
>> 902:
On Fri, 8 Mar 2024 17:25:18 GMT, Severin Gehwolf wrote:
>> make/Images.gmk line 96:
>>
>>> 94:
>>> 95: ifeq ($(JLINK_KEEP_PACKAGED_MODULES), true)
>>> 96: ifeq ($(JLINK_PRODUCE_RUNTIME_LINK_JDK), true)
>>
>> I don't get it. Why don't you use the JDK_LINK_OUTPUT_DIR from just above?
>
>
On Tue, 27 Feb 2024 15:23:09 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Mon, 11 Mar 2024 13:06:55 GMT, Erik Joelsson wrote:
>> Why the rm? Because jlink refuses to run if the output dir already exists.
>
> I don't see a race. The `rm` was there in the original code and is no scarier
> in the modified version. The jdk image is constructed by a combination of
>
On Mon, 11 Mar 2024 13:24:54 GMT, Erik Joelsson wrote:
> Based on that I agree with the choice of using a configure argument.
Thanks. The intention is that without the extra configure argument you'd get
`jdk-image` as is today. Not modified. *With* `--enable-runtime-link-image` the
result of
On Tue, 27 Feb 2024 15:23:09 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Fri, 8 Mar 2024 17:36:33 GMT, Severin Gehwolf wrote:
>> That was modelled similar to `jdk_jlink` target. It also does the removal.
>> When building with `--enable-runtime-link-image`, the flow is:
>>
>>
>> 1. Link the initial jdk image (current `images/jdk`). Output is
>>
On Tue, 27 Feb 2024 15:23:09 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Fri, 8 Mar 2024 16: 51: 11 GMT, Magnus Ihse Bursie wrote: >> Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision: >> >> Only show runtime
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
On Fri, 8 Mar 2024 17: 35: 45 GMT, Severin Gehwolf wrote: >> make/Images. gmk line 144: >> >>> 142: OUTPUT_DIR := $(JDK_IMAGE_DIR), \ >>> 143: SUPPORT_DIR := $(JDK_RUN_TIME_IMAGE_SUPPORT_DIR),
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
On Fri, 8 Mar 2024 16:52:33 GMT, Magnus Ihse Bursie wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Only show runtime image suffix for JDK modules
>
> make/Images.gmk line 96:
>
>> 94:
>> 95: ifeq
On Tue, 27 Feb 2024 15:23:09 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Tue, 27 Feb 2024 15:23:09 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Wed, 6 Mar 2024 17:28:01 GMT, Magnus Ihse Bursie wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Only show runtime image suffix for JDK modules
>
> make/ToolsJdk.gmk line 88:
>
>> 86:
On Tue, 27 Feb 2024 15:23:09 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Tue, 27 Feb 2024 15:23:09 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
> Please review this patch which adds a jlink mode to the JDK which doesn't
> need the packaged modules being present. A.k.a run-time image based jlink.
> Fundamentally this patch adds an option to use `jlink` even though your JDK
> install might not come with the packaged modules (directory
19 matches
Mail list logo