On Tue, 9 Apr 2024 20:10:36 GMT, Mikael Vidstedt wrote:
>> Hamlin Li has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - disable unused-function warnings; add log msg
>> - minor
>
> Thank you for the update and for working on this in gene
On Tue, 9 Apr 2024 20:10:36 GMT, Mikael Vidstedt wrote:
>> Hamlin Li has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - disable unused-function warnings; add log msg
>> - minor
>
> Thank you for the update and for working on this in gene
On Fri, 5 Apr 2024 12:17:17 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch?
>> This pr is based on previous work and discussion in [pr
>> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
>> 18294](https://github.com/openjdk/jdk/pull/18294).
>>
>> Compared with previous
On Fri, 5 Apr 2024 12:17:17 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch?
>> This pr is based on previous work and discussion in [pr
>> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
>> 18294](https://github.com/openjdk/jdk/pull/18294).
>>
>> Compared with previous
On Wed, 10 Apr 2024 09:24:09 GMT, Hamlin Li wrote:
> > Thank you for the update and for working on this in general.
> > I've started working on JDK-8329816, preparing the change for the SLEEF
> > specific part of the change. Specifically, I'm currently planning on
> > including the three SLEEF
On Wed, 10 Apr 2024 09:24:09 GMT, Hamlin Li wrote:
> With that in mind, it looks like we could potentially use SLEEF for other
> architectures on linux in the future? And potentially additional operating
> systems as well?
Hi Mikael(@vidmik ) ! :)
Thanks for looking into the legal stuff!
We a
On Tue, 9 Apr 2024 20:10:36 GMT, Mikael Vidstedt wrote:
> Thank you for the update and for working on this in general.
>
> I've started working on JDK-8329816, preparing the change for the SLEEF
> specific part of the change. Specifically, I'm currently planning on
> including the three SLEEF
On Fri, 5 Apr 2024 12:17:17 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch?
>> This pr is based on previous work and discussion in [pr
>> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
>> 18294](https://github.com/openjdk/jdk/pull/18294).
>>
>> Compared with previous
On Fri, 5 Apr 2024 12:17:17 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch?
>> This pr is based on previous work and discussion in [pr
>> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
>> 18294](https://github.com/openjdk/jdk/pull/18294).
>>
>> Compared with previous
On Thu, 4 Apr 2024 21:55:54 GMT, Mikael Vidstedt wrote:
>> Hamlin Li has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - disable unused-function warnings; add log msg
>> - minor
>
> make/modules/jdk.incubator.vector/Lib.gmk line 44:
>
>>
> Hi,
> Can you help to review the patch?
> This pr is based on previous work and discussion in [pr
> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
> 18294](https://github.com/openjdk/jdk/pull/18294).
>
> Compared with previous prs, the major change in this pr is to integrate the
> sou
On Fri, 15 Mar 2024 11:25:37 GMT, Hamlin Li wrote:
> > * There is no way to stop the VM from trying to load vmath ?
>
> No official way, but deleting libvmath.so will have a same effect. I'm not
> sure if avoiding loading vmath is necessary for typical users, if it turns
> out to be true, we c
On Fri, 15 Mar 2024 11:35:05 GMT, Hamlin Li wrote:
> > I'm running the tests, but I have no way to confirm that SLEEF or SVE is in
> > use. Exactly what did you do, and how did you confirm it?
>
> Thanks for running test. I just turn on some log, and check the output.
The problem I see is that
On Thu, 14 Mar 2024 15:29:51 GMT, Andrew Haley wrote:
> > Hi, thanks for continuing with this.
> > As this is similar to SVML, comments applies to x86 also:
> > ```
> > * There is no way to stop the VM from trying to load vmath ?
> > There is both a UseNeon and a UseSVE, if I set both to false
On Thu, 14 Mar 2024 15:25:54 GMT, Andrew Haley wrote:
> > ```
> > * at build time
> >
> > * with/without sleef
> > * with/without sve support
> > ```
>
> What is the relevance of SVE support at build time? Should it matter what the
> build machine is?
>
> Its important to realize that a
On Thu, 14 Mar 2024 12:23:17 GMT, Magnus Ihse Bursie wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix variable name in github workflow
>
> src/jdk.incubator.vector/linux/native/libvmath/vect_math.h line 1:
>
>> 1:
On Thu, 14 Mar 2024 15:29:51 GMT, Andrew Haley wrote:
> Hi, thanks for continuing with this.
Thanks for the comments
> As this is similar to SVML, comments applies to x86 also:
>
> * There is no way to stop the VM from trying to load vmath ?
No official way, but deleting libvmath.so will have
On Thu, 14 Mar 2024 09:14:04 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> Thanks
>>
>> This is a continuation of work based on [1] by @XiaohongGong, most work was
>> done in that pr. In this new pr, just rebased the code in [1], then added
>> some minor changes (renami
On Thu, 14 Mar 2024 11:20:26 GMT, Robbin Ehn wrote:
> Hi, thanks for continuing with this.
>
> As this is similar to SVML, comments applies to x86 also:
>
> * There is no way to stop the VM from trying to load vmath ?
> There is both a UseNeon and a UseSVE, if I set both to false I wo
On Thu, 14 Mar 2024 09:14:04 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> Thanks
>>
>> This is a continuation of work based on [1] by @XiaohongGong, most work was
>> done in that pr. In this new pr, just rebased the code in [1], then added
>> some minor changes (renami
On Thu, 14 Mar 2024 09:14:04 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> Thanks
>>
>> This is a continuation of work based on [1] by @XiaohongGong, most work was
>> done in that pr. In this new pr, just rebased the code in [1], then added
>> some minor changes (renami
On Thu, 14 Mar 2024 09:14:04 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> Thanks
>>
>> This is a continuation of work based on [1] by @XiaohongGong, most work was
>> done in that pr. In this new pr, just rebased the code in [1], then added
>> some minor changes (renami
On Thu, 14 Mar 2024 09:14:04 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> Thanks
>>
>> This is a continuation of work based on [1] by @XiaohongGong, most work was
>> done in that pr. In this new pr, just rebased the code in [1], then added
>> some minor changes (renami
On Thu, 14 Mar 2024 08:59:09 GMT, Ludovic Henry wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix variable name in github workflow
>
> .github/workflows/build-cross-compile.yml line 138:
>
>> 136: --arch=
> Hi,
> Can you help to review this patch?
> Thanks
>
> This is a continuation of work based on [1] by @XiaohongGong, most work was
> done in that pr. In this new pr, just rebased the code in [1], then added
> some minor changes (renaming of calling method, add libsleef as extra lib in
> CI cro
25 matches
Mail list logo
