On Mon, 11 Dec 2023 13:47:26 GMT, Magnus Ihse Bursie wrote:
>> The need to use whitebox-testing (wb.jar) from JMH microbenchmarks has
>> recently arisen.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Revert change
> The need to use whitebox-testing (wb.jar) from JMH microbenchmarks has
> recently arisen.
Magnus Ihse Bursie has updated the pull request incrementally with one
additional commit since the last revision:
Revert change in RunTests
-
Changes:
- all: https://git.openjdk.org/jdk
On Fri, 8 Dec 2023 16:12:27 GMT, Magnus Ihse Bursie wrote:
>> The need to use whitebox-testing (wb.jar) from JMH microbenchmarks has
>> recently arisen.
>
> make/RunTests.gmk line 598:
>
>> 596: endif
>> 597:
>> 598: # Set paths for dependencies
>
> @cl4es So basically this is the line yo
On Wed, 6 Dec 2023 15:32:14 GMT, Magnus Ihse Bursie wrote:
> The need to use whitebox-testing (wb.jar) from JMH microbenchmarks has
> recently arisen.
Alternatively, I could also unpack wb.jar alongside `$(JMH_CORE_JAR)
$(JMH_COMMONS_MATH_JAR) $(JMH_JOPT_SIMPLE_JAR)`, and re-pack it into
`ben
On Wed, 6 Dec 2023 15:32:14 GMT, Magnus Ihse Bursie wrote:
> The need to use whitebox-testing (wb.jar) from JMH microbenchmarks has
> recently arisen.
make/RunTests.gmk line 598:
> 596: endif
> 597:
> 598: # Set paths for dependencies
@cl4es So basically this is the line you're objecting
On Wed, 6 Dec 2023 15:32:14 GMT, Magnus Ihse Bursie wrote:
> The need to use whitebox-testing (wb.jar) from JMH microbenchmarks has
> recently arisen.
Adding wb.jar to the test image is great. Maybe that could be done separately?
I think we need a different solution here that does not pollute
On Wed, 6 Dec 2023 15:32:14 GMT, Magnus Ihse Bursie wrote:
> The need to use whitebox-testing (wb.jar) from JMH microbenchmarks has
> recently arisen.
Marked as reviewed by erikj (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16996#pullrequestreview-1772448490
The need to use whitebox-testing (wb.jar) from JMH microbenchmarks has recently
arisen.
-
Commit messages:
- 8316657: Support whitebox testing in microbenchmarks
Changes: https://git.openjdk.org/jdk/pull/16996/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16996&range=00
