Re: RFR: JDK-8298908: Instrument Metaspace for ASan [v6]

2023-01-09 Thread Justin King
On Mon, 9 Jan 2023 08:08:28 GMT, Thomas Stuefe wrote: > Metaspace changes mostly good. Do the gtests pass? Especially the Metaspace > fence tests? You need to execute them via the jtreg wrapper > (test/hotspot/jtreg/gtest) - these wrappers execute the googletest suite with > a number of

Re: RFR: JDK-8298908: Instrument Metaspace for ASan [v6]

2023-01-09 Thread Justin King
On Mon, 9 Jan 2023 07:39:03 GMT, Thomas Stuefe wrote: >> Justin King has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use -fno-common as suggested by ASan docs >> >> Signed-off-by: Justin King > >

Re: RFR: JDK-8298908: Instrument Metaspace for ASan [v6]

2023-01-09 Thread Thomas Stuefe
On Thu, 5 Jan 2023 16:29:13 GMT, Justin King wrote: >> This change instruments Metaspace for ASan. Metaspace allocates memory using >> `mmap`/`munmap` which ASan is not aware of. Fortunately ASan supports >> applications [manually poisoning/unpoisoning >>

Re: RFR: JDK-8298908: Instrument Metaspace for ASan [v6]

2023-01-05 Thread Justin King
On Thu, 5 Jan 2023 16:29:13 GMT, Justin King wrote: >> This change instruments Metaspace for ASan. Metaspace allocates memory using >> `mmap`/`munmap` which ASan is not aware of. Fortunately ASan supports >> applications [manually poisoning/unpoisoning >>

Re: RFR: JDK-8298908: Instrument Metaspace for ASan [v6]

2023-01-05 Thread Justin King
> This change instruments Metaspace for ASan. Metaspace allocates memory using > `mmap`/`munmap` which ASan is not aware of. Fortunately ASan supports > applications [manually poisoning/unpoisoning > memory](https://github.com/google/sanitizers/wiki/AddressSanitizerManualPoisoning). > ASan is