Re: RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic [v7]

2022-10-18 Thread Florian Weimer
On Wed, 12 Oct 2022 17:00:15 GMT, Andrew Haley wrote: >> A bug in GCC causes shared libraries linked with -ffast-math to disable >> denormal arithmetic. This breaks Java's floating-point semantics. >> >> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522 >> >> One solution is to sav

Re: RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic [v7]

2022-10-18 Thread Andrew Haley
On Tue, 18 Oct 2022 07:43:13 GMT, Florian Weimer wrote: >> Andrew Haley has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic > > src/hotspot/os/linux/os_linux.cpp lin

Integrated: 8294594: Fix cast-function-type warnings in signal handling code

2022-10-18 Thread Aleksey Shipilev
On Thu, 29 Sep 2022 16:12:11 GMT, Aleksey Shipilev wrote: > After [JDK-8294314](https://bugs.openjdk.org/browse/JDK-8294314), we would > have signals_posix.cpp excluded with cast-function-type warning: This pull request has now been integrated. Changeset: b06f1b14 Author:Aleksey Shipilev

Re: RFR: 8293422: DWARF emitted by Clang cannot be parsed [v4]

2022-10-18 Thread Christian Hagedorn
On Tue, 11 Oct 2022 08:18:08 GMT, Christian Hagedorn wrote: >> The DWARF debugging symbols emitted by Clang is different from what GCC is >> emitting. While GCC produces a complete `.debug_aranges` section (which is >> required in the DWARF parser), Clang does not. As a result, the DWARF parse

Re: RFR: 8295435: Build failure with GCC7 after JDK-8294314 due to strict-overflow warnings

2022-10-18 Thread Aleksey Shipilev
On Tue, 18 Oct 2022 02:35:59 GMT, Jie Fu wrote: > Hi all, > > Let's disable `-Werror=strict-overflow` to get it build with gcc7 on > Linux/x86. > > bytecodeAssembler.cpp > instanceKlass.cpp > klassVtable.cpp > > > Thanks. > Best regards, > Jie My CI reports the mainline failures with GCC 6

Re: RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic [v7]

2022-10-18 Thread Vladimir Ivanov
On Wed, 12 Oct 2022 17:00:15 GMT, Andrew Haley wrote: >> A bug in GCC causes shared libraries linked with -ffast-math to disable >> denormal arithmetic. This breaks Java's floating-point semantics. >> >> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522 >> >> One solution is to sav

Re: RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic [v7]

2022-10-18 Thread Vladimir Ivanov
On Wed, 12 Oct 2022 17:00:15 GMT, Andrew Haley wrote: >> A bug in GCC causes shared libraries linked with -ffast-math to disable >> denormal arithmetic. This breaks Java's floating-point semantics. >> >> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522 >> >> One solution is to sav

Re: RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic [v7]

2022-10-18 Thread Vladimir Ivanov
On Wed, 12 Oct 2022 17:00:15 GMT, Andrew Haley wrote: >> A bug in GCC causes shared libraries linked with -ffast-math to disable >> denormal arithmetic. This breaks Java's floating-point semantics. >> >> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522 >> >> One solution is to sav

RFR: 8294466: Minimize disabled warnings in java.desktop

2022-10-18 Thread Magnus Ihse Bursie
After JDK-8294281, it is now possible to disable warnings for individual files instead for whole libraries. I used this opportunity to go through all disabled warnings in java.desktop native libraries. Any warnings that were only triggered in a few files were removed from the library as a whole

Re: RFR: 8295435: Build failure with GCC7 after JDK-8294314 due to strict-overflow warnings [v2]

2022-10-18 Thread Jie Fu
> Hi all, > > Let's disable `-Werror=strict-overflow` to get it build with gcc7 on > Linux/x86. > > bytecodeAssembler.cpp > instanceKlass.cpp > klassVtable.cpp > > > Thanks. > Best regards, > Jie Jie Fu has updated the pull request incrementally with one additional commit since the last revi

Re: RFR: 8295435: Build failure with GCC7 after JDK-8294314 due to strict-overflow warnings [v2]

2022-10-18 Thread Jie Fu
On Tue, 18 Oct 2022 15:21:38 GMT, Aleksey Shipilev wrote: > Since the warning seems to be caused by the popular header, it is likely to > break some other platforms/files through the different include paths from the > different compilation units. The warning also looks fairly dubious, and > pr

Re: RFR: 8295435: Build failure with GCC7 after JDK-8294314 due to strict-overflow warnings [v2]

2022-10-18 Thread Aleksey Shipilev
On Wed, 19 Oct 2022 01:51:32 GMT, Jie Fu wrote: >> Hi all, >> >> Let's disable `-Werror=strict-overflow` to get it build with gcc7 on >> Linux/x86. >> >> bytecodeAssembler.cpp >> instanceKlass.cpp >> klassVtable.cpp >> >> >> Thanks. >> Best regards, >> Jie > > Jie Fu has updated the pull req