Re: RFR: 8295884: Implement IDE support for Eclipse [v37]

2023-03-05 Thread Julian Waters
> Eclipse is a popular and very well-known IDE in the world of Java > development, utilized widely in many contexts, by beginners and experienced > teams alike. Although a relatively lightweight IDE, it features surprisingly > powerful indexing and code analysis capabilities, as well as useful t

Re: RFR: 8302189: Mark assertion failures noreturn [v2]

2023-03-05 Thread Julian Waters
On Sat, 4 Mar 2023 11:16:03 GMT, Kim Barrett wrote: >> make/hotspot/lib/CompileJvm.gmk line 103: >> >>> 101: DISABLED_WARNINGS_xlc := tautological-compare shift-negative-value >>> 102: >>> 103: DISABLED_WARNINGS_microsoft := 4624 4244 4291 4146 4127 4722 >> >> It is annoying that we don't docu

Re: RFR: JDK-8302801: Remove fdlibm C sources [v4]

2023-03-05 Thread Joe Darcy
On Thu, 2 Mar 2023 18:27:09 GMT, Joe Darcy wrote: >> make/autoconf/buildjdk-spec.gmk.in line 85: >> >>> 83: JVM_LIBS := @OPENJDK_BUILD_JVM_LIBS@ >>> 84: >>> 85: FDLIBM_CFLAGS := @OPENJDK_BUILD_FDLIBM_CFLAGS@ >> >> If the hotspot build still needs `FDLIBM_CFLAGS`, then this line needs to >> st

build-test-lib target seems broken

2023-03-05 Thread Eirik Bjørsnøs
Hi, The 'build-test-lib' target seems to be broken: - make/test/BuildTestLib.gmk references the directory $(TEST_LIB_SOURCE_DIR)/sun which does not seem to exist. This can be fixed by removing the reference. - Some test-lib sources use preview-features which is not enabled by make/test/BuildTestL

Re: RFR: JDK-8302801: Remove fdlibm C sources [v4]

2023-03-05 Thread Alan Bateman
On Sun, 5 Mar 2023 06:19:06 GMT, Joe Darcy wrote: >> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I >> thought I'd get out for the review the next phase of the FDLIBM port: >> removing the FDLIBM C sources from the repo. >> >> A repo with the changes for JDK-83020

Re: RFR: JDK-8302801: Remove fdlibm C sources [v4]

2023-03-05 Thread David Holmes
On Sun, 5 Mar 2023 06:19:06 GMT, Joe Darcy wrote: >> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I >> thought I'd get out for the review the next phase of the FDLIBM port: >> removing the FDLIBM C sources from the repo. >> >> A repo with the changes for JDK-83020

Re: RFR: JDK-8302801: Remove fdlibm C sources [v4]

2023-03-05 Thread Vladimir Kozlov
On Sun, 5 Mar 2023 06:19:06 GMT, Joe Darcy wrote: >> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I >> thought I'd get out for the review the next phase of the FDLIBM port: >> removing the FDLIBM C sources from the repo. >> >> A repo with the changes for JDK-83020