Re: RFR: 8341735: Rewrite the build/AbsPathsInImage.java test to not load the entire file at once [v2]

2025-07-08 Thread Mikael Vidstedt
On Tue, 8 Jul 2025 20:55:17 GMT, Daniel Hu wrote: >> These changes should prevent entire binary files from being loaded into >> memory for build/AbsPathsInImage.java test. I chose a default buffer size of >> 8KB since BufferedInputStream uses that, but open to alternative solutions. >> GHA pas

Re: RFR: 8341735: Rewrite the build/AbsPathsInImage.java test to not load the entire file at once [v2]

2025-07-08 Thread Daniel Hu
> These changes should prevent entire binary files from being loaded into > memory for build/AbsPathsInImage.java test. I chose a default buffer size of > 8KB since BufferedInputStream uses that, but open to alternative solutions. > GHA passes and test passes on linux x64. Daniel Hu has updated

Re: RFR: 8361478: GHA: Use MSYS2 from GHA runners

2025-07-08 Thread Julian Waters
On Mon, 7 Jul 2025 09:24:20 GMT, Aleksey Shipilev wrote: > Installing MSYS2 takes considerable time in our Windows workflows. > Fortunately, GHA runners currently ship with MSYS2 bundled! The docs for > setup-msys2 step say it is enough to say `release: false` to use those: > https://github.co

Re: RFR: 8361478: GHA: Use MSYS2 from GHA runners

2025-07-08 Thread Aleksey Shipilev
On Tue, 8 Jul 2025 11:35:26 GMT, Julian Waters wrote: > I recall there were some issues with using MSYS2 that comes with Actions. > That was a long time ago though, are they no longer a problem with current > Actions and MSYS2 versions? We used to have a problem building jtreg, so we pinned an