RE: JDK-8080990: libdt_socket/socket_md.c(202) : warning C4996: 'gethostbyname': Use getaddrinfo() or GetAddrInfoW()

2018-02-02 Thread Langer, Christoph
Hi Gary, > Here's a revised webrev > >http://cr.openjdk.java.net/~gadams/8080990/webrev.01/index.html > > Still testing ... > > Using shutdown() fixed problems reported by the > java/nio/channelSocketChannel tests. The fix looks good. I would think we should rename dbgsysInetAddr to dbgsysP

Re: Contribute towards native code which override to OpenJDK

2018-02-02 Thread Archana Nogriya
Hi Erik, Sorry for delay, I took sometime to investigate what you had mentioned earlier and verified the build for native code overriding without having our fix with all possible scenarios. And I can confirm that it is working as you mentioned. Which means, this fix must have done after we mad

RFR: 8195795: Organize javadoc output files by module/package, not just package

2018-02-02 Thread Jonathan Gibbons
Please review changes, including a couple of small build changes, to reorganize the generated documentation into per-module directories. Build folk: the changes are just to move the generated module graph images into the new hierarchy. Javadoc folk: the changes are mostly simple, with most of

Re: RFR: 8195795: Organize javadoc output files by module/package, not just package

2018-02-02 Thread Erik Joelsson
Build change looks good to me. /Erik On 2018-02-02 13:42, Jonathan Gibbons wrote: Please review changes, including a couple of small build changes, to reorganize the generated documentation into per-module directories. Build folk: the changes are just to move the generated module graph imag

Re: RFR: 8195795: Organize javadoc output files by module/package, not just package

2018-02-02 Thread mandy chung
$MODULE-graph.png to $MODULE/module-graph.png change looks fine. Mandy On 2/2/18 1:42 PM, Jonathan Gibbons wrote: Please review changes, including a couple of small build changes, to reorganize the generated documentation into per-module directories. Build folk: the changes are just to move t