Re: RFR: JDK-8196998: Create devkit for Linux with gcc 7.3

Good point, I will look into it. /Erik On 2018-02-08 02:37, Magnus Ihse Bursie wrote: Erik, Is it possible that you could address https://bugs.openjdk.java.net/browse/JDK-8193016 at this time as well? Apart from that, it looks good to me. /Magnus 8 feb. 2018 kl. 02:49 skrev Tim Bell

Re: RFR [xxs, aix]: JDK-8196488: [aix] TOC overflow for libjvm.so in fastdebug build

Looks good, happy pushing without a sponsor! /Erik On 2018-02-08 06:42, Thomas Stüfe wrote: Hi, may I please have reviews for this tiny fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8196488 webrev:

RFR: JDK-8196356: Changes to m4 files don't trigger autoconf execution at build time

The check for when to generate the generated configure script is not working quite as expected. It currently only compares timestamps if the local repository has any local changes in the make/autoconf directory. This used to make sense when we had a committed generated script, but now we

Re: RFR [xxs, aix]: JDK-8196488: [aix] TOC overflow for libjvm.so in fastdebug build

Hi Eric, On Thu, Feb 8, 2018 at 6:09 PM, Erik Joelsson wrote: > Looks good, happy pushing without a sponsor! > > /Erik > > Yes please, that would be nice! ..Thomas > > > On 2018-02-08 06:42, Thomas Stüfe wrote: > >> Hi, >> >> may I please have reviews for this tiny

Re: RFR: JDK-8196356: Changes to m4 files don't trigger autoconf execution at build time

Erik: The check for when to generate the generated configure script is not working quite as expected. It currently only compares timestamps if the local repository has any local changes in the make/autoconf directory. This used to make sense when we had a committed generated script, but now we

Re: RFR: JDK-8196998: Create devkit for Linux with gcc 7.3

Thanks, updated in place. /Erik On 2018-02-08 11:55, Tim Bell wrote: Erik: make/devkit/Tools.gmk line 553: one typo - 'too the' should be 'to the' Looks good otherwise. Tim On 02/08/18 11:42, Erik Joelsson wrote: Here is a new webrev with dtrace included. I have verified that it builds

Re: RFR: JDK-8196998: Create devkit for Linux with gcc 7.3

Here is a new webrev with dtrace included. I have verified that it builds open linux-x64 successfully with dtrace enabled both on my Ubuntu without any dtrace installed as well as in mach5. http://cr.openjdk.java.net/~erikj/8196998/webrev.02/ /Erik On 2018-02-08 02:37, Magnus Ihse Bursie

Re: RFR: JDK-8196998: Create devkit for Linux with gcc 7.3

Erik: make/devkit/Tools.gmk line 553: one typo - 'too the' should be 'to the' Looks good otherwise. Tim On 02/08/18 11:42, Erik Joelsson wrote: Here is a new webrev with dtrace included. I have verified that it builds open linux-x64 successfully with dtrace enabled both on my Ubuntu without

Re: RFR: JDK-8196998: Create devkit for Linux with gcc 7.3

Looks good to me. /Magnus > 8 feb. 2018 kl. 20:59 skrev Erik Joelsson : > > Thanks, updated in place. > > /Erik > > >> On 2018-02-08 11:55, Tim Bell wrote: >> Erik: >> >> make/devkit/Tools.gmk >> >> line 553: one typo - 'too the' should be 'to the' >> >> Looks

Re: RFR 8190378: Java EE and CORBA modules removal

On 07/02/2018 16:57, Lance Andersen wrote: Hi all, I think we are at a point where we are ready to start reviewing the changes to remove the Java EE and CORBA modules as JEP 320, JDK-8189188, has been targeted to JDK 11. The CSR for removing the modules has been approved:

Re: RFR: JDK-8196998: Create devkit for Linux with gcc 7.3

Erik, Is it possible that you could address https://bugs.openjdk.java.net/browse/JDK-8193016 at this time as well? Apart from that, it looks good to me. /Magnus > 8 feb. 2018 kl. 02:49 skrev Tim Bell : > > Erik: > >> For oracle internal builds, we need to construct a

Re: RFR [xxs, aix]: JDK-8196488: [aix] TOC overflow for libjvm.so in fastdebug build

Thanks! On Thu, Feb 8, 2018 at 3:49 PM, Lindenmaier, Goetz < goetz.lindenma...@sap.com> wrote: > HI Thomas, > > looks good, thanks! > > Best regards, > Goetz. > > > -Original Message- > > From: ppc-aix-port-dev [mailto:ppc-aix-port-dev- > > boun...@openjdk.java.net] On Behalf Of Thomas

Re: RFR [xxs, aix]: JDK-8196488: [aix] TOC overflow for libjvm.so in fastdebug build

Thanks Matthias! On Thu, Feb 8, 2018 at 3:58 PM, Baesken, Matthias wrote: > Hi Thomas , looks good to me( not a Reviever however). > > > > Best Regards, Matthias > > > > *From:* ppc-aix-port-dev [mailto:ppc-aix-port-dev-boun...@openjdk.java.net] > *On Behalf Of

Re: [PATCH] (Title Corrected) Build fails to compile jchuff.c using gcc 4.8.5 on zLinux

On 2018-01-17 15:07, Adam Farley8 wrote: If this is the consensus, then perhaps we should consider setting --disable-warnings-as-errors by default (in the code), rather than depending on the user using an option which is not part of the formal build instructions. I'm not sure why. Because the

Re: RFR 8190378: Java EE and CORBA modules removal

> On Feb 8, 2018, at 3:04 AM, Alan Bateman wrote: > > On 07/02/2018 16:57, Lance Andersen wrote: >> Hi all, >> >> I think we are at a point where we are ready to start reviewing the changes >> to remove the Java EE and CORBA modules as JEP 320, JDK-8189188, has been

Re: RFR: JDK-8196985: Disable new warnings from GCC 7.3 in jdk libraries

Looks good to me. /Magnus > 7 feb. 2018 kl. 23:33 skrev Erik Joelsson : > > When building the jdk with GCC 7.3, a bunch of new warnings are triggered. > These include: > > * implicit-fallthrough > * shift-negative-value > * misleading-indentation > *

RFR [xxs, aix]: JDK-8196488: [aix] TOC overflow for libjvm.so in fastdebug build

Hi, may I please have reviews for this tiny fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8196488 webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8196488-aix-toc-overflow-in-fastdebug/webrev.00/webrev/ Thanks and Kind Regards, Thomas

RE: RFR [xxs, aix]: JDK-8196488: [aix] TOC overflow for libjvm.so in fastdebug build

HI Thomas, looks good, thanks! Best regards, Goetz. > -Original Message- > From: ppc-aix-port-dev [mailto:ppc-aix-port-dev- > boun...@openjdk.java.net] On Behalf Of Thomas Stüfe > Sent: Donnerstag, 8. Februar 2018 15:42 > To: ppc-aix-port-...@openjdk.java.net; build-dev

RE: RFR [xxs, aix]: JDK-8196488: [aix] TOC overflow for libjvm.so in fastdebug build

Hi Thomas , looks good to me( not a Reviever however). Best Regards, Matthias From: ppc-aix-port-dev [mailto:ppc-aix-port-dev-boun...@openjdk.java.net] On Behalf Of Thomas Stüfe Sent: Donnerstag, 8. Februar 2018 15:42 To: ppc-aix-port-...@openjdk.java.net; build-dev