Re: RFR(XS): 8201584: Fix configure on SLES 11 after 8201483

2018-04-16 Thread Magnus Ihse Bursie
On 2018-04-16 11:16, Lindenmaier, Goetz wrote: Hi, could I please get reviewes for this tiny fix? Grep does not grok the syntax of the replacement of space to newline. It causes configure failures on SLES 11. http://cr.openjdk.java.net/~goetz/wr18/8201584-fixSLES11configure/01/ Aha, that was

Re: [11] RFR for JDK-8199627: Use "Per-Monitor V2" High DPI awareness for Windows 10 v1703

2018-04-16 Thread Alexey Ivanov
Hi Magnus, I haven't found a way to suppress this warning. I tried. There's no way to suppress warnings from mt.exe [1] unfortunately. We're using Visual Studio 2013 to build JDK, the element was added in 2016. Newer versions of Windows SDK should recognise the element. Yes, it works as

Re: RFR: JDK-8201591 JVM features with "-" in name is not correctly handled

2018-04-16 Thread Erik Joelsson
Looks good. /Erik On 2018-04-16 05:07, Magnus Ihse Bursie wrote: JDK-8201483 caused a regression for enabling JVM features with a dash in the name. Bug: https://bugs.openjdk.java.net/browse/JDK-8201591 Patch inline: diff --git a/make/autoconf/hotspot.m4 b/make/autoconf/hotspot.m4 ---

Re: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

2018-04-16 Thread Magnus Ihse Bursie
On 2018-04-16 14:59, Alexey Ivanov wrote: Hi Matthias, Phil, The build of 32 bit Windows is broken because of mlib_image.dll. As JNICALL modifier has been added to function declarations, they're exported with a decorated name, for example _j2d_mlib_ImageCreate@16. The functions in this

RFR: JDK-8201591 JVM features with "-" in name is not correctly handled

2018-04-16 Thread Magnus Ihse Bursie
JDK-8201483 caused a regression for enabling JVM features with a dash in the name. Bug: https://bugs.openjdk.java.net/browse/JDK-8201591 Patch inline: diff --git a/make/autoconf/hotspot.m4 b/make/autoconf/hotspot.m4 --- a/make/autoconf/hotspot.m4 +++ b/make/autoconf/hotspot.m4 @@ -269,9 +269,9

Re: Fix for JDK-8201483 broken '-' containing features

2018-04-16 Thread Magnus Ihse Bursie
On 2018-04-13 17:23, Chris Dennis wrote: Hi All, It looks like the addition of support for disabling features has broken support for enabling features that contain a ‘-‘ in their name (amusingly this includes the 'all-gcs’ feature). Pretty sure this is the offending code is the use of

Re: RFR(XS): 8201584: Fix configure on SLES 11 after 8201483

2018-04-16 Thread Magnus Ihse Bursie
On 2018-04-16 14:15, Lindenmaier, Goetz wrote: Hi Magnus, yes, that works too: http://cr.openjdk.java.net/~goetz/wr18/8201584-fixSLES11configure/02/ Can I push this right away if I get a second review? You don't need a second review for build changes, it's a hotspot team rule. You can push it

Re: RFR(XS): 8201584: Fix configure on SLES 11 after 8201483

2018-04-16 Thread Volker Simonis
Looks good! Thanks for fixing, Volker On Mon, Apr 16, 2018 at 2:15 PM, Lindenmaier, Goetz wrote: > Hi Magnus, > > yes, that works too: > http://cr.openjdk.java.net/~goetz/wr18/8201584-fixSLES11configure/02/ > Can I push this right away if I get a second review? > >

Re: [OpenJDK 2D-Dev] RFR(xxxs): 8200052: libjavajpeg: Fix compile warning in jchuff.c

2018-04-16 Thread Adam Farley8
I also advocate the source code fix, as Make isn't meant to use the sort of logic required to properly analyse the toolchain version string. e.g. An "eq" match on 4.8.5 doesn't protect the user who is using 4.8.6, and Make doesn't seem to do substring stuff unless you mess around with shells.

Re: [11] Review Request: 8200146 Remove the appletviewer launcher

2018-04-16 Thread Philip Race
+1 -phil. On 3/30/18, 3:52 PM, Sergey Bylokhov wrote: Hello. Please review fix for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-8200146 Webrev can be found at: http://cr.openjdk.java.net/~serb/8200146/webrev.00 CSR: https://bugs.openjdk.java.net/browse/JDK-8200549 Fix description:

Re: [OpenJDK 2D-Dev] RFR(xxxs): 8200052: libjavajpeg: Fix compile warning in jchuff.c

2018-04-16 Thread Magnus Ihse Bursie
On 2018-04-16 12:58, Adam Farley8 wrote: I also advocate the source code fix, as Make isn't meant to use the sort of logic required to properly analyse the toolchain version string. e.g. An "eq" match on 4.8.5 doesn't protect the user who is using 4.8.6, and Make doesn't seem to do substring

RE: RFR(XS): 8201584: Fix configure on SLES 11 after 8201483

2018-04-16 Thread Lindenmaier, Goetz
Hi Magnus, yes, that works too: http://cr.openjdk.java.net/~goetz/wr18/8201584-fixSLES11configure/02/ Can I push this right away if I get a second review? Best regards, Goetz > -Original Message- > From: Magnus Ihse Bursie [mailto:magnus.ihse.bur...@oracle.com] > Sent: Montag, 16.

Re: [11] RFR for JDK-8199627: Use "Per-Monitor V2" High DPI awareness for Windows 10 v1703

2018-04-16 Thread Magnus Ihse Bursie
Hi Alexey, Since this patch, I'm getting lots of warnings on Windows: c:/cygwin64/home/magnusi/hg/sandbox/open/src/java.base/windows/native/launcher/java.manifest : manifest authoring warning 81010002: Unrecognized Element "dpiAwareness" in namespace

Re: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

2018-04-16 Thread Alexey Ivanov
Hi Matthias, Phil, The build of 32 bit Windows is broken because of mlib_image.dll. As JNICALL modifier has been added to function declarations, they're exported with a decorated name, for example _j2d_mlib_ImageCreate@16. The functions in this library are looked up by their name [1] and

RE: RFR(XS): 8201584: Fix configure on SLES 11 after 8201483

2018-04-16 Thread Lindenmaier, Goetz
Thanks Magnus and Volker! Best regards, Goetz. > -Original Message- > From: Magnus Ihse Bursie [mailto:magnus.ihse.bur...@oracle.com] > Sent: Montag, 16. April 2018 14:56 > To: Lindenmaier, Goetz ; build-dev (build- > d...@openjdk.java.net)

Re: 8201495: [Zero] Reduce limits of max heap size for boot JDK on s390

2018-04-16 Thread Andrew Haley
On 04/13/2018 02:40 PM, Severin Gehwolf wrote: > ++ /usr/bin/tee > /builddir/build/BUILD/java-9-openjdk-9.0.4.12-5.openjdk9.el7.s390/openjdk/build/jdk/modules/java.base/_the.java.base_batch.log > ++ /usr/bin/tee >

Re: 8201495: [Zero] Reduce limits of max heap size for boot JDK on s390

2018-04-16 Thread Magnus Ihse Bursie
On 2018-04-13 15:40, Severin Gehwolf wrote: Hi, We (Red Hat) have been building Zero on s390 for a while now. In order to do so we needed to have this patch to reduce the maximum heap size setting for big workloads. Otherwise we see this during (JDK 9) builds: ++ /usr/bin/tee

Re: 8201495: [Zero] Reduce limits of max heap size for boot JDK on s390

2018-04-16 Thread Severin Gehwolf
Hi Andrew, On Mon, 2018-04-16 at 09:47 +0100, Andrew Haley wrote: > On 04/13/2018 02:40 PM, Severin Gehwolf wrote: > > ++ /usr/bin/tee > > /builddir/build/BUILD/java-9-openjdk-9.0.4.12-5.openjdk9.el7.s390/openjdk/build/jdk/modules/java.base/_the.java.base_batch.log > > ++ /usr/bin/tee > >

RFR(XS): 8201584: Fix configure on SLES 11 after 8201483

2018-04-16 Thread Lindenmaier, Goetz
Hi, could I please get reviewes for this tiny fix? Grep does not grok the syntax of the replacement of space to newline. It causes configure failures on SLES 11. http://cr.openjdk.java.net/~goetz/wr18/8201584-fixSLES11configure/01/ Best regards, Goetz.

Re: 8201495: [Zero] Reduce limits of max heap size for boot JDK on s390

2018-04-16 Thread Severin Gehwolf
Hi Magnus, On Mon, 2018-04-16 at 10:58 +0200, Magnus Ihse Bursie wrote: > On 2018-04-13 15:40, Severin Gehwolf wrote: > > Hi, > > > > We (Red Hat) have been building Zero on s390 for a while now. In order > > to do so we needed to have this patch to reduce the maximum heap size > > setting for

Re: 8201495: [Zero] Reduce limits of max heap size for boot JDK on s390

2018-04-16 Thread Volker Simonis
On Mon, Apr 16, 2018 at 11:30 AM, Severin Gehwolf wrote: > Hi Andrew, > > On Mon, 2018-04-16 at 09:47 +0100, Andrew Haley wrote: >> On 04/13/2018 02:40 PM, Severin Gehwolf wrote: >> > ++ /usr/bin/tee >> >

Re: 8201495: [Zero] Reduce limits of max heap size for boot JDK on s390

2018-04-16 Thread Severin Gehwolf
On Mon, 2018-04-16 at 12:01 +0200, Volker Simonis wrote: > On Mon, Apr 16, 2018 at 11:30 AM, Severin Gehwolf wrote: > > Hi Andrew, > > > > On Mon, 2018-04-16 at 09:47 +0100, Andrew Haley wrote: > > > On 04/13/2018 02:40 PM, Severin Gehwolf wrote: > > > > ++ /usr/bin/tee > >