Re: RFR 8202683: Minimal VM should build cleanly on 64-bit platforms

2018-05-07 Thread David Holmes
On 7/05/2018 6:20 PM, Aleksey Shipilev wrote: On 05/06/2018 09:20 AM, David Holmes wrote: On 5/05/2018 9:26 PM, Aleksey Shipilev wrote: RFE:    https://bugs.openjdk.java.net/browse/JDK-8202683 Fix:    http://cr.openjdk.java.net/~shade/8202683/webrev.01/ Minimal VM is targeted to 32-bit

Re: License and Usage Terms of generated API documentation

2018-05-07 Thread mark . reinhold
2018/5/3 13:16:11 +0100, volker.simo...@gmail.com: > On Thu, May 3, 2018 at 12:21 PM, magnus.ihse.bur...@oracle.com wrote: >> ... >> >> Until a consensus of a better solution for hosting the generated >> documentation is reached, I'd like to avoid changing the build code. That >> will just open

Re: RFR 8202683: Minimal VM should build cleanly on 64-bit platforms

2018-05-07 Thread Aleksey Shipilev
On 05/06/2018 09:20 AM, David Holmes wrote: > On 5/05/2018 9:26 PM, Aleksey Shipilev wrote: >> RFE: >>    https://bugs.openjdk.java.net/browse/JDK-8202683 >> >> Fix: >>    http://cr.openjdk.java.net/~shade/8202683/webrev.01/ >> >> Minimal VM is targeted to 32-bit only, but hear me out. Recent

Re: RFR: 8179887 - Build failure with glibc >= 2.24: error: 'int readdir_r(DIR*, dirent*, dirent**)' is deprecated

2018-05-07 Thread B. Blaser
On 6 May 2018 at 18:35, B. Blaser wrote: > On 5 May 2018 at 22:26, Kim Barrett wrote: >>> On May 5, 2018, at 8:03 AM, B. Blaser wrote: >>> >>> On 4 May 2018 at 17:42, Alan Bateman wrote: On 04/05/2018

Re: RFR 8202683: Minimal VM should build cleanly on 64-bit platforms

2018-05-07 Thread Erik Joelsson
On 2018-05-07 08:40, Erik Joelsson wrote: Looks good to me. Note for future, I would like it even more if we got rid of the pre-defined jvm.cfg altogether and just always generated it. The build itself shouldn't be dictating artificial limitations on build parameters. If we want to enforce

Re: Windows: problem with msvxxx.dll locations containing spaces

2018-05-07 Thread Erik Joelsson
Yes, sure, I'm working on a different fix in the same area now anyway so can sneak this fix in there. Will get done this week. /Erik On 2018-05-07 07:37, Thomas Stüfe wrote: Hi Erik, since your proposal worked, will you do a fix? Thanks, Thomas On Fri, May 4, 2018 at 8:30 AM, Thomas Stüfe

Re: Windows: problem with msvxxx.dll locations containing spaces

2018-05-07 Thread Thomas Stüfe
Hi Erik, since your proposal worked, will you do a fix? Thanks, Thomas On Fri, May 4, 2018 at 8:30 AM, Thomas Stüfe wrote: > Hi Erik, > > that worked on both machines for all builds. > > Thanks, Thomas > > On Thu, May 3, 2018 at 10:13 PM, Erik Joelsson

Re: RFR 8202683: Minimal VM should build cleanly on 64-bit platforms

2018-05-07 Thread Erik Joelsson
Looks good to me. Note for future, I would like it even more if we got rid of the pre-defined jvm.cfg altogether and just always generated it. The build itself shouldn't be dictating artificial limitations on build parameters. If we want to enforce limitations those should be explicit

Re: RFR: 8179887 - Build failure with glibc >= 2.24: error: 'int readdir_r(DIR*, dirent*, dirent**)' is deprecated

2018-05-07 Thread B. Blaser
On 7 May 2018 at 14:19, B. Blaser wrote: > On 6 May 2018 at 18:35, B. Blaser wrote: >> On 5 May 2018 at 22:26, Kim Barrett wrote: On May 5, 2018, at 8:03 AM, B. Blaser wrote: On 4 May 2018 at 17:42,

Re: Windows: problem with msvxxx.dll locations containing spaces

2018-05-07 Thread Thomas Stüfe
Great, thanks! On Mon, May 7, 2018 at 5:41 PM, Erik Joelsson wrote: > Yes, sure, I'm working on a different fix in the same area now anyway so can > sneak this fix in there. Will get done this week. > > /Erik > > > > On 2018-05-07 07:37, Thomas Stüfe wrote: >> >> Hi

Re: RFR(L) : 8199370: [TESTBUG] Open source vm testbase GC tests

2018-05-07 Thread Erik Joelsson
Build change looks good. /Erik On 2018-05-07 15:35, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev/8199370/webrev.00/index.html 45710 lines changed: 45710 ins; 0 del; 0 mod; Hi all, could you please review the patch which open sources GC tests from vm testbase? it introduces

RFR(L) : 8199370: [TESTBUG] Open source vm testbase GC tests

2018-05-07 Thread Igor Ignatyev
http://cr.openjdk.java.net/~iignatyev/8199370/webrev.00/index.html > 45710 lines changed: 45710 ins; 0 del; 0 mod; Hi all, could you please review the patch which open sources GC tests from vm testbase? it introduces the following test groups: - vmTestbase_vm_g1classunloading -

RFR: JDK-8202557: OpenJDK fails to start in Windows 7 and 8.1 after upgrading compiler to VC 2017

2018-05-07 Thread Erik Joelsson
With the new VS2017 toolchain Microsoft has changed how the C++ libraries work. In addition to the old msvcr* and msvcp* dll files, we now have a big lot of UCRT dlls as well. These files are also redistributable but are found in the Windows Kit rather than the Visual Studio installation. On

Re: RFR 8202683: Minimal VM should build cleanly on 64-bit platforms

2018-05-07 Thread David Holmes
On 8/05/2018 1:40 AM, Erik Joelsson wrote: Looks good to me. Note for future, I would like it even more if we got rid of the pre-defined jvm.cfg altogether and just always generated it. The build That was supposed to be happening ... see (non-public sorry) JDK-8179985. Don't know what the