Re: [11] RFR (XS) 8207047: Multiple VM variants build fail

2018-07-12 Thread Severin Gehwolf
Adding build-dev as this is a build change. On Thu, 2018-07-12 at 12:12 +0300, Boris Ulasevich wrote: > Hi all, > > Please review a simple patch: > http://cr.openjdk.java.net/~bulasevich/8207047/webrev.00 > https://bugs.openjdk.java.net/browse/JDK-8207047 > > Collision happens on JFR gensrc

Re: [11] RFR (XS) 8207047: Multiple VM variants build fail

2018-07-12 Thread Erik Joelsson
Looks good. I thought I had fixed this, but now realize it was part of a change that is currently on hold and I never got around to extracting this particular fix as a separate fix. Thanks for fixing it! /Erik On 2018-07-12 02:32, Severin Gehwolf wrote: Adding build-dev as this is a

Re: [11] RFR (XXS): 8206903: Unable to build Client VM with JVMCI

2018-07-12 Thread Erik Joelsson
Sure I can push it for you. /Erik On 2018-07-12 03:59, Aleksei Voitylov wrote: Erik, Vladimir, thank you for review. Could either of you sponsor the change? -Aleksei On 11/07/2018 19:30, Vladimir Kozlov wrote: +1 Vladimir On 7/11/18 9:28 AM, Erik Joelsson wrote: Looks good. /Erik

Re: [11] RFR (XXS): 8206903: Unable to build Client VM with JVMCI

2018-07-12 Thread Aleksei Voitylov
Erik, Vladimir, thank you for review. Could either of you sponsor the change? -Aleksei On 11/07/2018 19:30, Vladimir Kozlov wrote: +1 Vladimir On 7/11/18 9:28 AM, Erik Joelsson wrote: Looks good. /Erik On 2018-07-11 08:38, Aleksei Voitylov wrote: Hi, I suggest to disable JVMCI in

RFR: 8207057: No debug info for assembler files

2018-07-12 Thread Severin Gehwolf
Hi, Could I please get a review of this build fix? The problem is that no debug info gets ever generated for assembler files in hotspot. The proposed fix is to generated debug info via CFLAGS_DEBUG_SYMBOLS if so requested. For example --with-native-debug-info=none no debug info is generated.

Re: RFR: 8207057: No debug info for assembler files

2018-07-12 Thread Erik Joelsson
Hello Severin, From looking at your jdk-submit job I can already say that it's not working on Solaris: jib > /bin/as: error: unknown option 'g0' jib > /bin/as: error: unknown option 'xs' jib > usage: /bin/as [-V] [-Q{y,n}] [-s] jib >[-S{a|b|c|l|A|B|C|L}] [-hwcap={1|0}] [-o objfile]