Re: RFR(XS): 8213515: Improve freetype detection on linux/ppc64/ppc64le/s390x

2018-11-08 Thread Aleksey Shipilev
On 11/08/2018 10:24 AM, Volker Simonis wrote: > can I please have a review for the following trivial enhancement of > the freetype detection on linux/ppc64/ppc64le/s390x: > > http://cr.openjdk.java.net/~simonis/webrevs/2018/8213515/ I think I saw something similar on aarch64 either Debian or

Re: RFR(XS): 8213515: Improve freetype detection on linux/ppc64/ppc64le/s390x

2018-11-08 Thread Volker Simonis
Thanks for the quick reviews! I've removed the comment as requested by Aleksey and pushed. Regards, Volker On Thu, Nov 8, 2018 at 11:54 AM Thomas Stüfe wrote: > > +1 > > Gruss Thomas > On Thu, Nov 8, 2018 at 10:25 AM Volker Simonis > wrote: > > > > Hi, > > > > can I please have a review for

bin/idea.sh and Cygwin

2018-11-08 Thread Baesken, Matthias
Hello, I tried to use bin/idea.sh with Cygwin to generate project files for IDEA IntelliJ Community . The project file generation seems to work and outputs the .idea - folder with lots of xml files in it . However , when opening the project from IDEA, it fails with a message :

Re: bin/idea.sh and Cygwin

2018-11-08 Thread Chris Hegarty
Matthias, On 08/11/18 11:45, Baesken, Matthias wrote: Hello, I tried to use bin/idea.sh with Cygwin to generate project files for IDEA IntelliJ Community . The project file generation seems to work and outputs the .idea - folder with lots of xml files in it . However , when

RE: bin/idea.sh and Cygwin

2018-11-08 Thread Baesken, Matthias
Hi Chris , thanks for the info . However I found out that replacing the /cygdrive/C/ with C:/ in the top-level xml/imlfiles in the ".idea" - folder makes IntelliJ happy, I could then open the project successfully from IntelliJ . So I guess a couple of

bash completion for make targets

2018-11-08 Thread Thomas Stüfe
Hi all, This may be a stupid question, and not that important, but bash completion for targets like "clean" and "images" stopped working for me. "reconfigure" still works thouugh. Did anything change? Best Regards, Thomas

Re: bash completion for make targets

2018-11-08 Thread Magnus Ihse Bursie
On 2018-11-08 12:10, Thomas Stüfe wrote: Hi all, This may be a stupid question, and not that important, but bash completion for targets like "clean" and "images" stopped working for me. "reconfigure" still works thouugh. Did anything change? Best Regards, Thomas Not intentionally. It can be

RFR(XS): 8213515: Improve freetype detection on linux/ppc64/ppc64le/s390x

2018-11-08 Thread Volker Simonis
Hi, can I please have a review for the following trivial enhancement of the freetype detection on linux/ppc64/ppc64le/s390x: http://cr.openjdk.java.net/~simonis/webrevs/2018/8213515/ https://bugs.openjdk.java.net/browse/JDK-8213515 On some more "exotic" Linux platforms, libfreetype.so is found

Re: bash completion for make targets

2018-11-08 Thread Thomas Stüfe
On Thu, Nov 8, 2018 at 12:13 PM Magnus Ihse Bursie wrote: > > On 2018-11-08 12:10, Thomas Stüfe wrote: > > > Hi all, > > > > This may be a stupid question, and not that important, but bash > > completion for targets like "clean" and "images" stopped working for > > me. "reconfigure" still works

Re: RFR(XS): 8213515: Improve freetype detection on linux/ppc64/ppc64le/s390x

2018-11-08 Thread Magnus Ihse Bursie
On 2018-11-08 10:24, Volker Simonis wrote: Hi, can I please have a review for the following trivial enhancement of the freetype detection on linux/ppc64/ppc64le/s390x: http://cr.openjdk.java.net/~simonis/webrevs/2018/8213515/ https://bugs.openjdk.java.net/browse/JDK-8213515 Looks good to me.

Re: RFR(XS): 8213515: Improve freetype detection on linux/ppc64/ppc64le/s390x

2018-11-08 Thread Thomas Stüfe
+1 Gruss Thomas On Thu, Nov 8, 2018 at 10:25 AM Volker Simonis wrote: > > Hi, > > can I please have a review for the following trivial enhancement of > the freetype detection on linux/ppc64/ppc64le/s390x: > > http://cr.openjdk.java.net/~simonis/webrevs/2018/8213515/ >

Re: RFR(M) 8213348: jdk.internal.vm.compiler.management service providers missing in module descriptor

2018-11-08 Thread Mandy Chung
This is strange.  upgrade module path precedes the application module path in the search path.  I would not expect --module-path would help. Can you get the full javac command to see what are being compiled and all the paths set in these options? Mandy On 11/8/18 11:28 AM, dean.l...@oracle.com

Re: is ccache working effectively?

2018-11-08 Thread Erik Joelsson
Hello, On 2018-11-08 10:58, Maurizio Cimadamore wrote: Hi, I've observed that the time spent in C/CPP compilation during a JDK build seems to have crept higher lately. By monitoring processes during the build I found an awful lot of c++ compilations taking place, which was surprising since

Re: RFR(M) 8213348: jdk.internal.vm.compiler.management service providers missing in module descriptor

2018-11-08 Thread dean . long
Thanks Erik. dl On 11/8/18 9:02 AM, Erik Joelsson wrote: Hello, The build changes look ok as long as Jon and Mandy are happy with how javac is invoked. /Erik On 2018-11-07 19:56, dean.l...@oracle.com wrote: https://bugs.openjdk.java.net/browse/JDK-8213348

Re: RFR(M) 8213348: jdk.internal.vm.compiler.management service providers missing in module descriptor

2018-11-08 Thread dean . long
I get this without --module-path:   Fatal Error: Unable to find package java.lang in classpath or bootclasspath I guess before, when it was using the unnamed module, that it was picking up these system classes from the jdk10 bootjdk, which doesn't seem ideal. It works without

Re: RFR(M) 8213348: jdk.internal.vm.compiler.management service providers missing in module descriptor

2018-11-08 Thread dean . long
Thanks Mandy. dl On 11/8/18 1:02 PM, Mandy Chung wrote: On 11/8/18 12:37 PM, dean.l...@oracle.com wrote: On 11/8/18 11:49 AM, Mandy Chung wrote: This is strange.  upgrade module path precedes the application module path in the search path.  I would not expect --module-path would help.

is ccache working effectively?

2018-11-08 Thread Maurizio Cimadamore
Hi, I've observed that the time spent in C/CPP compilation during a JDK build seems to have crept higher lately. By monitoring processes during the build I found an awful lot of c++ compilations taking place, which was surprising since I'm setup to use ccache. So I decided to run some more

Re: bin/idea.sh and Cygwin

2018-11-08 Thread Erik Joelsson
A patch fixing idea.sh so that it works on Windows would certainly be welcome. /Erik On 2018-11-08 05:12, Baesken, Matthias wrote: Hi Chris , thanks for the info . However I found out that replacing the /cygdrive/C/ with C:/ in the top-level xml/imlfiles in the

Re: RFR(M) 8213348: jdk.internal.vm.compiler.management service providers missing in module descriptor

2018-11-08 Thread Mandy Chung
On 11/8/18 12:37 PM, dean.l...@oracle.com wrote: On 11/8/18 11:49 AM, Mandy Chung wrote: This is strange.  upgrade module path precedes the application module path in the search path.  I would not expect --module-path would help. Sorry, the error is if I remove both --upgrade-module-path

Re: is ccache working effectively?

2018-11-08 Thread Erik Joelsson
You can try --disable-precompiled-headers and see if that helps. We have had special considerations for combining these features in the past, but it's certainly a source of trouble for ccache. /Erik On 2018-11-08 16:20, Maurizio Cimadamore wrote: On 08/11/2018 20:31, Erik Joelsson wrote: I

Re: is ccache working effectively?

2018-11-08 Thread Maurizio Cimadamore
On 08/11/2018 20:31, Erik Joelsson wrote: I think we need more details here to figure it out, but it doesn't surprise me that hotspot is the part that's failing. Building hotspot is way more complex than the rest. Digging more into the command lines of the various HS files, they include

Re: RFR(M) 8213348: jdk.internal.vm.compiler.management service providers missing in module descriptor

2018-11-08 Thread Erik Joelsson
Hello, The build changes look ok as long as Jon and Mandy are happy with how javac is invoked. /Erik On 2018-11-07 19:56, dean.l...@oracle.com wrote: https://bugs.openjdk.java.net/browse/JDK-8213348 https://bugs.openjdk.java.net/browse/JDK-8211781