Re: OpenJDK 11.0.2 cannot build on Solaris 11.4

2019-01-30 Thread Ao Qi
Hi Rob, If I recall it correctly, maybe configure with --disable-hotspot-gtest can solve your problem. Cheer, Ao Qi On Fri, Jan 18, 2019 at 5:57 AM Rob Petti wrote: > > Hey Folks, > > I've discovered that OpenJDK 11 cannot be built on Solaris 11.4. Normally > we would just try to rebuild our

Re: OpenJDK 11.0.2 cannot build on Solaris 11.4

2019-01-30 Thread Andrew Watkins
On 01/18/19 05:23 PM, Erik Joelsson wrote: . You could try the open/make/devkit/createSolarisDevkit12.4.sh script and see if that helps you build something that works better. That's what we use at Oracle. /Erik Is there any hope of getting OpenJDK 12 to build on the Free download

Re: RFR: JDK-8204564: Need better error output when GenerateLinkOptData fails

2019-01-30 Thread Magnus Ihse Bursie
On 2019-01-30 02:18, Erik Joelsson wrote: Hello, Some recent build failures reminded me of this issue and increased the need to fix it ASAP to be able to diagnose them. GenerateLinkOptData.gmk runs a java tool to generate data which is later used to optimize the JDK image with jlink. The

RFR : [XS] 8218046: use bundled freetype in the AIX build by default

2019-01-30 Thread Baesken, Matthias
Hello, please review this small change . It adjusts the freetype default on AIX to "bundled"(means : use the bundled freetype if not configured otherwise) . Currently only windows and macosx use the bundled freetype, the other platforms by default use the system freetype (see

Re: OpenJDK 11.0.2 cannot build on Solaris 11.4

2019-01-30 Thread Ao Qi
Hi Andrew Watkins, jdk12 can be built on Solaris 11.4 x86 solarisstudio12.4, but it needs a EM_486 patch, and configure with --disable-hotspot-gtest --with-jvm-features=-shenandoahgc,-dtrace Cheers, Ao Qi On Wed, Jan 30, 2019 at 5:10 PM Andrew Watkins wrote: > > > > On 01/18/19 05:23 PM, Erik

Re: Proposal: JDK-8217896: Make better use of LCPUs when building on AIX

2019-01-30 Thread Magnus Ihse Bursie
On 2019-01-29 18:05, Erik Joelsson wrote: Hello, I'm OK with this, but since I can't verify it at all, I would be more comfortable if one of the other AIX users would review this as well. I'm also a bit surprised by the "wc -l | awk '{print $1}" construct. The point of sending -l to wc is to

Re: OpenJDK 11.0.2 cannot build on Solaris 11.4

2019-01-30 Thread Andrew Watkins
Thanks worked like a dream! For reference to build on Solaris 11.4 # export PATH=/usr/local/openjdk/jdk11/bin:/opt/solarisstudio12.4/bin:/usr/bin:/usr/sbin:/usr/gnu/bin:/usr/sfw/bin # hg clone http://hg.openjdk.java.net/jdk/jdk12 # bash configureĀ  --prefix=/usr/local/openjdk/jdk12

Re: RFR : [XS] 8218046: use bundled freetype in the AIX build by default

2019-01-30 Thread Magnus Ihse Bursie
On 2019-01-30 11:08, Baesken, Matthias wrote: Hello, please review this small change . It adjusts the freetype default on AIX to "bundled"(means : use the bundled freetype if not configured otherwise) . Currently only windows and macosx use the bundled freetype, the other platforms

RFR: JDK-8218057 Add ppc64le and s390x profiles to jib-profiles.js

2019-01-30 Thread Magnus Ihse Bursie
With Volker's fix in JDK-8213698, creating devkits for cross-compiling on linux to various other platforms was made trivial. This patch uses this functionality to add new cross-compilation targets for ppc64le and s390x to jib-profiles.js As usual; this implies no commitment from Oracle to

Re: RFR: JDK-8204564: Need better error output when GenerateLinkOptData fails

2019-01-30 Thread Erik Joelsson
Hello, On 2019-01-30 01:51, Magnus Ihse Bursie wrote: On 2019-01-30 02:18, Erik Joelsson wrote: Hello, Some recent build failures reminded me of this issue and increased the need to fix it ASAP to be able to diagnose them. GenerateLinkOptData.gmk runs a java tool to generate data which is

Re: Proposal: JDK-8217896: Make better use of LCPUs when building on AIX

2019-01-30 Thread Magnus Ihse Bursie
On 2019-01-30 17:37, Andrew Leonard wrote: Thanks David, I just found the reference you mention, it is a little vague, but says maybe as you said. I've reworked and tested the following which seems better: NUM_CORES=`lparstat -m | grep -o "lcpu=[[0-9]]*" | cut -d "=" -f 2` I'll create a

Re: RFR JDK-8217761: Enhance run-test-prebuilt jib profile to support running tests with JCov

2019-01-30 Thread Magnus Ihse Bursie
On 2019-01-30 17:55, Alexandre (Shura) Iline wrote: On Jan 30, 2019, at 8:53 AM, Erik Joelsson wrote: On 2019-01-30 06:48, Magnus Ihse Bursie wrote: On 2019-01-29 17:55, Erik Joelsson wrote: Hello, On 2019-01-29 03:12, Magnus Ihse Bursie wrote: If you are going down this road,

Re: RFR: JDK-8218057 Add ppc64le and s390x profiles to jib-profiles.js

2019-01-30 Thread Erik Joelsson
Looks good. /Erik On 2019-01-30 05:41, Magnus Ihse Bursie wrote: With Volker's fix in JDK-8213698, creating devkits for cross-compiling on linux to various other platforms was made trivial. This patch uses this functionality to add new cross-compilation targets for ppc64le and s390x to

Re: Proposal: JDK-8217896: Make better use of LCPUs when building on AIX

2019-01-30 Thread Andrew Leonard
Thanks David, I just found the reference you mention, it is a little vague, but says maybe as you said. I've reworked and tested the following which seems better: NUM_CORES=`lparstat -m | grep -o "lcpu=[[0-9]]*" | cut -d "=" -f 2` I'll create a new webrev with this. Thanks Andrew Andrew

Re: RFR JDK-8217761: Enhance run-test-prebuilt jib profile to support running tests with JCov

2019-01-30 Thread Magnus Ihse Bursie
On 2019-01-29 17:55, Erik Joelsson wrote: Hello, On 2019-01-29 03:12, Magnus Ihse Bursie wrote: If you are going down this road, you'll need to verify that JCOV_IMAGE_DIR is not empty in RunTests. So keep the ifneq statement, but with an $(error ...) instead. Otherwise we'll just fail

Re: RFR: JDK-8217916: Build compare script is not comparing jmods

2019-01-30 Thread Magnus Ihse Bursie
On 2019-01-29 01:34, Erik Joelsson wrote: This patch enhances the build compare script to also look at the jmod files in the JDK image. This was triggered by JDK-8217826 (linked in issue) where we see a rare intermittent comparison failure on Windows when looking at file types. That seems to

Re: RFR JDK-8217761: Enhance run-test-prebuilt jib profile to support running tests with JCov

2019-01-30 Thread Erik Joelsson
On 2019-01-30 06:48, Magnus Ihse Bursie wrote: On 2019-01-29 17:55, Erik Joelsson wrote: Hello, On 2019-01-29 03:12, Magnus Ihse Bursie wrote: If you are going down this road, you'll need to verify that JCOV_IMAGE_DIR is not empty in RunTests. So keep the ifneq statement, but with an

Re: RFR: JDK-8217723 Switch ld from bfd to gold on gcc toolchain

2019-01-30 Thread Andrew Hughes
On Thu, 24 Jan 2019 at 13:12, Magnus Ihse Bursie wrote: > > The default binutils linker used by gcc, the bfd linker, is slow. The > new replacement, gold, has been distributed alongside gcc for several > years now, and is a well mature, and much faster, replacement. > > This issue is about

Re: RFR: JDK-8204564: Need better error output when GenerateLinkOptData fails

2019-01-30 Thread Erik Joelsson
Here is a new webrev: http://cr.openjdk.java.net/~erikj/8204564/webrev.02/ /Erik On 2019-01-30 08:52, Erik Joelsson wrote: Hello, On 2019-01-30 01:51, Magnus Ihse Bursie wrote: On 2019-01-30 02:18, Erik Joelsson wrote: Hello, Some recent build failures reminded me of this issue and

Re: RFR JDK-8217761: Enhance run-test-prebuilt jib profile to support running tests with JCov

2019-01-30 Thread Alexandre (Shura) Iline
> On Jan 30, 2019, at 8:53 AM, Erik Joelsson wrote: > > > On 2019-01-30 06:48, Magnus Ihse Bursie wrote: >> >> >> On 2019-01-29 17:55, Erik Joelsson wrote: >>> Hello, >>> >>> On 2019-01-29 03:12, Magnus Ihse Bursie wrote: If you are going down this road, you'll need to verify that

Re: RFR JDK-8217761: Enhance run-test-prebuilt jib profile to support running tests with JCov

2019-01-30 Thread Alexandre (Shura) Iline
> On Jan 30, 2019, at 6:48 AM, Magnus Ihse Bursie > wrote: > > > > On 2019-01-29 17:55, Erik Joelsson wrote: >> Hello, >> >> On 2019-01-29 03:12, Magnus Ihse Bursie wrote: >>> If you are going down this road, you'll need to verify that JCOV_IMAGE_DIR >>> is not empty in RunTests. So keep

(urgent) RFR: JDK-8218084: Revert JDK-8218057

2019-01-30 Thread Erik Joelsson
The addition of new build profiles in jib-profiles.js caused our internal build and test system to break down. While we fix the resilience of that system, we need to back this change out. This patch is the result of: $ hg backout 8830bb9587c2 Bug:

Re: (urgent) RFR: JDK-8218084: Revert JDK-8218057

2019-01-30 Thread Joe Darcy
+1 -Joe On 1/30/2019 12:47 PM, Erik Joelsson wrote: The addition of new build profiles in jib-profiles.js caused our internal build and test system to break down. While we fix the resilience of that system, we need to back this change out. This patch is the result of: $ hg backout

Re: (urgent) RFR: JDK-8218084: Revert JDK-8218057

2019-01-30 Thread Christian Tornqvist
Looks good, thanks for dealing with this so quickly Thanks, Christian > On Jan 30, 2019, at 12:47 PM, Erik Joelsson wrote: > > The addition of new build profiles in jib-profiles.js caused our internal > build and test system to break down. While we fix the resilience of that > system, we

Re: RFR: JDK-8217723 Switch ld from bfd to gold on gcc toolchain

2019-01-30 Thread Martin Buchholz
I agree with Andrew Hughes. On Wed, Jan 30, 2019 at 9:27 AM Andrew Hughes wrote: > > I'm aware of the benefits of using gold, and also occasional issues with > it, but that's not the debate here. It's already perfectly possible to > build with gold by using --with-ldflags="-fuse-ld=gold", as

RE: RFR : [XS] 8218046: use bundled freetype in the AIX build by default

2019-01-30 Thread Baesken, Matthias
Thanks Magnus ! May I get a second review please ? Best regards, Matthias > -Original Message- > From: Magnus Ihse Bursie > Sent: Mittwoch, 30. Januar 2019 14:42 > To: Baesken, Matthias ; 'build- > d...@openjdk.java.net' > Subject: Re: RFR : [XS] 8218046: use bundled freetype in the

Re: RFR : [XS] 8218046: use bundled freetype in the AIX build by default

2019-01-30 Thread Magnus Ihse Bursie
On 2019-01-30 14:59, Baesken, Matthias wrote: Thanks Magnus ! May I get a second review please ? For build changes a second reviewer is not needed; that's a hotspot rule. /Magnus Best regards, Matthias -Original Message- From: Magnus Ihse Bursie Sent: Mittwoch, 30. Januar 2019