Re: [aarch64-port-dev ] FW: [Mach5] mach5-one-phh-JDK-8151779-20200427-2151-10554367: FAILED

2020-05-01 Thread Erik Joelsson
Hello, My OracleJDK 14 displays: java version "14" 2020-03-17 Not sure where you found a version output without the word "version" in it. From what I understand, any distributor is free to change the "openjdk" prefix of this line, so relying on there only being 2 cases is not a good idea.

Re: RFR(XS):8244248: boot-jdk.m4 captures the version line using regex

2020-05-01 Thread Liu, Xin
HI, Eric, Thanks for the feedback. I use [] to wrap the regex for readability. Here is a new webrev: https://cr.openjdk.java.net/~xliu/8244248/01/webrev/make/autoconf/boot-jdk.m4.udiff.html thanks, --lx On 5/1/20, 2:15 PM, "Erik Joelsson" wrote: CAUTION: This email originated from

Re: RFR(XS):8244248: boot-jdk.m4 captures the version line using regex

2020-05-01 Thread Erik Joelsson
On 2020-05-01 13:44, Liu, Xin wrote: Hello, Erik, Thank you for your comments. I made some change. Could you review it again? JBS: https://bugs.openjdk.java.net/browse/JDK-8244248 Webrev: https://cr.openjdk.java.net/~xliu/8244248/00/webrev/ This looks good. Some new comments: 1) I don't know

Re: RFR: JDK-8244247: Build failures after sjavac cleanup

2020-05-01 Thread Tim Bell
Erik: Looks good. Tim After the sjavac cleanup in JDK-8244036 (and the subsequent fix of the javac server usage in JDK-8244210), two more build failures have been noted. The bootcycle build fails and the test-make target fails the tests of SetupJavaCompilation. The bootcycle build fails

RFR(XS):8244248: boot-jdk.m4 captures the version line using regex

2020-05-01 Thread Liu, Xin
Hello, Erik, Thank you for your comments. I made some change. Could you review it again? JBS: https://bugs.openjdk.java.net/browse/JDK-8244248 Webrev: https://cr.openjdk.java.net/~xliu/8244248/00/webrev/ Some new comments: 1) I don't know that there're subtle difference between '-version'

Re: [aarch64-port-dev ] FW: [Mach5] mach5-one-phh-JDK-8151779-20200427-2151-10554367: FAILED

2020-05-01 Thread Liu, Xin
Hi, Andrew, How about this? I can use awk to capture java -version. There're 2 cases. I) openjdk openjdk version "14.0.1" 2020-04-14 2) oraclejdk java 14.0.1 2020-04-14 if somehow java displays some error/warning messages, awk can filter them out and capture the version line. Eg. $

RFR: JDK-8244247: Build failures after sjavac cleanup

2020-05-01 Thread Erik Joelsson
After the sjavac cleanup in JDK-8244036 (and the subsequent fix of the javac server usage in JDK-8244210), two more build failures have been noted. The bootcycle build fails and the test-make target fails the tests of SetupJavaCompilation. The bootcycle build fails because a space has crept