Re: RFR(S) : 8211977 : move testlibrary tests into one place

2020-06-16 Thread David Holmes
Hi Igor, On 16/06/2020 10:39 am, Igor Ignatyev wrote: @David, Erik, Magnus, please find the answers to your comments at the bottom of this email. @all, David's and Erik's comments made me realize that some parts of the original patch were stashed away and didn't make it to webrev.00. I'm

Re: Documenting options; was Re: RFR: JDK-8220639 Need a way to augment JTREG_LAUNCHER_OPTIONS from command-line

2020-06-16 Thread Magnus Ihse Bursie
On 2020-06-16 04:33, Jonathan Gibbons wrote: Thanks; I'll link to that page from the jtreg FAQ. ... but please use the tip URL: https://hg.openjdk.java.net/jdk/jdk/raw-file/tip/doc/testing.html Actually, that link is going to get stale in just a few months time. Probably better to link here

Re: Documenting options; was Re: RFR: JDK-8220639 Need a way to augment JTREG_LAUNCHER_OPTIONS from command-line

2020-06-16 Thread Lance Andersen
Hi Magnus, Can we update this page to include an example of how to run a JTREG manual test via the make infrastructure? Best Lance > On Jun 16, 2020, at 8:26 AM, Magnus Ihse Bursie > wrote: > > On 2020-06-16 04:33, Jonathan Gibbons wrote: >> Thanks; I'll link to that page from the jtreg

Re: RFR: JDK-8220639 Need a way to augment JTREG_LAUNCHER_OPTIONS from command-line

2020-06-16 Thread Magnus Ihse Bursie
On 2020-06-16 04:58, David Holmes wrote: Hi Magnus, Great to see this getting fixed! Thanks! On 16/06/2020 1:56 am, Magnus Ihse Bursie wrote: It turned out that it was not possible to send arguments directly to the java that launches jtreg, something that was needed, especially to change the

Re: RFR: JDK-8220639 Need a way to augment JTREG_LAUNCHER_OPTIONS from command-line

2020-06-16 Thread David Holmes
On 16/06/2020 10:35 pm, Magnus Ihse Bursie wrote: On 2020-06-16 04:58, David Holmes wrote: Hi Magnus, Great to see this getting fixed! Thanks! On 16/06/2020 1:56 am, Magnus Ihse Bursie wrote: It turned out that it was not possible to send arguments directly to the java that launches jtreg,

Re: RFR(S) : 8211977 : move testlibrary tests into one place

2020-06-16 Thread Erik Joelsson
On 2020-06-15 17:39, Igor Ignatyev wrote: @David, Erik, Magnus, please find the answers to your comments at the bottom of this email. @all, David's and Erik's comments made me realize that some parts of the original patch were stashed away and didn't make it to webrev.00. I'm truly sorry

Re: Documenting options; was Re: RFR: JDK-8220639 Need a way to augment JTREG_LAUNCHER_OPTIONS from command-line

2020-06-16 Thread Jonathan Gibbons
Magnus, There's a mild ambiguity in the use of the phrase "JTReg keywords" which is used to describe both the mechanism in the run-test framework, and the jtreg test selection mechanism. That aside, while reading the file, I noticed the following typo (kewords): KEYWORDS JTReg

Re: RFR(S) : 8211977 : move testlibrary tests into one place

2020-06-16 Thread Magnus Ihse Bursie
On 2020-06-16 15:06, Erik Joelsson wrote: On 2020-06-15 17:39, Igor Ignatyev wrote: @David, Erik, Magnus, please find the answers to your comments at the bottom of this email. @all, David's and Erik's comments made me realize that some parts of the original patch were stashed away and

Re: Documenting options; was Re: RFR: JDK-8220639 Need a way to augment JTREG_LAUNCHER_OPTIONS from command-line

2020-06-16 Thread Magnus Ihse Bursie
On 2020-06-16 16:35, Jonathan Gibbons wrote: On 6/16/20 5:26 AM, Magnus Ihse Bursie wrote: On 2020-06-16 04:33, Jonathan Gibbons wrote: Thanks; I'll link to that page from the jtreg FAQ. ... but please use the tip URL: https://hg.openjdk.java.net/jdk/jdk/raw-file/tip/doc/testing.html

Re: Documenting options; was Re: RFR: JDK-8220639 Need a way to augment JTREG_LAUNCHER_OPTIONS from command-line

2020-06-16 Thread Magnus Ihse Bursie
On 2020-06-16 14:31, Lance Andersen wrote: Hi Magnus, Can we update this page to include an example of how to run a JTREG manual test via the make infrastructure? For the record: After some off-list discussion, Lance opened https://bugs.openjdk.java.net/browse/JDK-8247690 for supporting

Re: Documenting options; was Re: RFR: JDK-8220639 Need a way to augment JTREG_LAUNCHER_OPTIONS from command-line

2020-06-16 Thread Jonathan Gibbons
On 6/16/20 5:26 AM, Magnus Ihse Bursie wrote: On 2020-06-16 04:33, Jonathan Gibbons wrote: Thanks; I'll link to that page from the jtreg FAQ. ... but please use the tip URL: https://hg.openjdk.java.net/jdk/jdk/raw-file/tip/doc/testing.html Actually, that link is going to get stale in just

test defaults: was Re: Documenting options; was Re: RFR: JDK-8220639 Need a way to augment JTREG_LAUNCHER_OPTIONS from command-line

2020-06-16 Thread Jonathan Gibbons
On defaults for running jtreg tests ... In my experience, and given the separate recent discussion with Stefan Karlsson, there are two significant modalities for running tests: running lots of tests, and just running a single test, typically while developing or debugging the test. With that

Re: RFR(S) : 8211977 : move testlibrary tests into one place

2020-06-16 Thread Igor Ignatyev
Magnus, Erik, thanks for your reviews, pushed w/ a newline being added at L#654 of make/Main.gmk. Cheers, -- Igor > On Jun 16, 2020, at 7:03 AM, Magnus Ihse Bursie > wrote: > > On 2020-06-16 15:06, Erik Joelsson wrote: >> >> On 2020-06-15 17:39, Igor Ignatyev wrote: >>> @David, Erik,

Re: RFR(S) : 8211977 : move testlibrary tests into one place

2020-06-16 Thread Igor Ignatyev
Hi David, thanks for your review. re: LingeredAppTest, I agree that the test doesn't look very useful, yet I'd remind that the goal of this (and other test in /test/lib-test) is to (sanity) test testlibrary in order to easily spot bugs in testlibrary in a clear manner so one would not have to

Re: Documenting options; was Re: RFR: JDK-8220639 Need a way to augment JTREG_LAUNCHER_OPTIONS from command-line

2020-06-16 Thread Magnus Ihse Bursie
On 2020-06-16 16:45, Magnus Ihse Bursie wrote: On 2020-06-16 16:35, Jonathan Gibbons wrote: On 6/16/20 5:26 AM, Magnus Ihse Bursie wrote: On 2020-06-16 04:33, Jonathan Gibbons wrote: Thanks; I'll link to that page from the jtreg FAQ. ... but please use the tip URL:

RFR: JDK-8213214: Set -Djava.io.tmpdir= when running tests

2020-06-16 Thread Erik Joelsson
(re-sending this as it doesn't look like it was delivered) There are a lot of jtreg tests that use temporary files. These temporary files add up over time and fill up the global temp directories on our test systems. To tackle this, we should try to redirect these temporary files into a

RFR: JDK-8213214: Set -Djava.io.tmpdir= when running tests

2020-06-16 Thread Erik Joelsson
There are a lot of jtreg tests that use temporary files. These temporary files add up over time and fill up the global temp directories on our test systems. To tackle this, we should try to redirect these temporary files into a directory controlled by the test framework. Jtreg does not do

Re: RFR(S) : 8211977 : move testlibrary tests into one place

2020-06-16 Thread David Holmes
On 17/06/2020 2:45 am, Igor Ignatyev wrote: Hi David, thanks for your review. re: LingeredAppTest, I agree that the test doesn't look very useful, yet I'd remind that the goal of this (and other test in /test/lib-test) is to (sanity) test testlibrary in order to easily spot bugs in

Re: RFR: JDK-8200738 Use --hash-style=gnu for gcc

2020-06-16 Thread Ioi Lam
On 6/15/20 2:08 AM, Magnus Ihse Bursie wrote: On 2020-06-15 07:46, David Holmes wrote: Hi Magnus, On 13/06/2020 1:42 am, Magnus Ihse Bursie wrote: When support for gnu hash tables were added to the gcc toolchains, the OpenJDK build system added a hack to change --hash-style=gnu to

Re: RFR: JDK-8213214: Set -Djava.io.tmpdir= when running tests

2020-06-16 Thread Jonathan Gibbons
It would also be good to identify the tests that are using temporary directories in this manner and have them use the jtreg scratch directory where possible. -- Jon On 6/16/20 12:22 PM, Erik Joelsson wrote: (re-sending this as it doesn't look like it was delivered) There are a lot of jtreg