Including build-dev since this patch is adding new issue 8248135:
https://bugs.openjdk.java.net/browse/JDK-8248135
So here's new webrev with a patch for building benchmarks with
--enable-preview included:
http://cr.openjdk.java.net/~plevart/jdk-dev/RecordsDeserialization/webrev.08/
> On 23 Jun 2020, at 10:46, Chris Hegarty wrote:
>
>
>
>> On 23 Jun 2020, at 10:17, Peter Levart wrote:
>>
>> ...
>> http://cr.openjdk.java.net/~plevart/jdk-dev/RecordsDeserialization/webrev.08/
>
> Good stuff. Reviewed.
>
> I am going to take this latest change and run it through our
On 6/23/20 2:47 PM, Chris Hegarty wrote:
On 23 Jun 2020, at 10:46, Chris Hegarty wrote:
On 23 Jun 2020, at 10:17, Peter Levart wrote:
...
http://cr.openjdk.java.net/~plevart/jdk-dev/RecordsDeserialization/webrev.08/
Good stuff. Reviewed.
I am going to take this latest change and run
Thanks, Magnus.
Peter
On 6/23/20 11:27 AM, Magnus Ihse Bursie wrote:
On 2020-06-23 11:17, Peter Levart wrote:
Including build-dev since this patch is adding new issue 8248135:
https://bugs.openjdk.java.net/browse/JDK-8248135
So here's new webrev with a patch for building benchmarks with
On 2020-06-23 11:17, Peter Levart wrote:
Including build-dev since this patch is adding new issue 8248135:
https://bugs.openjdk.java.net/browse/JDK-8248135
So here's new webrev with a patch for building benchmarks with
--enable-preview included:
> On 23 Jun 2020, at 10:17, Peter Levart wrote:
>
> ...
> http://cr.openjdk.java.net/~plevart/jdk-dev/RecordsDeserialization/webrev.08/
Good stuff. Reviewed.
I am going to take this latest change and run it through our internal build and
test system. Will post the results here soon.
On 2020-06-23 06:17, David Holmes wrote:
Hi Coleen,
Cleanup is looking good but a few comments:
- if the bytecodeInterpreter is also zero-only can we rename its files
too? (I really find it hard to figure out which files are really
needed/used for a given build.)
- you are excluding shared
Looks good to me!
/Claes
On 2020-06-23 11:17, Peter Levart wrote:
Including build-dev since this patch is adding new issue 8248135:
https://bugs.openjdk.java.net/browse/JDK-8248135
So here's new webrev with a patch for building benchmarks with
--enable-preview included:
Looks good, but that was the worst way of posting a patch I've seen to date.
/Erik
On 2020-06-23 07:37, Magnus Ihse Bursie wrote:
If you run |make test TEST=jtreg:gtest/GTestWrapper.java| but had not
built using the gtest framework, you would just get a result like this:
|STDERR:
If you run |make test TEST=jtreg:gtest/GTestWrapper.java| but had not
built using the gtest framework, you would just get a result like this:
|STDERR: java.lang.Error: TESTBUG: the library has not been found in
On 2020-06-23 17:05, Erik Joelsson wrote:
Looks good, but that was the worst way of posting a patch I've seen to
date.
The mail you quoted looked awful, yes! :-( I tried a new way of
formatting the mail so the patch and log should be fixed space.
Apparently it failed horribly.
Also, I
That looks much better! :)
/Erik
On 2020-06-23 09:53, Magnus Ihse Bursie wrote:
On 2020-06-23 17:05, Erik Joelsson wrote:
Looks good, but that was the worst way of posting a patch I've seen
to date.
The mail you quoted looked awful, yes! :-( I tried a new way of
formatting the mail so the
LGTM
— Igor
> On Jun 23, 2020, at 11:13 AM, Erik Joelsson wrote:
>
> That looks much better! :)
>
> /Erik
>
>> On 2020-06-23 09:53, Magnus Ihse Bursie wrote:
>>> On 2020-06-23 17:05, Erik Joelsson wrote:
>>> Looks good, but that was the worst way of posting a patch I've seen to date.
>> The
On 2020-06-23 22:35, coleen.phillim...@oracle.com wrote:
Including build-dev.
On 6/23/20 12:17 AM, David Holmes wrote:
Hi Coleen,
Cleanup is looking good but a few comments:
- if the bytecodeInterpreter is also zero-only can we rename its
files too? (I really find it hard to figure out
Including build-dev.
On 6/23/20 12:17 AM, David Holmes wrote:
Hi Coleen,
Cleanup is looking good but a few comments:
- if the bytecodeInterpreter is also zero-only can we rename its files
too? (I really find it hard to figure out which files are really
needed/used for a given build.)
I thoroughly applaud the introduction of interpreter/zero directory!
Thank you. :)
Updates look good to me.
Thanks,
David
On 24/06/2020 6:35 am, coleen.phillim...@oracle.com wrote:
Including build-dev.
On 6/23/20 12:17 AM, David Holmes wrote:
Hi Coleen,
Cleanup is looking good but a few
Thanks, Magnus.
Coleen
On 6/23/20 7:04 PM, Magnus Ihse Bursie wrote:
On 2020-06-23 22:35, coleen.phillim...@oracle.com wrote:
Including build-dev.
On 6/23/20 12:17 AM, David Holmes wrote:
Hi Coleen,
Cleanup is looking good but a few comments:
- if the bytecodeInterpreter is also
17 matches
Mail list logo
