Hi All,
On zLinux, freetype's .so file is typically installed in
/usr/lib/s390x-linux-gnu, however the generated configure script doesn't
look for it there.
This causes configure to fail. I know you can avoid that with options, but
I think a fix would be better.
If we add this code to lib-fre
On 01/12/2018 03:29 PM, Adam Farley8 wrote:
>> On zLinux, freetype's .so file is typically installed in
>> /usr/lib/s390x-linux-gnu, however the generated configure script
doesn't
>> look for it there.
>
>Odd. Normally I would expect it to look in the lo
ially, regardless of whether
we have
any evidence that we're on that platform. Hence my addition to that list
of IF
statements.
Best Regards
Adam Farley
From: John Paul Adrian Glaubitz
To: Erik Joelsson , Adam Farley8
, build-dev@openjdk.java.net
Date: 12/01/2018 17:29
Subject
Hi All,
On zLinux, freetype's .so file is typically installed in
/usr/lib/s390x-linux-gnu, however the generated configure script doesn't
look for it there.
This causes configure to fail. I know you can avoid that with options, but
I think a fix would be better.
If we add this code to lib-fre
Hi All,
>
>On Mon, 2018-01-15 at 20:21 +0100, John Paul Adrian Glaubitz wrote:
>> Hi Adam!
>>
>> On 01/15/2018 06:15 PM, Adam Farley8 wrote:
>> > > Which I would expect to cover your case, unless there is a
>> > > mismatch
>> > > be
>On 2018-01-16 18:54, Erik Joelsson wrote:
>>
>>
>> On 2018-01-16 09:50, Erik Joelsson wrote:
>>>
>>>
>>> On 2018-01-16 09:03, Adam Farley8 wrote:
>>>> >Configure already looks in:
>>>>
>>>> >$SYSROOT/usr/li
Hi All,
If you compile jchuff.c (part of javajpeg) without
"--disable-warnings-as-errors",
then you get an error that kills the build. This is seen in these
circumstances:
Build: JDK9
gcc and g++ Version: 4.8.5
Platform: zLinux 64bit (s390x)
The error message is:
/home/adamfarl/hotspot/jdk9/
Hi All,
If you compile jchuff.c (part of javajpeg) without
"--disable-warnings-as-errors",
then you get an error that kills the build. This is seen in these
circumstances:
Build: JDK9
gcc and g++ Version: 4.8.5
Platform: zLinux 64bit (s390x)
The error message is:
/home/adamfarl/hotspot/jdk9/
Hi John, David,
>> If you compile jchuff.c (part of javajpeg) without
>> "--disable-warnings-as-errors",
>> then you get an error that kills the build. This is seen in these
>> circumstances:
>Last time this particular discussion came up, the conclusion was that
>hunting for warnings is a lost ba
>> If this is the consensus, then perhaps we should consider setting
>> --disable-warnings-as-errors by default (in the code), rather than
>> depending on the user using an option which is not part of the formal
>> build instructions.
>I'm not sure why.
Because the default build instructions don
Hi All,
In JDK9 on zLinux 64bit, it seems we don't look for libfreetype.so
in /usr/lib/$OPENJDK_TARGET_CPU-linux-gnu by default.
If you DO have pkg-config, "configure" searches for freetype in
several places, including a place relative to gcc,
(gcc/../../etc) where it uses the correct folder n
>> Switching the OPTIMIZATION to LOW will solve this at a stroke.
>
>And regress performance for all platforms I expect in a case where
>performance matters ..
>in order to work around a gcc bug ? I don't think so.
I wasn't considering the performance impact on java jpeg. A fair
statement.
>Disa
> This isn't really a question for build-dev. It should be brought to the
> component team owning that particular source. I believe in this case
> that would be 2d-dev.
> /Erik
Hi Erik,
This has been mentioned. One of my responses yesterday indicates I raised
a counterpart in 2d-dev already.
Hi All
I sent an email to the 2d-dev list yesterday, but I'll respond here as
well
so you guys know I'm not ignoring you. :)
> This is all correct, thanks David!
>
> For the official toolchains (basically what Oracle builds with), we very
> much like to keep warnings-as-errors active, because
L. I agree with your position on 4.8.5 gcc needing
to compile OpenJDK without errors or special options. :)
Best Regards
Adam Farley
From: Phil Race
To: Adam Farley8 , 2d-...@openjdk.java.net
Cc: build-dev
Date: 18/01/2018 19:16
Subject:Re: [OpenJDK 2D-Dev] [PATCH] Build f
> On 01/23/2018 02:44 PM, Adam Farley8 wrote:
>> John: I read your email, and I understand your position. I disagree
with it,
>> but I understand it. 4.8.5 is an old version of gcc, but right now it
is the
>> listed gcc version for SUSE sles on intel, ppc, ppcle, and zLinux
> On 01/23/2018 03:13 PM, Adam Farley8 wrote:
>> The URL supplied by David (Holmes) lists 4.8.5 as the gcc version for
>> building JDK9 on SLES 11.3/12.1. Whether it's in a repository or not,
>> I read that as "this is the gcc version you should be bu
>On 01/23/2018 05:25 PM, Adam Farley8 wrote:
>>> SLE-11:* doesn't even have OpenJDK-8 and is also going to be out of
support
>>> next year anyway.
>>
>> Does this mean the gcc version will change? If you have hard
information on
>> this, I'd
ou are building 8u or 9 and use
>> gcc 4.8.5, which is supposed to be a valid compiler to use based on
>> the wiki, then it fails because of this gcc bug, unless you disable
>> warnings-as-errors. So either we put in a workaround for the bug or we
>> update to the build docs (and/
> On 02/01/2018 12:36 PM, Adam Farley8 wrote:
>> After doing some experimenting, I've discovered the problem isn't
limited to
>> SLES, or gcc 4.8.5, or zLinux.
>>
>> (...)
>> Thoughts?
> I think the problem is more that if you are trying to silenc
Re: [OpenJDK 2D-Dev] RFR: Bug Pending: Build fails to compile
jchuff.cErik Joelsson to: Adam Farley8 01/02/2018 17:06
Cc: build-dev, David Holmes, John Paul Adrian Glaubitz, Magnus Ihse Bursie
From: Erik Joelsson
To: Adam Farley8
Cc: build-dev , David Holmes
, John Paul Adrian Glaubitz
-- Summary --
I ask for a committer to go into jdk/jdk and add one word to
make/lib/Awt2dLibraries.gmk
We need to go to line 495 and add array-bounds into the list of disabled
warnings.
So this:
DISABLED_WARNINGS_gcc := clobbered implicit-fallthrough
shift-negative-value, \
becomes this:
I also advocate the source code fix, as Make isn't meant to use the sort
of logic required
to properly analyse the toolchain version string.
e.g. An "eq" match on 4.8.5 doesn't protect the user who is using 4.8.6,
and Make doesn't
seem to do substring stuff unless you mess around with shells.
I also advocate the source code fix, as Make isn't meant to use the sort
of logic required
to properly analyse the toolchain version string.
e.g. An "eq" match on 4.8.5 doesn't protect the user who is using 4.8.6,
and Make doesn't
seem to do substring stuff unless you mess around with shells.
Hi All,
Does anyone have an objection to pushing this tiny change in?
It doesn't break anything, it fixes a build break on two supported
platforms, and it seems
like we never refresh the code from upstream.
- Adam
> I also advocate the source code fix, as Make isn't meant to use the sort
of
ot build code so I don't have the final say.
> >
> > /Magnus
> >
> >
> > On 2018-04-25 17:43, Adam Farley8 wrote:
> >
> > Hi All,
> >
> > Does anyone have an objection to pushing this tiny change in?
> >
> > It doesn't break anythin
00052: libjavajpeg: Fix compile
warning in jchuff.cPhilip Race to: Adam Farley8 17/05/2018 03:32
> Cc: 2d-dev, Andrew Leonard, build-dev, Magnus Ihse Bursie, "Thomas
Stüfe"
> From: Philip Race
> To: Adam Farley8
> Cc: 2d-dev <2d-...@openjdk.java.net>, Andrew Leonard
, b
; s390 build. It is annoying but no big deal breaker.
>
> Thanks & best Regards, Thomas
>
>
> On Fri, May 18, 2018 at 5:23 PM, Adam Farley8
wrote:
> > Hi,
> >
> > I tried to use the IJG's contact page, but no joy. Seems broken; there
a
> > spinning
Adam Farley
P.S. I'm holding off on giving Guido the green light until after people
say if they're happy with the error-enabled version of the fix.
Adam Farley8/UK/IBM wrote on 14/05/2018 11:06:28:
> From: Adam Farley8/UK/IBM
> To: Phil Race
> Cc: 2d-dev <2d-...@openjdk.j
Hi Phil,
As requested:
FYI: I've also contacted Guido, confirmed that the fix worked, and asked
him to go ahead with merging the fix into his code base.
Best Regards
Adam Farley
Phil Race wrote on 30/05/2018 18:06:19:
> From: Phil Race
> To: Adam Farley8
>
Sounds OK to me. :)
Best Regards
Adam Farley
Philip Race wrote on 01/06/2018 03:04:12:
> From: Philip Race
> To: Adam Farley8
> Cc: 2d-dev <2d-...@openjdk.java.net>, build-dev d...@openjdk.java.net>, Andrew Leonard ,
> "Stuefe, Thomas"
> Date: 01/06/201
Hi All,
The build passed on xlC 13.1 with the makefile patch I proposed (good
catch on the comments Volkar!).
With Volkar, Erik, Matthias, and Magnus all approving the change, it
sounds like we're good to merge!
Volkar, can you do the honours?
Best Regards
Adam Farley
IBM Runtimes
P.S. I a
Jc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=NhALBBoEo6HsbPIjB8bJJj30UR8DRP-
> PuJckMbmJvA0&s=gLabfGk2XJdLwimruwQdLAmjBXtCueO7qR01_xw5wuw&e=
>
> Best regards,
> Volker
> On Thu, Nov 29, 2018 at 5:54 PM Adam Farley8
wrote:
> >
> > Hi All,
> >
> > The build passed on xlC 13.
Hi All,
Requesting reviews and sponsor for the following change.
A previous change (JDK-8244044) appears to prevent make from checking the
include dirs for an included gmk file.
This means that you can't override the included file using the include
dirs, as was previously the case.
This sound
Hi All,
Reviews and sponsor requested for the removal of the now-redundant
MAKE_SUBDIR argument in DeclareRecipesForPhase's comment, along with its
removal from anything that calls that macro.
Bug: https://bugs.openjdk.java.net/browse/JDK-8253000
Webrev: http://cr.openjdk.java.net/~afarley/825
35 matches
Mail list logo
