I had the need for setting additional C/C++ compilation flags in my OpenJDK8
build.
It seems they are used for most jdk C/C++ compilation, but at least the
generators from
jdk/makefiles/gensrc/GensrcMisc.gmk
seem to be an exception.
Example :
configure
Pointon [mailto:dpoin...@linux.vnet.ibm.com]
Sent: Freitag, 22. November 2013 14:34
To: Baesken, Matthias
Cc: build-dev@openjdk.java.net
Subject: Re: jdk8 extra c/cxx - flags settings
Hi Matthias ,
On Fri, 2013-11-22 at 12:55 +, Baesken, Matthias wrote:
I had the need for setting additional C
. November 2013 10:37
To: David Holmes; Baesken, Matthias
Cc: build-dev@openjdk.java.net
Subject: Re: jdk8 extra c/cxx - flags settings
On 2013-11-25 03:01, David Holmes wrote:
Hi Matthias,
On 22/11/2013 10:55 PM, Baesken, Matthias wrote:
I had the need for setting additional C/C++ compilation
I noticed when building Open JDK 8 fast-debug with Sun Studio 12 on Solaris
Sparc,
the VM crashes early when executed on T4 based machines (both T4 based Solaris
Sparc10 and 11 machines);
I cannot see the issue on older Sparc processors or Fujitsu SPARC64.
The Crashes look like this :
public info about these problems and relation to the patches in
the README ?
Regards, Matthias
-Original Message-
From: Vladimir Kozlov [mailto:vladimir.koz...@oracle.com]
Sent: Mittwoch, 12. Februar 2014 21:38
To: Phil Race; Baesken, Matthias; hotspot-...@openjdk.java.net;
build-dev
Hello,
could I please have a review for the following small change that
cleans up the special macosx BUILD_JSPAWNHELPER_DST_DIR setting that is not
really
needed any more after CR 8066474: "Remove the lib/ directory from Linux
and Solaris images" changed the default setting
Hello all ,
Erik suggested to do further cleanups in make/launcher/Launcher-java.base.gmk
In the jspawnhelper build section.
Those were the suggestions :
* Inline BUILD_JSPAWNHELPER_SRC, JSPAWNHELPER_CFLAGS,
BUILD_JSPAWNHELPER_DST_DIR and LINK_JSPAWNHELPER_OBJECTS. Since these
variables
uld go into another bug.
Thanks and best regards, Matthias
From: Erik Joelsson [mailto:erik.joels...@oracle.com]
Sent: Mittwoch, 8. Februar 2017 11:11
To: Baesken, Matthias <matthias.baes...@sap.com>; build-dev@openjdk.java.net
Cc: Langer, Christoph <christoph.lan...@sap.com>
Su
with the change 8156478: 3 Buffer overrun defect groups in
jexec.c )
Executing a helloworld.jar with jexec leads to
"invalid file (bad magic number): Exec format error" .
Should I open another bug for this ?
Best regards, Matthias
From: Baesken, Matthias
Sent: F
s a separate issue and not really build related.
/Erik
On 2017-02-14 17:27, Baesken, Matthias wrote:
Hello, here is the webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8174242/<http://cr.openjdk.java.net/%7Embaesken/webrevs/8174242/>
bug :
https://bugs.openjdk.java.net/browse/JDK-81
n [mailto:erik.joels...@oracle.com]
Sent: Donnerstag, 9. Februar 2017 13:42
To: Baesken, Matthias <matthias.baes...@sap.com>; build-dev@openjdk.java.net
Cc: Langer, Christoph <christoph.lan...@sap.com>
Subject: Re: jdk10 : simplify jexec build settings
Hello,
On 2017-02-09 12:
bruar 2017 09:49
To: Baesken, Matthias <matthias.baes...@sap.com>; build-dev@openjdk.java.net;
core-libs-...@openjdk.java.net
Cc: Langer, Christoph <christoph.lan...@sap.com>
Subject: Re: jdk10 : simplify jexec build settings
Since the file has never been built, I would say remove
of jexec.c for macosx one day
again).
Comments / suggestions ?
Best regards, Matthias
From: Baesken, Matthias
Sent: Donnerstag, 9. Februar 2017 14:10
To: 'Erik Joelsson' <erik.joels...@oracle.com>; build-dev@openjdk.java.net;
'core-libs-...@openjdk.java.net' <core-libs-...@openjdk.jav
, 13. Juli 2017 13:34
To: Baesken, Matthias <matthias.baes...@sap.com>; 'build-dev@openjdk.java.net'
<build-dev@openjdk.java.net>; 'hotspot-...@openjdk.java.net'
<hotspot-...@openjdk.java.net>
Subject: Re: jdk10 build : usage of -fno-var-tracking-assignments g++ flag in
ho
builds do not
use it).
Best regards, Matthias
-Original Message-
From: Simon Nash [mailto:si...@cjnash.com]
Sent: Donnerstag, 13. Juli 2017 21:56
To: Baesken, Matthias <matthias.baes...@sap.com>
Cc: Erik Joelsson <erik.joels...@oracle.com>; 'build-dev@openjdk.java.ne
Thanks , can you push it ( as far as I know someone from Oracle needs to push
it because generated-configure.sh is changed ) ?
Best regards, Matthias
-Original Message-
From: Erik Joelsson [mailto:erik.joels...@oracle.com]
Sent: Freitag, 14. Juli 2017 14:43
To: Baesken, Matthias
Hello, when building jdk10 on Suse Linux 11 with default gcc/g++ 4.3.4
installed, I was running into
compilation errors because of the missing support for g++ flag
-fno-var-tracking-assignments .
It seems gcc-4.6 has the -fvar-tracking-assignments /
-fnovar-tracking-assignments flags ,
gcc versions)
Best regards, Matthias
-Original Message-
From: Baesken, Matthias
Sent: Freitag, 14. Juli 2017 08:36
To: 'Simon Nash' <si...@cjnash.com>
Cc: Erik Joelsson <erik.joels...@oracle.com>; 'build-dev@openjdk.java.net'
<build-dev@openjdk.java
v :
http://cr.openjdk.java.net/~mbaesken/webrevs/8184323/
Best regards, Matthias
-Original Message-
From: Jiangli Zhou [mailto:jiangli.z...@oracle.com]
Sent: Montag, 10. Juli 2017 17:54
To: Baesken, Matthias <matthias.baes...@sap.com>
Cc: hotspot-...@openjdk.java.net; build-dev@o
nd webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8184323.1/
Is a second review needed ?
Best regards, Matthias
From: Jiangli Zhou [mailto:jiangli.z...@oracle.com]
Sent: Samstag, 15. Juli 2017 06:37
To: Baesken, Matthias <matthias.baes...@sap.com>
Cc: hotspot-...@openjdk.java
Thanks !
-Original Message-
From: Aleksey Shipilev [mailto:sh...@redhat.com]
Sent: Dienstag, 18. Juli 2017 09:31
To: Baesken, Matthias <matthias.baes...@sap.com>; Jiangli Zhou
<jiangli.z...@oracle.com>
Cc: build-dev@openjdk.java.net; hotspot-...@openjdk.java.net
Subj
Ping : could someone from oracle please push it ?
(reason is that it touches the generated-configure.sh files )
Thanks, Matthias
-Original Message-
From: Baesken, Matthias
Sent: Freitag, 14. Juli 2017 17:05
To: 'Erik Joelsson' <erik.joels...@oracle.com>; Simon Nash <si...@c
Hi Tim , Thanks !
-Original Message-
From: Tim Bell [mailto:tim.b...@oracle.com]
Sent: Mittwoch, 19. Juli 2017 03:29
To: Baesken, Matthias <matthias.baes...@sap.com>; Erik Joelsson
<erik.joels...@oracle.com>; Simon Nash <si...@cjnash.com>; Simonis, Volker
<volke
s not
>specified, but it probably has a bit of dead code.
>
>Are you mainly trying to reduce the size of libjvm when CDS is not enabled?
>
>Thanks
>- Ioi
>
>
>On 7/5/17 6:36 AM, Baesken, Matthias wrote:
>> Hello, when looking into CDS related build options,
Hello, when looking into CDS related build options, I noticed that most
code-parts that are executed only when UseSharedSpaces is set,
are guarded by the compile-time macroINCLUDE_CDS to support switching
off compilation of this coding
when CDS is disabled at compile time :
for JDK8 .
And does the 11u1 package developer/gnu-binutils@2.21.1-0.175.1.0.0.24.0
Contain special objcopy patches ?
Best regards, Matthias
-Original Message-
From: David Holmes [mailto:david.hol...@oracle.com]
Sent: Freitag, 28. April 2017 13:24
To: Baesken, Matthias <matthias.bae
Hello, we are facing problems with gobjcopy on Solaris 10 x86_64.
When processing libjvm.so (product build) with FDS and separated debug-infos we
are getting :
objcopy: libjvm.debuginfo: Not enough room for program headers, try linking
with -N
It looks like we are running into this (or a
Hello,
https://wiki.openjdk.java.net/display/Build/Supported+Build+Platforms
states the list of supported build platforms/compilers (for example for 9).
Are there compiler updates planned for the 18.3 release ?
Especially is there a switch on Windows planned (from 2013SP4 to a new
Hello, I noticed that in OpenJDK 9 and 10, on 64bit Windows the
sawindbg.dll.manifest
shows up in another folder than the related dll :
./images/jdk/lib/sawindbg.dll.manifest
./images/jdk/bin/sawindbg.dll
Does anybody know why it is done this way ? I thought that usually the
manifest
]
Sent: Mittwoch, 25. Oktober 2017 10:24
To: Baesken, Matthias <matthias.baes...@sap.com>; Thomas Stüfe
<thomas.stu...@gmail.com>
Cc: build-dev (build-dev@openjdk.java.net) <build-dev@openjdk.java.net>;
ppc-aix-port-...@openjdk.java.net
Subject: Re: AIX build not generating a jre
Thanks Erik.
I check your suggestion with jdk10/master on AIX .
Best regards, Matthias
> -Original Message-
> From: Erik Joelsson [mailto:erik.joels...@oracle.com]
> Sent: Mittwoch, 25. Oktober 2017 15:22
> To: Baesken, Matthias <matthias.baes...@sap.com>;
> -Original Message-
> From: Magnus Ihse Bursie [mailto:magnus.ihse.bur...@oracle.com]
> Sent: Mittwoch, 25. Oktober 2017 16:46
> To: Erik Joelsson <erik.joels...@oracle.com>; Baesken, Matthias
> <matthias.baes...@sap.com>; Thomas Stüfe <thomas.stu...@gmail.c
* Do you get to this stage at all? I.e, can you see "Createing jre jimage"
in the output?
Hi Magnus, when comparing the linux and aix logs of our openjdk9 builds , I
see for Linux at some point :
gmake[3]: Entering directory ` . . . /nightly/jdk9/make'
/bin/echo Creating jre jimage
.1 ).
Best regards, Matthias
> -Original Message-
> From: Thomas Stüfe [mailto:thomas.stu...@gmail.com]
> Sent: Freitag, 27. April 2018 10:04
> To: Langer, Christoph <christoph.lan...@sap.com>
> Cc: Volker Simonis <volker.simo...@gmail.com>; Baesken, Matth
Hi Christoph can I add you as second reviewer (other reviewer was Erik
Joelsson) can push the change ?
Best regards, Matthias
From: Langer, Christoph
Sent: Donnerstag, 26. April 2018 16:38
To: Baesken, Matthias <matthias.baes...@sap.com>; 'build-dev@openjdk.java.net'
<
age-
> From: Phil Race [mailto:philip.r...@oracle.com]
> Sent: Dienstag, 5. Juni 2018 23:41
> To: Sergey Bylokhov ; Baesken, Matthias
> ; Langer, Christoph
> ; Thomas Stüfe ;
> 'build-dev@openjdk.java.net' ; awt-
> d...@openjdk.java.net
> Cc: 2d-dev <2d-...@openjdk.jav
Hi Thomas , thanks for fixing it, looks good ( not a Reviewer however) .
Best regards, Matthias
> -Original Message-
> From: ppc-aix-port-dev [mailto:ppc-aix-port-dev-
> boun...@openjdk.java.net] On Behalf Of Thomas Stüfe
> Sent: Mittwoch, 13. Juni 2018 08:14
> To: build-dev ;
Please review this small change that fixes the AIX build after "8203641:
Refactor String Deduplication into shared".
We are getting this compilation error :
/build_ci_jdk_jdk_rs6000_64/src/hotspot/share/gc/shared/stringdedup/stringDedup.hpp",
line 107.38: 1540-0063 (S) The text "1" is
Hi , thanks for looking into it.
I think I will use STAT_IMPL .
Best regards, Matthias
> -Original Message-
> From: René Schünemann [mailto:rene.schuenem...@gmail.com]
> Sent: Freitag, 15. Juni 2018 11:08
> To: Baesken, Matthias
> Cc: build-dev@openjdk.ja
> From: Langer, Christoph
> Sent: Freitag, 1. Juni 2018 10:57
> To: Ichiroh Takiguchi
> Cc: Baesken, Matthias ; 'build-
> d...@openjdk.java.net' ; ppc-aix-port-
> d...@openjdk.java.net; core-libs-...@openjdk.java.net; Lindenmaier,
> Goetz
> Subject: RE: RFR : 8202322: AIX: s
Hi Christoph, thank's for the review .
Could I have a second one for example from the awt or build-dev reviewers ?
Best Regards, Matthias
> -Original Message-
> From: Langer, Christoph
> Sent: Montag, 4. Juni 2018 16:49
> To: Baesken, Matthias ; Thomas Stüfe
&g
Hi Erik , is there some info available about the performance impact when
disabling disabling speculative execution ?
And which compiler versions are needed for this ?
Best regards, Matthias
>We need to add compilation flags for disabling speculative execution to
>our native
Thanks for the clarification !
From: Erik Joelsson [mailto:erik.joels...@oracle.com]
Sent: Dienstag, 5. Juni 2018 17:51
To: Baesken, Matthias ;
'hotspot-...@openjdk.java.net' ;
'build-dev@openjdk.java.net'
Cc: Zeller, Arno
Subject: Re: RFR: JDK-8202384: Introduce altserver jvm variant
; From: Baesken, Matthias
> Sent: Montag, 4. Juni 2018 09:24
> To: 'Thomas Stüfe'
> Cc: '2d-dev' <2d-...@openjdk.java.net>; Langer, Christoph
>
> Subject: RE: RFR: JDK-8204211: windows : handle potential C++ exception in
> GDIRenderer -was : RE: [OpenJDK 2D-Dev] java2d coding
Hi Alexey, looks good to me (not a Reviewer however).
Thanks, Matthias
> -Original Message-
> From: Alexey Ivanov [mailto:alexey.iva...@oracle.com]
> Sent: Mittwoch, 2. Mai 2018 11:52
> To: 2d-dev <2d-...@openjdk.java.net>
> Cc: build-dev <build-dev@openjdk.java
Hi Thomas , looks good to me( not a Reviever however).
Best Regards, Matthias
From: ppc-aix-port-dev [mailto:ppc-aix-port-dev-boun...@openjdk.java.net] On
Behalf Of Thomas Stüfe
Sent: Donnerstag, 8. Februar 2018 15:42
To: ppc-aix-port-...@openjdk.java.net; build-dev
Hello I noticed that after replacing generated-configure.sh and using
autoconf ,the build process writes into the sources .
Error looks like this :
Runnable configure script is not present
Generating runnable configure script
mkdir: cannot create directory
Hi Thomas , looks good (however I am not a Reviewer) !
> From: Thomas Stüfe
> Date: Wed, Jun 20, 2018 at 10:00 AM
> Subject: RFR(xxs): 8205407: [windows, vs<2017] C4800 after 8203197
> To: build-dev
>
>
> Hi all,
>
> May I please have reviews for this small build fix?
>
>
review !
Thanks, Matthias
> -Original Message-
> From: David Holmes
> Sent: Freitag, 3. August 2018 02:56
> To: Magnus Ihse Bursie ; Baesken,
> Matthias
> Cc: build-dev@openjdk.java.net
> Subject: Re: unneeded -DUSE_MMAP in JDK native libs builds
>
> On 3/0
Hello I noticed that -DUSE_MMAP is set for these JDK native libs, but I
cannot find it in the code (for libzip it is different there the flag shows
up in the code too ) :
Lib-jdk.jdi.gmk :
32 $(eval $(call SetupJdkLibrary, BUILD_LIBDT_SHMEM, \
..
35 CFLAGS := $(CFLAGS_JDKLIB)
Hello , here is a new webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8209115.1/
I set PNG_POWERPC_VSX_OPTnow only on the linux ppc platforms .
Best regards, Matthias
From: Baesken, Matthias
Sent: Donnerstag, 9. August 2018 08:48
To: 'Philip Race'
Cc: 'build-dev@openjdk.java.net
. it has to be
PNG_POWERPC_VSX_OPT not PNG_POWERPC_VSX
☹ - my mistake .
For some reason the current setting still builds on our ppc64 (le) test machine
in the current codebase , strange !
Best regards, Matthias
From: Philip Race
Sent: Donnerstag, 9. August 2018 04:09
To: Baesken, Matthias
on linuxppc64 le .
Webrev/bug :
http://cr.openjdk.java.net/~mbaesken/webrevs/8209115.0/
https://bugs.openjdk.java.net/browse/JDK-8209115
Thanks ,
Matthias
From: Philip Race
Sent: Dienstag, 7. August 2018 17:15
To: Baesken, Matthias
Cc: Doerr, Martin ; 2d-...@openjdk.java.net; Simonis
Thank‘s !
Can I have a second review please ?
Best regards, Matthias
From: Phil Race
Sent: Freitag, 10. August 2018 20:12
To: Baesken, Matthias
Cc: 'build-dev@openjdk.java.net' ;
awt-...@openjdk.java.net
Subject: Re: [RFR]: 8209115: adjust libsplashscreen linux ppc64le builds for
easier
Thanks for the review!
> -Original Message-
> From: David Holmes
> Sent: Montag, 13. August 2018 09:00
> To: Baesken, Matthias ; Phil Race
>
> Cc: awt-...@openjdk.java.net; 'build-dev@openjdk.java.net' d...@openjdk.java.net>
> Subject: Re: [RFR]: 8209115: adju
, I asked our local
Visual Studio experts for help, maybe I overlooked something .
Best regards, Matthias
> --
>
> Message: 4
> Date: Wed, 5 Sep 2018 09:57:06 -0700
> From: Erik Joelsson
> To: "Baesken, Matthias" ,
> &quo
Hello, when compilingjdk/jdk on Windows, (with VS2017 update level 15.8
and not disabling warnings as errors )
I came across this warning leading to build error :
C:/jdk-just-clone/src/hotspot/share/runtime/flags/jvmFlagRangeList.cpp(341):
error C2220: warning treated as error - no
Hello, please review this small fix to repair our AIX build .
Recent changes to jdk/jdk broke the build .
We get clashes with defines from system headers in a few compilation units,
for example :
From: Baesken, Matthias
Sent: Freitag, 6. April 2018 09:54
To: 'Magnus Ihse Bursie' <magnus.ihse.bur...@oracle.com>
Cc: build-dev@openjdk.java.net; Doerr, Martin <martin.do...@sap.com>
Subject: RFR: 8201226 missing JNIEXPORT / JNICALL at some places in function
declarations/imp
/libsplashscreen/splashscreen_impl.h
Where I removed a few declarations (one decl with one without JNIEXPORT
/ JNICALL – looked a bit strange ) .
Best regards , Matthias
From: Magnus Ihse Bursie [mailto:magnus.ihse.bur...@oracle.com]
Sent: Donnerstag, 5. April 2018 17:45
To: Baesken, Matthias
to provide the incorporated patch .
Best regards, Matthias
> -Original Message-
> From: Alexey Ivanov [mailto:alexey.iva...@oracle.com]
> Sent: Montag, 9. April 2018 17:14
> To: Baesken, Matthias <matthias.baes...@sap.com>; Magnus Ihse Bursie
> <magnus.ihse
Hello, we noticed that at a number of places in the coding , the
JNIEXPORT and/or JNICALL modifiers do not match when one compares the
declaration and
The implementation of functions.
While this is ok on most platforms, it seems to fail on Windows 32 bit and
leads to errors like
a...@oracle.com]
> Sent: Mittwoch, 11. April 2018 11:11
> To: Baesken, Matthias <matthias.baes...@sap.com>; Magnus Ihse Bursie
> <magnus.ihse.bur...@oracle.com>
> Cc: build-dev <build-dev@openjdk.java.net>; Doerr, Martin
> <martin.do...@sap.com>
> Subjec
don't mind.
>
Sure .
Best regards, Matthias
> -Original Message-
> From: Alexey Ivanov [mailto:alexey.iva...@oracle.com]
> Sent: Dienstag, 10. April 2018 21:34
> To: Baesken, Matthias <matthias.baes...@sap.com>; Magnus Ihse Bursie
> <magnus.ihse.bur...@oracle.
it .
Best regards , Matthias
> -Original Message-
> From: Baesken, Matthias
> Sent: Mittwoch, 11. April 2018 11:20
> To: 'Alexey Ivanov' <alexey.iva...@oracle.com>; Magnus Ihse Bursie
> <magnus.ihse.bur...@oracle.com>
> Cc: build-dev <build-dev@openjdk.java
a submit job has "arrived" and
is queued for build/test ?
Would have been helpful in this situation .
Best regards, Matthias
> -Original Message-
> From: Christian Tornqvist [mailto:christian.tornqv...@oracle.com]
> Sent: Donnerstag, 12. April 2018 14:58
> To: B
018 15:52
> To: Magnus Ihse Bursie <magnus.ihse.bur...@oracle.com>; Baesken,
> Matthias <matthias.baes...@sap.com>
> Cc: build-dev <build-dev@openjdk.java.net>; Doerr, Martin
> <martin.do...@sap.com>
> Subject: Re: 8201226 missing JNIEXPORT / JNICALL at some p
il 2018 00:14
> To: Magnus Ihse Bursie <magnus.ihse.bur...@oracle.com>; Baesken,
> Matthias <matthias.baes...@sap.com>
> Cc: build-dev <build-dev@openjdk.java.net>; Doerr, Martin
> <martin.do...@sap.com>
> Subject: Re: 8201226 missing JNIEXPORT / JNICALL at some
JNICALL decoration you are refering to .
Best regards, Matthias
> -Original Message-
> From: Magnus Ihse Bursie [mailto:magnus.ihse.bur...@oracle.com]
> Sent: Montag, 9. April 2018 13:29
> To: Baesken, Matthias <matthias.baes...@sap.com>
> Cc: Alexey Ivanov <alexey
ent: Donnerstag, 12. April 2018 23:53
> To: Phil Race <philip.r...@oracle.com>; Baesken, Matthias
> <matthias.baes...@sap.com>; Alan Bateman <alan.bate...@oracle.com>;
> Magnus Ihse Bursie <magnus.ihse.bur...@oracle.com>
> Cc: build-dev@openjdk.java.net; core-li
pril 2018 08:58
> To: Baesken, Matthias <matthias.baes...@sap.com>; 'build-
> d...@openjdk.java.net' <build-dev@openjdk.java.net>
> Cc: serviceability-...@openjdk.java.net; Schmidt, Lutz
> <lutz.schm...@sap.com>
> Subject: Re: INCLUDE_SA/serviceability agent - su
...@oracle.com]
Sent: Montag, 23. April 2018 17:43
To: Baesken, Matthias <matthias.baes...@sap.com>; 'build-dev@openjdk.java.net'
<build-dev@openjdk.java.net>
Cc: serviceability-...@openjdk.java.net; Schmidt, Lutz <lutz.schm...@sap.com>
Subject: Re: INCLUDE_SA/serviceability agent
Hello, as far as I know the serviceability agent is not supported on
linux s390x .
However (unlike on aix where it is not supported as well) ,
INCLUDE_SA=falseis not set in the central configure m4 files .
Should we set it ( suggested diff below) ?
Best regards, Matthias
hg
Hi Thomas , thanks for the review .
Can I have a second review please ?
Best regards, Matthias
From: Thomas Stüfe [mailto:thomas.stu...@gmail.com]
Sent: Montag, 26. März 2018 20:14
To: Baesken, Matthias <matthias.baes...@sap.com>
Cc: build-dev@openjdk.java.net; hotspot-...@openjdk.ja
Thanks Leo .
We have tested the same here locally in our OpenJDK night builds .
Best regards, Matthias
> -Original Message-
> From: Leo Korinth [mailto:leo.kori...@oracle.com]
> Sent: Dienstag, 27. März 2018 14:02
> To: Baesken, Matthias <matthias.baes...@sap.co
Hello, after recent adjustments of
src/hotspot/share/trace/traceEventClasses.xsl
in jdk/hs ( see 8196337: Add commit methods that take all event properties
as argument ) the AIX build fails.
The xlC compiler is not happy with
using TraceEvent::commit;
in traceEventClasses.xsl (looks
Hello , could you please review this small fix for Solaris x86_64 ?
We were running into build errors for unpack200 on Solaris x86_64 because
of missing symbol "environ" .
The patch adds environ to the mapfile .
( seems this is a similar / same problem already solved for Solaris
Hello , could you please review this small adjustment to the symbol
visibility compilation settings on AIX ?
Currently we use XLC 12.1 to compile JDK on AIX .
However XLC 12.1 does not support the "-qvisibility=hidden" setting
currently set on AIX.
It was introduced with XLC 13.1 .
ant to remove the flags .
( waiting for the feedback of Bhaktavatsal Reddy , in case he prefers it I
remove them for all xlC versions including 13.1 )
Best regards, Matthias
From: Langer, Christoph
Sent: Donnerstag, 26. April 2018 16:38
To: Baesken, Matthias <matthias.baes...@sap.
t;
completely for xlc (and not only for xlc12.1) ?
(we currently compile only with XLC 12.1 , there might be more issues
with 13.1 )
Best regards, Matthias
> -Original Message-
> From: Bhaktavatsal R Maram [mailto:bhama...@in.ibm.com]
> Sent: Donnerstag, 26. April 2
Hello ,
please review this small change that fixes our AIX build after “8196341:
Add JFR events for parallel phases of G1”was pushed .
After 8196341 , compile errors occurred, example :
/openjdk/nb/rs6000_64/nightly/jdk/src/hotspot/share/gc/g1/g1CollectedHeap.cpp",
line 3185.15:
removed/guarded
by macros ?
Best regards, Matthias
From: Baesken, Matthias
Sent: Donnerstag, 27. September 2018 14:13
To: 'hotspot-...@openjdk.java.net' ;
'build-dev@openjdk.java.net'
Cc: 'Leo Korinth'
Subject: RFR : 8211213: fix aix build after 8196341: Add JFR events for
parallel phases of G
rstag, 27. September 2018 16:32
> To: Baesken, Matthias ; 'hotspot-
> d...@openjdk.java.net' ; 'build-
> d...@openjdk.java.net'
> Subject: Re: RFR : 8211213: fix aix build after 8196341: Add JFR events for
> parallel phases of G1
>
> Hi,
>
> On Thu, 2018-09-27 at 14:16 +
Hello, I noticed that we currently set flags for gcc to disable warnings.
See
https://hg.openjdk.java.net/jdk/jdk/file/896e80158d35/make/hotspot/lib/CompileJvm.gmk
DISABLED_WARNINGS_gcc := extra parentheses comment unknown-pragmas address \
delete-non-virtual-dtor char-subscripts
hipilev
> Sent: Mittwoch, 31. Oktober 2018 16:49
> To: Baesken, Matthias ; 'build-
> d...@openjdk.java.net'
> Subject: Re: minimal gcc version for jdk/jdk and usage of -Wno-int-in-bool-
> context flag in HS build
>
> On 10/31/2018 04:40 PM, Baesken, Matthias wrote:
Hi Magnus / Erik , thanks for explaning !
Best regards, Matthias
> -Original Message-
> From: Magnus Ihse Bursie
> Sent: Donnerstag, 1. November 2018 11:36
> To: Baesken, Matthias ; Aleksey Shipilev
> ; 'build-dev@openjdk.java.net' d...@openjdk.java.net>
> Sub
Hello, I tried to use bin/idea.sh with Cygwin to generate project files for
IDEA IntelliJ Community .
The project file generation seems to work and outputs the .idea - folder
with lots of xml files in it .
However , when opening the project from IDEA, it fails with a message :
?
Best regards, Matthias
> -Original Message-
> From: Chris Hegarty
> Sent: Donnerstag, 8. November 2018 12:52
> To: Baesken, Matthias ; 'build-
> d...@openjdk.java.net' ;
> maurizio.cimadam...@oracle.com
> Subject: Re: bin/idea.sh and Cygwin
>
>
HI Michal , tested on my Windows 10 machine , works nicely !
Best regards, Matthias
> -Original Message-
> From: Michal Vala
> Sent: Montag, 12. November 2018 05:25
> To: Thomas Stüfe
> Cc: Erik Joelsson ; Baesken, Matthias
> ; Chris Hegarty ;
> build-dev
018 18:05
> To: Baesken, Matthias ; Chris Hegarty
> ; 'build-dev@openjdk.java.net' d...@openjdk.java.net>; maurizio.cimadam...@oracle.com
> Subject: Re: bin/idea.sh and Cygwin
>
> A patch fixing idea.sh so that it works on Windows would certainly be
> welcome.
>
> /Erik
(and your ) patch .
Best regards, Matthias
> -Original Message-
> From: Aleksey Shipilev
> Sent: Donnerstag, 27. September 2018 20:03
> To: Baesken, Matthias ; Thomas Schatzl
> ; 'hotspot-...@openjdk.java.net' d...@openjdk.java.net>; 'build-dev@openjdk.java.net' d..
age-
> From: Erik Joelsson
> Sent: Mittwoch, 10. Oktober 2018 18:08
> To: Baesken, Matthias ; 'build-
> d...@openjdk.java.net'
> Subject: Re: gcc 7.3.1 build - warnings as errors in harfbuzz
>
> I think that's fine. This is the granularity we have.
>
> /Erik
>
>
>
Hello , when compiling jdk/jdk with gcc 7.3.1on linux x86_64 (or
also on linux ppc64) I run into this build error :
/open_jdk/jdk_just_clone/jdk/src/java.desktop/share/native/libfontmanager/harfbuzz/hb-common.cc:
In function 'void hb_variation_to_string(hb_variation_t*, char*,
> Sent: Mittwoch, 10. Oktober 2018 17:33
> To: Baesken, Matthias ; 'build-
> d...@openjdk.java.net'
> Subject: Re: gcc 7.3.1 build - warnings as errors in harfbuzz
>
> In this case, disabling the warning seems like the right thing to do.
>
> /Erik
>
>
> On 20
Thanks , can I have a second review please ?
Best regards, Matthias
From: Lindenmaier, Goetz
Sent: Donnerstag, 30. August 2018 14:17
To: Baesken, Matthias ;
'hotspot-...@openjdk.java.net' ;
'build-dev@openjdk.java.net'
Cc: Doerr, Martin
Subject: RE: RFR : 8210205 : build fails on AIX
Hi Thomas, I think your understanding is correct :
"#ifdef "
or
"#if defined()"
Are ok while
"#if "
or
"#elif "
Lead to the compile error on gcc with current warnings.
Best regards, Matthias
> >>
> > This looks okay to me although I could imagine this issue coming back again
> > with
Hi Martin, the change looks OK (and fixes our AIX build).
(not a Reviewer however)
Best regards, Matthias
>
> Message: 4
> Date: Wed, 26 Sep 2018 13:26:19 +
> From: "Doerr, Martin"
> To: "'build-dev@openjdk.java.net'"
> Subject: RFR(XS): 8211097: aix: fix build after JDK-8210919
>
Thanks for the heads-up, we've seen this one too but noticed that you had
already a bug opened .
Best regards, Matthias
> -Original Message-
> From: Roman Kennke
> Sent: Dienstag, 25. September 2018 17:05
> To: Baesken, Matthias ; 'build-
> d...@openjdk.java.ne
Hello, please review this small build fix .
After the recent changes to the gcc compile flags with 8211029, most
of our Linux builds stopped working .
Error :
=== Output from failing command(s) repeated here ===
* For target support_native_java.base_libnet_DatagramPacket.o:
In file
Hello, it looks like
8211029: Have a common set of enabled warnings for all native libraries
breaks a lot of our Linux based builds.
Our gcc 4.8 misses some of the introduced command line options :
cc1plus: error: unrecognized command line option "-Wno-misleading-indentation"
[-Werror]
1 - 100 of 266 matches
Mail list logo
