Re: JarReorder and ensuing grep failing on Windows

2017-03-08 Thread Brad R. Wetmore
On 3/8/2017 4:50 AM, Erik Joelsson wrote: It looks like you can still get grep 2.27-2 from cygwin. The easiest short term solution is to install that. For the other problem that Erik mentioned, that worked for me. Brad /Erik On 2017-03-08 13:48, Erik Joelsson wrote: Hello again, I

Re: RFR: JDK-8178278 Move Standard Algorithm Names document to specs directory

2017-05-09 Thread Brad R. Wetmore
Can you add similar wording to that effect in DrbgParameters.java? I'm sorry, that instruction is too unclear for me. :-( The main purpose of this patch is to prepare for the markdown based specification, not fixing the entire content. I'll leave modification of the actual documentation to

CR: 8180540: Add pandoc build fix for windows

2017-05-17 Thread Brad R. Wetmore
Magnus, I've added your suggested fix to spec.gmk.in, which is the minor tweak to add @FIXPATH@ to allow pandoc to run on windows builds. https://bugs.openjdk.java.net/browse/JDK-8180540 http://cr.openjdk.java.net/~wetmore/8180540/webrev.00/ I put you down as Contributed-by: with

Re: RFR: XS: URGENT: JDK-8180129, , Bundles.gmk:181: *** unterminated call to function 'filter-out': missing ')'

2017-05-10 Thread Brad R. Wetmore
Looks good. Brad On 5/10/2017 3:06 PM, Tim Bell wrote: A fix for packaging changes in the closed files missed one line continuation in an open file, and without this all builds fail: % hg diff diff --git a/make/Bundles.gmk b/make/Bundles.gmk --- a/make/Bundles.gmk +++ b/make/Bundles.gmk @@

Re: CR: 8180540: Add pandoc build fix for windows

2017-05-18 Thread Brad R. Wetmore
On 5/18/2017 10:10 AM, Brad R. Wetmore wrote: As long as pandoc for windows is always a windows native thing and not provided by cygwin this seems good. A quick googling indicates that cygwin currently does not provide pandoc so should be fine then. You are correct in that pandoc

Re: RFR: JDK-8178278 Move Standard Algorithm Names document to specs directory

2017-05-05 Thread Brad R. Wetmore
I applied the patch to the jdk workspace and verified that all of the instances were updated to {@docRoot}/../specs/security/standard-names.html, and that no links remain to the old StandardNames.html. Sean wrote: > General: change the text of all of the links from "Java Cryptography >