Re: [10]RFR: 8136650: Add support for custom jtreg native tests

2017-03-01 Thread Robbin Ehn
Apparently I wasn't subscribed to build-dev. So here it comes to this list also. On 03/01/2017 04:07 PM, Robbin Ehn wrote: Thanks and thanks for adding the correct mailing list! /Robbin On 03/01/2017 02:01 PM, Erik Joelsson wrote: (adding build-dev) Looks good to me. /Erik On 2017-

Re: C/C++ IDE support for HotSpot

2017-03-24 Thread Robbin Ehn
Hi Mikeal, On 03/22/2017 05:20 PM, Erik Ă–sterlund wrote: Hi Mikael, In my workflow I use emacs with rtags for snytax awareness. With your cmake patch, I could easily generate the cmake files and run cmake with -DCMAKE_EXPORT_COMPILE_COMMANDS to generate the compiler_commands.json file used b

Re: C/C++ IDE support for HotSpot

2017-03-24 Thread Robbin Ehn
Hi, again, On 03/24/2017 08:58 AM, Robbin Ehn wrote: Hi Mikeal, On 03/22/2017 05:20 PM, Erik Ă–sterlund wrote: Hi Mikael, In my workflow I use emacs with rtags for snytax awareness. With your cmake patch, I could easily generate the cmake files and run cmake with

Re: C/C++ IDE support for HotSpot

2017-03-24 Thread Robbin Ehn
Hmmz, brain not functioning. On 03/24/2017 09:02 AM, Robbin Ehn wrote: I have still gotten my morning coffee, this step I have to do anyways of course. NOT /Robbin

Re: (10) (M) RFR: 8174231: Factor out and share PlatformEvent and Parker code for POSIX systems

2017-05-19 Thread Robbin Ehn
Hi David, On 05/18/2017 08:25 AM, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8174231 webrevs: Build-related: http://cr.openjdk.java.net/~dholmes/8174231/webrev.top/ hotspot: http://cr.openjdk.java.net/~dholmes/8174231/webrev.hotspot/ I like this, with neg delta

Re: (10) (M) RFR: 8174231: Factor out and share PlatformEvent and Parker code for POSIX systems

2017-05-19 Thread Robbin Ehn
On 05/19/2017 11:07 AM, David Holmes wrote: They have to be as there are three cases: 1. Relative wait using CLOCK_MONOTONIC 2. Relative wait using gettimeofday() 3. Absolute wait using gettimeofday() Please consider something like: #ifdef SUPPORTS_CLOCK_MONOTONIC if (_use_clock_monotonic

Re: RFR: JDK-8180651: Make target to run tests on exploded image

2017-05-19 Thread Robbin Ehn
Thank you Erik for doing this! /Robbin On 05/19/2017 11:26 AM, Erik Joelsson wrote: In most cases, when running regression tests, you want to run them on the jdk image because that's the correct image and some tests will not work on other variants. However, many tests can be run successfully on

Re: (10) (M) RFR: 8174231: Factor out and share PlatformEvent and Parker code for POSIX systems

2017-05-19 Thread Robbin Ehn
Hi David On 05/19/2017 01:36 PM, David Holmes wrote: There are three different forms of the calculation. The two relative time versions use a different time function and so a different time structure (timeval vs timespec) and a different calculation. Yes that's why I included unit in my exam

Re: RFR: JDK-8180651: Make target to run tests on exploded image

2017-05-19 Thread Robbin Ehn
Hi, On 05/19/2017 12:55 PM, Erik Joelsson wrote: Sure we can pause this. Robbin has a local patch to play with for now. Yes, no rush for me. If you want another name, then we should also rename exploded-image. As I understand it, the name exploded is well established. It refers to the java