Why are assertions in zlib on Unix switched off?

Hi everyone, When building the zlib on Unix platforms, zlib assertions are switched off explicitly using -UDEBUG: 84 ifeq ($(PLATFORM), windows) 87 else 88 CPPFLAGS += -UDEBUG 89 endif This switches off assertions inside the zlib (see zutil.h, zutil,c inside the zlib).

Re: Windows compilation problem

Hi David, Everything before the precompiled header gets ignored, I think. Cheers, Thomas On Dec 9, 2014 10:12 AM, David Holmes david.hol...@oracle.com wrote: This is driving me nuts :) Here's the code from start of file (header excluded): #include utilities/macros.hpp #if INCLUDE_NMT

Re: Fwd: Re: RFR(xxs): 8072935: Fix missing newline at end of file after 8067447

Hi, On Thu, Feb 12, 2015 at 2:27 PM, Volker Simonis volker.simo...@gmail.com wrote: Hi, I don't think we should enforce a minimum Version for GCC (actually we would have to enforce an exact version because the master builds at Oracle are only tested with exactly one compiler version - see

Re: RFR(XS): 8141416: "expr: syntax error" due to gcc -dumpversion excluding micro

Hi Volker, looks fine and builds fine on Ubuntu 14.4. ...Thomas On Wed, Nov 4, 2015 at 7:21 PM, Volker Simonis wrote: > Hi, > > can somebody please review and sponsor the following tiny build fix: > > http://cr.openjdk.java.net/~simonis/webrevs/2015/8141416/ >

Re: RFR (XS): 8141134: Remove unnecessary pragma warning(disable:4355) from GC code

that is where it > makes most sense to me to disable warnings. OTOH, > globalDefinitions_visCPP.hpp already disables quite a few warnings... > > Thanks! Both solutions are fine, I would prefer adding them to globalDefinitions_visCPP.hpp, which already contains a number of other worka

Re: RFR (XS): 8141134: Remove unnecessary pragma warning(disable:4355) from GC code

Hi Eric, your change builds fine on VS 2010. Thank you! Thomas On Wed, Nov 4, 2015 at 4:04 PM, Erik Helin wrote: > On 2015-11-04, Thomas Schatzl wrote: > > Hi, > > > > On Wed, 2015-11-04 at 12:12 +0100, Volker Simonis wrote: > > > Hi Erik, > > > > > > thanks a lot for

Re: RFR: JDK-8145564: 8036003: startup regression on linux fastdebug builds

Hi Eric, short question, are other platforms beside Linux affected or is this Linux-specific (I saw you said Windows x64 showed no regression)? Reason I ask is, we just changed the default for AIX to "internal" because this is the only configuration we support and the build was broken after

Re: RFR(xs): 8145427: [aix] xlc: wrong flag used to switch off optimization

change, and we're going to put > it into hs-rt forest, I will sponsor it for you. > > Thanks, > David > > > On 16/12/2015 3:22 AM, Thomas Stüfe wrote: > >> Hi all, >> >> this fixes a small typo in flags.m4 for AIX-specific compiler flags >> intr

Re: RFR: 8145132: Initial updates for ios x86_64 mobile/dev builds.

Hi Gary, In the Linux os layer - especially in os_linux.cpp - I see you have reintroduced old coding we just painstakingly removed because it was not needed for modern Linuxes anymore. For instance, coding dealing with old Linuxthreads (vs Nptl, which is ubiquitous nowadays) or workarounds for

Re: RFR: 8145132: Initial updates for ios x86_64 mobile/dev builds.

of os_linux* files that > hopefully corrected this. > > Here’s the updated changes that Gary just pushed today. > > http://hg.openjdk.java.net/mobile/dev/hotspot/rev/f1acc8fa34b8 > > > Bob. > > > On Dec 18, 2015, at 4:11 PM, Thomas Stüfe <thomas.stu...@gmail.com> > wrote

javac server: No port file values materialized. on AIX

Hi all, on AIX, I keep getting Server log: --- Server log start --- --- Server log end - [CLIENT] Exception caught: java.io.IOException: No port file values materialized. Giving up after 5375 ms java.io.IOException: No port file values materialized. Giving up after 5375 ms

Re: javac server: No port file values materialized. on AIX

Thanks, Andreas, well, we do have a workaround. I'll wait until you find out more. Have a nice rest-of-vacation! Kind Regards, Thomas On Thu, Jan 14, 2016 at 1:23 PM, Andreas Lundblad < andreas.lundb...@oracle.com> wrote: > On Thu, Jan 14, 2016 at 09:06:56AM +0100, Erik Joelsson wrote: > >

Re: sjavac problems continue

Hi Andreas, On Wed, Feb 24, 2016 at 7:17 PM, Andreas Lundblad < andreas.lundb...@oracle.com> wrote: > On Wed, Feb 24, 2016 at 09:33:55AM +0100, Thomas Stüfe wrote: > > Just to add another small annoyance, it seems that if I build on Windows > in > > cygwin and I cance

Re: sjavac problems continue

Just to add another small annoyance, it seems that if I build on Windows in cygwin and I cancel the build for whatever reason with CTRL+C, the sjavac server hangs and blocks the output directory. It takes some minutes for it to timeout, or I go hunting for the process in Process Explorer. I

Re: RFR: JDK-8147795 Build system support for BSD

Hi Magnus, for what it is worth, I like your effort and think this is valuable. Looking through your changes, it looks like the current BSD support (non-apply) is broken in a number of places and I think if we keep it, we should fix it. Disclaimer: I am neither a "R"eviewer nor a BSD expert.

Re: javac server: No port file values materialized. on AIX

Hi Andreas, thanks! I will use this patch on my AIX builds. I will come back to you if the error resurfaces. Kind Regards, Thoams On Sun, Jan 24, 2016 at 12:33 PM, Andreas Lundblad < andreas.lundb...@oracle.com> wrote: > On Mon, Jan 18, 2016 at 03:39:39PM +0100, Volker Simonis wrote: > > On

Re: RFR(xs): 8153727: AIX jdk build broken after 8145174

Thanks all! On Thu, Apr 7, 2016 at 12:48 PM, Erik Joelsson <erik.joels...@oracle.com> wrote: > Looks good to me. > > /Erik > > > On 2016-04-07 12:40, Thomas Stüfe wrote: > >> Hi Volker, >> >> >> >> On Thu, Apr 7, 2016 at 12:27 PM, Volker

Re: RFR(xs): 8153727: AIX jdk build broken after 8145174

ts. Regards, Thomas > Regards, > Volker > > > > On Thu, Apr 7, 2016 at 12:14 PM, Thomas Stüfe <thomas.stu...@gmail.com> > wrote: > > Hi all, > > > > please review this tiny build fix for AIX. Thank you! > > > > Webrev: > > > http:/

Re: RFR JDK-8173140: To upgrade bundled zlib version from 1.2.8 to 1.2.11

Hi, On Sat, Jan 21, 2017 at 9:30 AM, Erik Joelsson wrote: > Hello, > > Build changes look ok. I'm in favor with dropping the version number from > the path. There is a README that clearly states the current version and we > don't keep multiple versions in the repo

Re: RFR: 8166189: Fix for Bug 8165524 breaks AIX build

On Wed, Sep 28, 2016 at 7:33 PM, Martin Buchholz wrote: > On Wed, Sep 28, 2016 at 9:33 AM, Volker Simonis > wrote: > > > > > I don't think this can be easily done with the current build system. > > Remember for example that even such a sensitive

Re: linux x64: gtest libjvm.so without debug symbols?

et/browse/JDK-8171310 and working on it. > > /Erik > > > > On 2016-12-15 14:37, Erik Joelsson wrote: > >> Hello, >> >> That is a mistake in JDK-8150736. My intention was to always leave debug >> symbols in the gtest libjvm.so untouched. >> >&

Re: RFR: JDK-8171310: Gtest libjvm.so is always stripped

Erik, On Thu, Dec 15, 2016 at 4:01 PM, Erik Joelsson wrote: > Hello, > > Please review this patch, which fixes stripping behavior in the build. In > JDK-8150736 I reworked the general handling of debug symbols. My intention > then was to always leave debug symbols in

Re: linux x64: gtest libjvm.so without debug symbols?

Thank you. On Thu, Dec 15, 2016 at 3:16 PM, Erik Joelsson <erik.joels...@oracle.com> wrote: > That is the intention. > > /Erik > > On 2016-12-15 14:57, Thomas Stüfe wrote: > > Hi Erik, > > great, thank you! > > So, for the gtest libjvm the binary would

RFR(xs): 8171225: [aix] Build gtests on AIX 7.1 with xlC 12

Hi all, please review this small change. It fixes the gtest build on AIX and enables it by default. Note that even though this is a fix for AIX, a cast needed to be added to shared test coding. This is because xlC struggles with certain template expansions and I had to help it by providing an

linux x64: gtest libjvm.so without debug symbols?

Hi, I may be missing something very obvious, but I am not able to debug the gtest-libjvm (the one gtestLauncher uses, from hotspot/variant-server/libjvm). I build with --with-native-debug-symbols=external --with-debug-level=slowdebug. In the build log I see that we preserve the debug

RFR(xxs): 8172579: 8168503 broke AIX build

Dear all, please take a look at this tiny fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8172579 Webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8172579-colon-8168503-broke-AIX-build/webrev/common/autoconf/hotspot.m4.udiff.html JDK-8168503 exposed a bug in AIX grep. AIX grep, when called

Re: RFR(xs): 8172712: configure should check that grep handles empty pattern correctly

Thank you! On Thu, 12 Jan 2017 at 18:30, Mikael Vidstedt <mikael.vidst...@oracle.com> wrote: > > I also ran into this problem a couple of weeks ago with some other > "misbehaving” grep. Thanks for adding this check! > > Cheers, > Mikael > > > On Jan 12, 2017

Re: RFR(xxs): 8172579: 8168503 broke AIX build

de > formatting rules, which require the indentation of wrapped strings. But it > is also quite sensitive and I'm sure this will break again in the future > (in this or in other places). > > By the way, why does it break for 'cds' if it didn't for 'jvmci'? I didn't > knew that we support 'cds'

Re: RFR(xxs): 8172579: 8168503 broke AIX build

On Thu, Jan 12, 2017 at 10:32 AM, Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > On 2017-01-12 09:56, Thomas Stüfe wrote: > > Hi Volker, > > thanks for the hint. GNU grep works, so I close this as wontfix. > > You might want to add a test in configure that

Re: RFR(xs): 8172712: configure should check that grep handles empty pattern correctly

d, I'll sponsor > and push this patch. > > /Magnus > > > On 2017-01-12 14:04, Thomas Stüfe wrote: > > Dear all, > > please take a look at this fix. This should prevent configure from using a > grep which is not able to handle pattern lists with empty patterns. > >

RFR(xs): 8172712: configure should check that grep handles empty pattern correctly

Dear all, please take a look at this fix. This should prevent configure from using a grep which is not able to handle pattern lists with empty patterns. Bug: https://bugs.openjdk.java.net/browse/JDK-8172712 webrevs:

Re: RFR(xs): 8171433: [aix] switch on gtest AIX build

you once the other changes have been > pushed. Or I can push them altogether for you. > > David > > On 19/12/2016 11:26 PM, Thomas Stüfe wrote: > >> Hi all, >> >> Please review this tiny change. >> >> Note that this was already part of the review

Re: RFR(xs): 8171225: [aix] Build gtests on AIX 7.1 with xlC 12

Thanks David! On Dec 19, 2016 21:43, "David Holmes" <david.hol...@oracle.com> wrote: > > > On 18/12/2016 10:13 PM, Thomas Stüfe wrote: > >> HI all, >> >> after investigating I see a number of issues preventing gtest from >> running on A

Re: correct version of the autoconf tools?

. > > /Erik > > > Ah, I had the feeling this was the reason. Difference was between the Ubuntu version of autoconf and a self-built one, both claiming to be 2.69. But the Ubuntu version supported -runstatedir. Thank you for clarifying! ..Thomas > > On 2016-12-19 11:15, Thomas

Re: RFR(xs): 8171225: [aix] Build gtests on AIX 7.1 with xlC 12

Thanks Volker! On Tue, Dec 20, 2016 at 9:11 AM, Volker Simonis <volker.simo...@gmail.com> wrote: > Looks good! > > Volker > > > On Mon, Dec 19, 2016 at 2:33 PM, Thomas Stüfe <thomas.stu...@gmail.com> > wrote: > > > > On Sun, Dec 18, 2016 at 1

Re: RFR(xs): 8171408: [aix] TOC overflow when linking the gtest libjvm.so

; So, could you try removing the filtering and see if it still works? > > /Erik > > > > On 2016-12-18 13:50, Thomas Stüfe wrote: > >> Hi all, >> >> please take a look at this small fix. In short, on AIX when linking the >> gtest version of libjvm.so, th

Re: RFR(xs): 8171225: [aix] Build gtests on AIX 7.1 with xlC 12

I > don't like that we have to build everything with '-qpic=large > -bbigtoc' just because of gtest. > > Isn't it possible to just set these parameters in > hotspot/make/lib/CompileGtest.gmk by using CFLAGS_aix/LDFALGS_aix? > > Thanks, > Volker > > > On Thu, D

Re: RFR(xs): 8171225: [aix] Build gtests on AIX 7.1 with xlC 12

other issues I will fix separately later. http://cr.openjdk.java.net/~stuefe/webrevs/8171225-aix-fix-gtest-assert-compile-error/webrev.01 (Hope the link is correct, the website seems down at the moment). Thank you for reviewing, Thomas On Sun, Dec 18, 2016 at 9:23 AM, Thomas Stüfe <thomas.

Re: RFR(xs): 8171225: [aix] Build gtests on AIX 7.1 with xlC 12

15/12/2016 4:43 PM, Thomas Stüfe wrote: > >> Hi all, >> >> please review this small change. It fixes the gtest build on AIX and >> enables it by default. >> >> Note that even though this is a fix for AIX, a cast needed to be added to >> shared test

RFR(xs): 8171408: [aix] TOC overflow when linking the gtest libjvm.so

Hi all, please take a look at this small fix. In short, on AIX when linking the gtest version of libjvm.so, the TOC overflows. So the gtest libjvm.so must be linked with -bbigtoc, in contrast to the regular libjvm.so, which has no problems and can keep using a small TOC. Also, I compile all

Re: RFR(xs): 8171408: [aix] TOC overflow when linking the gtest libjvm.so

, but the latter should take precedence, so it is ok. Also keeps the makefile simple. Kind Regards, Thomas On Tue, Dec 20, 2016 at 9:21 AM, Thomas Stüfe <thomas.stu...@gmail.com> wrote: > Hi Erik, > > On Tue, Dec 20, 2016 at 9:17 AM, Erik Joelsson <erik.joels...@oracle.com> > wr

correct version of the autoconf tools?

Hi all, What is the correct version of the autoconf tools to use when regenerating generated-configure.sh? I am generating with autoconf 2.69 and get a number of diffs unrelated to my change, among others: + -runstatedir | --runstatedir | --runstatedi | --runstated \ + | --runstate |

Re: RFR(xs): 8171408: [aix] TOC overflow when linking the gtest libjvm.so

Thanks David! On Dec 19, 2016 21:47, "David Holmes" <david.hol...@oracle.com> wrote: > Hi Thomas, > > On 18/12/2016 10:50 PM, Thomas Stüfe wrote: > >> Hi all, >> >> please take a look at this small fix. In short, on AIX when linking the >> gte

Re: RFR(xs): 8171225: [aix] Build gtests on AIX 7.1 with xlC 12

On Sun, Dec 18, 2016 at 1:13 PM, Thomas Stüfe <thomas.stu...@gmail.com> wrote: > HI all, > > after investigating I see a number of issues preventing gtest from running > on AIX, so I decided to get the fix for the wrong assert in the hotspot out > of the way and

Re: correct version of the autoconf tools?

t; Regards, > Volker > > > Thanks, Thomas > On Mon, Dec 19, 2016 at 11:15 AM, Thomas Stüfe <thomas.stu...@gmail.com> > wrote: > > Hi all, > > > > What is the correct version of the autoconf tools to use when > regenerating > > generated-configure.sh

RFR(xs): 8171433: [aix] switch on gtest AIX build

Hi all, Please review this tiny change. Note that this was already part of the review of 8171225. I decided to split that patch into multiple patches. This patch here just switches on building of gtest on AIX by default (it was disabled due to build errors before). Issue:

Re: correct version of the autoconf tools?

Hi David, On Mon, Dec 19, 2016 at 11:35 AM, David Holmes <david.hol...@oracle.com> wrote: > Hi Thomas, > > On 19/12/2016 8:15 PM, Thomas Stüfe wrote: > >> Hi all, >> >> What is the correct version of the autoconf tools to use when regenerating >> gene

Re: RFR(xs): 8171408: [aix] TOC overflow when linking the gtest libjvm.so

On Sun, Dec 18, 2016 at 1:50 PM, Thomas Stüfe <thomas.stu...@gmail.com> wrote: > Hi all, > > please take a look at this small fix. In short, on AIX when linking the > gtest version of libjvm.so, the TOC overflows. > > So the gtest libjvm.so must be linked wi

Re: C/C++ IDE support for HotSpot

> according to https://netbeans.org/downloads/ there is Windows platform > with C/C++ support if I understood you correctly. > > Best regards, > Stanislav Smirnov > > > > > > On 22 Mar 2017, at 20:34, Thomas Stüfe <thomas.stu...@gmail.com> wrote: > > Hi

Re: C/C++ IDE support for HotSpot

Hi Stanislav, last time I checked, there was no support for netbeans on Windows, is that still the case? Thanks, Thomas On Wed, Mar 22, 2017 at 4:02 PM, Stanislav Smirnov < stanislav.smir...@oracle.com> wrote: > Hi Mikael, > > why do not you try NetBeans that has openjdk project support out of

Re: C/C++ IDE support for HotSpot

gt; browsing the code, but it might require some changes to make it build > correctly. If you have a NetBeans / SolarisStudio installation on Windows > and want to make the changes required to add a build configuration for > Windows I'd be happy to sponsor the change. > > Thanks, > /Jesper

Re: [RFR]: Add alpha detection to platform.m4

On Wed, Aug 16, 2017 at 3:07 PM, John Paul Adrian Glaubitz < glaub...@physik.fu-berlin.de> wrote: > Hi! > > On 08/16/2017 06:43 AM, David Holmes wrote: > >> What are you proposing for Alpha and all these other platforms? >> > > They work fine with the Zero port and we have been using Zero on >

windows: sporadic configure errors in cygwin

Hi all, when building OpenJDK 10/hs on Windows, I get sporadic configure errors. Usually one of two things, either: configure: The tested number of bits in the target (0) differs from the number of bits expected to be found in the target (32). or the endianness test failing. Most of the time,

Re: RFR(xs): 8184344: [aix] libjvm.so TOC overflow for slowdebug

Danke Volker! ... So, do I need a sponsor for this or can I push this on my own? Thanks, Thomas On Tue, Jul 18, 2017 at 8:58 AM, Volker Simonis <volker.simo...@gmail.com> wrote: > Looks good! > > Thanks, > Volker > > On Tue, Jul 18, 2017 at 8:30 AM, Thomas Stüfe

Re: RFR(xs): 8184344: [aix] libjvm.so TOC overflow for slowdebug

Hi Volker, new webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8184344-TOC-overflow/webrev.01/webrev/ Only change is the comment, as you suggested. Kind Regards, Thomas On Tue, Jul 18, 2017 at 7:46 AM, Thomas Stüfe <thomas.stu...@gmail.com> wrote: > Thank you Volker! > &g

Re: RFR(xs): 8184344: [aix] libjvm.so TOC overflow for slowdebug

enerated-configure.sh. > Don’t know if this can just be pushed from extern or if it needs some > special handling from Oracle folks or other things to take care of? > > > > Best regards > > Christoph > > > > From: ppc-aix-port-dev [mailto:ppc-aix-port-dev-bo

Re: [PATCH] linux-sparc build fixes

On Wed, Jul 5, 2017 at 7:27 PM, John Paul Adrian Glaubitz < glaub...@physik.fu-berlin.de> wrote: > On 07/05/2017 07:26 PM, Thomas Stüfe wrote: > > Changes look fine to me. I cannot build and test though, do not have a > sparc linux machine. > > We have a fast SPARC T5

Re: [PATCH] linux-sparc build fixes

Hi Adrian, Changes look fine to me. I cannot build and test though, do not have a sparc linux machine. Kind Regards, Thomas On Tue, Jul 4, 2017 at 11:33 AM, John Paul Adrian Glaubitz < glaub...@physik.fu-berlin.de> wrote: > On Wed, Jun 14, 2017 at 01:50:06PM +0200, Erik Helin wrote: > > I

Re: [PATCH] linux-sparc build fixes

On Wed 5. Jul 2017 at 19:39, John Paul Adrian Glaubitz < glaub...@physik.fu-berlin.de> wrote: > On 07/05/2017 07:37 PM, Thomas Stüfe wrote: > > Nah, I believe you :) Changes are trivial enough. > > OK. So we're good to merge then? > > -- > .''`. John Paul Ad

Re: RFR: JDK-8179892 Update build documentation for JDK 9

Hi Magnus, excellent work! Some minor remarks: You also mentioned Cygwin hg in the "Special considerations" section. However, because updating Cygwin is a bit of a pain (you need to close all consoles to do this) it may make sense to move the "Install Cygwin and all required packages" up to the

Re: (10) (M) RFR: 8174231: Factor out and share PlatformEvent and Parker code for POSIX systems

Hi David, Magnus, compiles and works fine on AIX, but as mentioned before off-list to David I see this stdout: configure: No CLOCK_GETTIME_IN_LIBRT configure: No CLOCK_GETTIME_IN_LIBRT Also, the -DSUPPORTS_CLOCK_MONOTONIC appears twice on the command line. Full compile command looks like this:

Re: (10) (M) RFR: 8174231: Factor out and share PlatformEvent and Parker code for POSIX systems

of coding off our (platform specific) backs, which is a good thing! Kind Regards, Thomas On Thu, May 18, 2017 at 4:40 PM, Thomas Stüfe <thomas.stu...@gmail.com> wrote: > Hi David, Magnus, > > compiles and works fine on AIX, but as mentioned before off-list to David > I see this std

RFR: 8189431: Netbeans nb_native project needs to be adapted to new repo structure

Hi all, may I please have a review of this fix. This fixes the nb_native projects and adapts them to the new repo structure (removing old dead hotspot branch etc). It also adds a new windows x64 specific platform. Bug: https://bugs.openjdk.java.net/browse/JDK-8189431 Webrev:

Netbeans nb_native needs adjusting to new jdk10 structure

Hi all, It seems to me make/nb_native project is not yet fully adapted after convesion to the new repo structure? When I open the project, I see all native sources greyed out (in addition to dead links to the old sources which can just be deleted). Is anyone working on this? If not, does anyone

Re: Netbeans nb_native needs adjusting to new jdk10 structure

Hi Magnus, On Thu, Oct 12, 2017 at 1:44 PM, Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > On 2017-10-11 12:13, Thomas Stüfe wrote: > > Hi all, > > It seems to me make/nb_native project is not yet fully adapted after > convesion to the new repo st

Re-using shared object in another unrelated test?

Hi all, I'd am writing a jtreg test which loads a native shared library. I do not actually need to do anything with the shared library, so loading and unloading again. I do not plan on resolving any exports, it just needs to be there and be valid, on all platforms. There are a number of shared

Re: RFR(xs): 8187228: [aix] make data segment page size 64K by default

> > boun...@openjdk.java.net] On Behalf Of Thomas Stüfe > > Sent: Donnerstag, 7. September 2017 12:02 > > To: ppc-aix-port-...@openjdk.java.net; build-dev > d...@openjdk.java.net> > > Subject: RFR(xs): 8187228: [aix] make data segment page size 64K by > default > > &

Re: Re-using shared object in another unrelated test?

On Thu, Sep 7, 2017 at 10:29 AM, David Holmes <david.hol...@oracle.com> wrote: > Hi Thomas, > > On 7/09/2017 6:23 PM, Thomas Stüfe wrote: > >> Hi all, >> >> I'd am writing a jtreg test which loads a native shared library. I do not >> actually need

RFR(xs): 8187228: [aix] make data segment page size 64K by default

Hi all, may I please have a review for the following AIX-only patch. Issue: https://bugs.openjdk.java.net/browse/JDK-8187228 webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8187228-make-data -segment-page-size-64K-by-default/webrev.00/webrev/ It changes the default page size for the data

Re: RFR(xs): 8187228: [aix] make data segment page size 64K by default

Thank you Eric! On Thu, Sep 7, 2017 at 1:07 PM, Erik Joelsson <erik.joels...@oracle.com> wrote: > Looks good. > > /Erik > > > > On 2017-09-07 12:01, Thomas Stüfe wrote: > >> Hi all, >> >> may I please have a review for the following AIX-only patc

Re: windows: sporadic configure errors in cygwin

ks! Thomas > /Erik > > > > On 2017-08-11 13:00, Thomas Stüfe wrote: > >> Hi all, >> >> when building OpenJDK 10/hs on Windows, I get sporadic configure errors. >> Usually one of two things, either: >> >> configure: The tested number of bit

Re: windows: sporadic configure errors in cygwin

Hi Magnus, On Mon, Sep 4, 2017 at 12:09 PM, Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > > On 2017-08-11 13:00, Thomas Stüfe wrote: > >> Hi all, >> >> when building OpenJDK 10/hs on Windows, I get sporadic configure errors. >> Usually one

Re: windows: sporadic configure errors in cygwin

On Mon, Sep 4, 2017 at 3:15 PM, Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > > On 2017-09-04 14:34, Thomas Stüfe wrote: > > Hi Magnus, > > On Mon, Sep 4, 2017 at 12:09 PM, Magnus Ihse Bursie < > magnus.ihse.bur...@oracle.com> wrote: > >>

Re: [RFR]: 8187004: No valid toolchains defined for BSD

On Thu, Aug 31, 2017 at 9:21 AM, David Holmes wrote: > On 31/08/2017 5:08 PM, John Paul Adrian Glaubitz wrote: > >> On 08/31/2017 08:58 AM, Magnus Ihse Bursie wrote: >> >>> BSD is buildable for jdk9 in the separate, hardly-maintained bsd-port >>> only. :-( >>> >> >>

Re: [RFR]: 8187004: No valid toolchains defined for BSD

wrote: > On 31/08/2017 4:14 PM, Thomas Stüfe wrote: > >> Hi Adrian, >> >> this looks fine. Thanks for taking on BSD (I'm a bit confused though, I >> thought BSD is already buildable). >> > > Thomas you beat me to it - on both counts! I too recall others building

Re: [RFR]: 8187004: No valid toolchains defined for BSD

Hi Adrian, this looks fine. Thanks for taking on BSD (I'm a bit confused though, I thought BSD is already buildable). Best Regards, Thomas On Wed, Aug 30, 2017 at 10:30 PM, John Paul Adrian Glaubitz < glaub...@physik.fu-berlin.de> wrote: > Hello! > > I started working on fixing OpenJDK on BSD

Re: RFR(xs): 8187228: [aix] make data segment page size 64K by default

repo. I am unclear whether I am allowed to push this on my own? Does the build group this? Kind Regards, Thomas On Thu, Sep 7, 2017 at 2:33 PM, Thomas Stüfe <thomas.stu...@gmail.com> wrote: > Thank you Goetz! > > On Thu, Sep 7, 2017 at 2:18 PM, Lindenmaier, Goetz < > goet

Re: RFR: 8189431: Netbeans nb_native project needs to be adapted to new repo structure

On Wed, Oct 18, 2017 at 9:50 AM, Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > On 2017-10-17 15:46, Thomas Stüfe wrote: > > Hi all, > > may I please have a review of this fix. This fixes the nb_native projects > and adapts them to the new repo structure (r

Re: RFR(xs): 8187228: [aix] make data segment page size 64K by default

Thank you Eric! On Wed, Oct 18, 2017 at 1:29 PM, Erik Joelsson <erik.joels...@oracle.com> wrote: > I can sponsor the change. > > /Erik > > On 2017-10-18 12:00, Thomas Stüfe wrote: > > Hi Goetz, Eric, > > I was unable to commit this patch before the jdk10 repo con

Re: AIX build not generating a jre image

On Wed, Oct 18, 2017 at 3:25 PM, Volker Simonis wrote: > Hi Goetz, > > How do our nightly builds look like? Do they create the JRE image? > > Regards, > Volker > > Goetz is in a meeting. None of our AIX builds creates a JRE image. Works on other platforms. Looks like a

8189619: [aix, but changes generated-configure.sh] OpenJDK local disk check not working on AIX

Hi all, May I have a review please for this tiny fix. Fixes the warning checking if we build on a local disk. Bug: https://bugs.openjdk.java.net/browse/JDK-8189619 Webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8189619-openjdk-local-disk-check-broken-on-aix/webrev.00/webrev/ Basically, df

Re: Building OpenJDK9 on MSYS2

ons are met to migrate to the base line? > But this is likely a huge undertaking, the prelimininary results showed > multiple tier1 failures, which indicates (I believe) subtle issues in the > compiled hotspot code. > > I agree this looks huge. > /Magnus > ..Thomas > >

Re: Building OpenJDK9 on MSYS2

> > It is not my place to advice you or to decide anything. People from the build group would have to decide whether we want to add support for msys2+gcc and whether we want to support it. ..Thomas > > Peter > > > -- > *From:* Thomas Stüfe

Re: zero build slow

On Thu, Nov 23, 2017 at 10:42 AM, Severin Gehwolf <sgehw...@redhat.com> wrote: > Hi Thomas, > > On Wed, 2017-11-22 at 17:26 +0100, Thomas Stüfe wrote: > > Hi guys, > > > > thanks for your help. > > > > I think the reason is the combination of zero+s

Re: RFR: JDK-8191205 Set native-debug-symbols default to "external"

Looks good. Thanks for doing this! ..Thomas On Wed, Nov 22, 2017 at 3:01 PM, Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > We should not have "zipped" as default for native-debug-symbols. In the > future, this option should probably be dropped completely, but for now, > start by

zero build slow

Hi all, when building zero on Linux x64, I notice that the build is extremely slow, due to what I assume is jmod ran from the built image, which would only run interpreted? Is my guess true, and if yes, is it possible to use a different jmod? I assume it is not possible to use jmod from the build

Re: zero build slow

is crashy - currently, the build does not go thru in this case. I will retry with fastdebug to see how much faster this is. Thanks, Thomas On Wed, Nov 22, 2017 at 4:40 PM, John Paul Adrian Glaubitz < glaub...@physik.fu-berlin.de> wrote: > Hi Thomas! > > On 11/22/2017 04:29 PM, Thom

Re: zero build slow

On Wed, Nov 22, 2017 at 4:40 PM, Andrew Haley <a...@redhat.com> wrote: > On 22/11/17 15:29, Thomas Stüfe wrote: > > when building zero on Linux x64, I notice that the build is extremely > slow, > > due to what I assume is jmod ran from the built image, which would on

Re: zero build slow

On Wed, Nov 22, 2017 at 6:09 PM, Erik Joelsson <erik.joels...@oracle.com> wrote: > Hello, > > On 2017-11-22 08:30, Thomas Stüfe wrote: > >> On Wed, Nov 22, 2017 at 4:40 PM, Andrew Haley <a...@redhat.com> wrote: >> >> On 22/11/17 15:29, Thomas Stüfe wrote

Re: Building OpenJDK9 on MSYS2

On Thu, Nov 23, 2017 at 12:40 AM, Lussier, Denis wrote: > This is good stuff. Back in 2010 I got OpenJDK compiled and running on the > Microsoft Toolchain. I never ran the jtreg tests, but, the binaries > worked for running basic Tomcat but definitely not for trying to run

Re: Default value for -with_native_debug_symbols on Windows useful?

On Fri, Nov 10, 2017 at 3:50 PM, Erik Helin <erik.he...@oracle.com> wrote: > On 11/10/2017 09:01 AM, Thomas Stüfe wrote: > >> Hi Erik, >> >> On Fri, Nov 10, 2017 at 12:52 AM, Erik Joelsson <erik.joels...@oracle.com >> > >> wrote: >> >

Re: Default value for -with_native_debug_symbols on Windows useful?

Thanks Markus! On Tue, Nov 14, 2017 at 1:30 PM, Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > > On 2017-11-10 15:50, Erik Helin wrote: > >> On 11/10/2017 09:01 AM, Thomas Stüfe wrote: >> >>> Hi Erik, >>> >>> On Fri, No

Re: Default value for -with_native_debug_symbols on Windows useful?

nd should be > removed. > > /Erik > > > On 2017-11-08 22:32, Thomas Stüfe wrote: > > Hi all, > > > > I could reframe the subject matter as "how do you internally at Oracle > > build the Windows JDK"? > > > > I had several discussio

Re: Default value for -with_native_debug_symbols on Windows useful?

Hi Erik, On Fri, Nov 10, 2017 at 12:52 AM, Erik Joelsson <erik.joels...@oracle.com> wrote: > Hello, > > On 2017-11-09 15:26, Thomas Stüfe wrote: > > Do you think this for all platforms or just for Windows? With removed, do > you really mean the feature removed, not

Default value for -with_native_debug_symbols on Windows useful?

Hi all, I could reframe the subject matter as "how do you internally at Oracle build the Windows JDK"? I had several discussions with people from Oracle about missing callstacks in hs-err files on Windows generated in tests which run at Oracle. I recently did JDK-8185712, which improves the

Re: RFR: 8189618: [aix] No jre image is created during images step - was : RE: AIX build not generating a jre image

> From: Magnus Ihse Bursie [mailto:magnus.ihse.bur...@oracle.com] > > Sent: Mittwoch, 25. Oktober 2017 16:46 > > To: Erik Joelsson <erik.joels...@oracle.com>; Baesken, Matthias > > <matthias.baes...@sap.com>; Thomas Stüfe <thomas.stu...@gmail.com> >

Re: RFR: 8189618: [aix] No jre image is created during images step - was : RE: AIX build not generating a jre image

(I'll push it) On Thu, Oct 26, 2017 at 9:39 AM, Thomas Stüfe <thomas.stu...@gmail.com> wrote: > Hi Matthias, > > good job, thanks (and thanks to Magnus)! > > Just tried it, works. > > Change looks good. > > ..Thomas > > > On Thu, Oct 26, 2017 at 9:

Re: Windows: problem with msvxxx.dll locations containing spaces

Hi Erik, since your proposal worked, will you do a fix? Thanks, Thomas On Fri, May 4, 2018 at 8:30 AM, Thomas Stüfe <thomas.stu...@gmail.com> wrote: > Hi Erik, > > that worked on both machines for all builds. > > Thanks, Thomas > > On Thu, May 3, 2018 at 10:13 PM

Re: Windows: problem with msvxxx.dll locations containing spaces

Great, thanks! On Mon, May 7, 2018 at 5:41 PM, Erik Joelsson <erik.joels...@oracle.com> wrote: > Yes, sure, I'm working on a different fix in the same area now anyway so can > sneak this fix in there. Will get done this week. > > /Erik > > > > On 2018-05-07 07:37

Re: Build failure on Fedora 28

ild logs to find the crashing vm call. Maybe it is just a matter of preference. I know some people actually prefer the crashes during the build since they consider the build to be a good first-line stress test. Thanks, Thomas > > Thanks, > > Yasumasa > > > 2018-05-09 14:36 GM

  1   2   3   >