Re: RFR [xxs, aix]: JDK-8196488: [aix] TOC overflow for libjvm.so in fastdebug build
On Mon, Feb 12, 2018 at 4:41 PM, Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > On 2018-02-12 15:32, Thomas Stüfe wrote: > >> Hi all, >> >> may I have a sponsor please? I am not sure whether I am allowed to push >> myself, and if yes, to which repository. >> > > Since the removal of generated-configure.sh you don't need a sponsor just > because you touch autoconf files. So for jdk/jdk, you're free to just push > it. As far as I understand, you're also free to just push it to jdk/hs > nowadays, if that were you want it to go, but someone from hotspot should > probably confirm this. > > Ok. Nice to know. Thanks. ..Thomas > /Magnus > > > >> I have three reviewers already. >> >> Thank you! >> >> Thomas >> >> >> On Thu, Feb 8, 2018 at 3:42 PM, Thomas Stüfe >> wrote: >> >> Hi, >>> >>> may I please have reviews for this tiny fix: >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8196488 >>> webrev: http://cr.openjdk.java.net/~stuefe/webrevs/ >>> 8196488-aix-toc-overflow-in-fastdebug/webrev.00/webrev/ >>> >>> Thanks and Kind Regards, Thomas >>> >>> >
Re: RFR [xxs, aix]: JDK-8196488: [aix] TOC overflow for libjvm.so in fastdebug build
On 2018-02-12 15:32, Thomas Stüfe wrote: Hi all, may I have a sponsor please? I am not sure whether I am allowed to push myself, and if yes, to which repository. Since the removal of generated-configure.sh you don't need a sponsor just because you touch autoconf files. So for jdk/jdk, you're free to just push it. As far as I understand, you're also free to just push it to jdk/hs nowadays, if that were you want it to go, but someone from hotspot should probably confirm this. /Magnus I have three reviewers already. Thank you! Thomas On Thu, Feb 8, 2018 at 3:42 PM, Thomas Stüfe wrote: Hi, may I please have reviews for this tiny fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8196488 webrev: http://cr.openjdk.java.net/~stuefe/webrevs/ 8196488-aix-toc-overflow-in-fastdebug/webrev.00/webrev/ Thanks and Kind Regards, Thomas
Re: RFR [xxs, aix]: JDK-8196488: [aix] TOC overflow for libjvm.so in fastdebug build
Please disregard my last mail, the change has just been pushed. Thanks, Thomas On Mon, Feb 12, 2018 at 3:32 PM, Thomas Stüfe wrote: > Hi all, > > may I have a sponsor please? I am not sure whether I am allowed to push > myself, and if yes, to which repository. > > I have three reviewers already. > > Thank you! > > Thomas > > > On Thu, Feb 8, 2018 at 3:42 PM, Thomas Stüfe > wrote: > >> Hi, >> >> may I please have reviews for this tiny fix: >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8196488 >> webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8196488- >> aix-toc-overflow-in-fastdebug/webrev.00/webrev/ >> >> Thanks and Kind Regards, Thomas >> > >
Re: RFR [xxs, aix]: JDK-8196488: [aix] TOC overflow for libjvm.so in fastdebug build
Hi all, may I have a sponsor please? I am not sure whether I am allowed to push myself, and if yes, to which repository. I have three reviewers already. Thank you! Thomas On Thu, Feb 8, 2018 at 3:42 PM, Thomas Stüfe wrote: > Hi, > > may I please have reviews for this tiny fix: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8196488 > webrev: http://cr.openjdk.java.net/~stuefe/webrevs/ > 8196488-aix-toc-overflow-in-fastdebug/webrev.00/webrev/ > > Thanks and Kind Regards, Thomas >
Re: RFR [xxs, aix]: JDK-8196488: [aix] TOC overflow for libjvm.so in fastdebug build
Thanks! On Thu, Feb 8, 2018 at 3:49 PM, Lindenmaier, Goetz < goetz.lindenma...@sap.com> wrote: > HI Thomas, > > looks good, thanks! > > Best regards, > Goetz. > > > -Original Message- > > From: ppc-aix-port-dev [mailto:ppc-aix-port-dev- > > boun...@openjdk.java.net] On Behalf Of Thomas Stüfe > > Sent: Donnerstag, 8. Februar 2018 15:42 > > To: ppc-aix-port-...@openjdk.java.net; build-dev > d...@openjdk.java.net> > > Subject: RFR [xxs, aix]: JDK-8196488: [aix] TOC overflow for libjvm.so in > > fastdebug build > > > > Hi, > > > > may I please have reviews for this tiny fix: > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8196488 > > webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8196488-aix-toc- > > overflow-in-fastdebug/webrev.00/webrev/ > > > > Thanks and Kind Regards, Thomas >
Re: RFR [xxs, aix]: JDK-8196488: [aix] TOC overflow for libjvm.so in fastdebug build
Thanks Matthias! On Thu, Feb 8, 2018 at 3:58 PM, Baesken, Matthias wrote: > Hi Thomas , looks good to me( not a Reviever however). > > > > Best Regards, Matthias > > > > *From:* ppc-aix-port-dev [mailto:ppc-aix-port-dev-boun...@openjdk.java.net] > *On Behalf Of *Thomas Stüfe > *Sent:* Donnerstag, 8. Februar 2018 15:42 > *To:* ppc-aix-port-...@openjdk.java.net; build-dev < > build-dev@openjdk.java.net> > *Subject:* RFR [xxs, aix]: JDK-8196488: [aix] TOC overflow for libjvm.so > in fastdebug build > > > > Hi, > > > > may I please have reviews for this tiny fix: > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8196488 > > webrev: http://cr.openjdk.java.net/~stuefe/webrevs/ > 8196488-aix-toc-overflow-in-fastdebug/webrev.00/webrev/ > > > > Thanks and Kind Regards, Thomas >
Re: RFR [xxs, aix]: JDK-8196488: [aix] TOC overflow for libjvm.so in fastdebug build
Hi Eric, On Thu, Feb 8, 2018 at 6:09 PM, Erik Joelsson wrote: > Looks good, happy pushing without a sponsor! > > /Erik > > Yes please, that would be nice! ..Thomas > > > On 2018-02-08 06:42, Thomas Stüfe wrote: > >> Hi, >> >> may I please have reviews for this tiny fix: >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8196488 >> webrev: >> http://cr.openjdk.java.net/~stuefe/webrevs/8196488-aix-toc- >> overflow-in-fastdebug/webrev.00/webrev/ >> >> Thanks and Kind Regards, Thomas >> > >
Re: RFR [xxs, aix]: JDK-8196488: [aix] TOC overflow for libjvm.so in fastdebug build
Looks good, happy pushing without a sponsor! /Erik On 2018-02-08 06:42, Thomas Stüfe wrote: Hi, may I please have reviews for this tiny fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8196488 webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8196488-aix-toc-overflow-in-fastdebug/webrev.00/webrev/ Thanks and Kind Regards, Thomas
RE: RFR [xxs, aix]: JDK-8196488: [aix] TOC overflow for libjvm.so in fastdebug build
Hi Thomas , looks good to me( not a Reviever however). Best Regards, Matthias From: ppc-aix-port-dev [mailto:ppc-aix-port-dev-boun...@openjdk.java.net] On Behalf Of Thomas Stüfe Sent: Donnerstag, 8. Februar 2018 15:42 To: ppc-aix-port-...@openjdk.java.net; build-dev Subject: RFR [xxs, aix]: JDK-8196488: [aix] TOC overflow for libjvm.so in fastdebug build Hi, may I please have reviews for this tiny fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8196488 webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8196488-aix-toc-overflow-in-fastdebug/webrev.00/webrev/ Thanks and Kind Regards, Thomas
RE: RFR [xxs, aix]: JDK-8196488: [aix] TOC overflow for libjvm.so in fastdebug build
HI Thomas, looks good, thanks! Best regards, Goetz. > -Original Message- > From: ppc-aix-port-dev [mailto:ppc-aix-port-dev- > boun...@openjdk.java.net] On Behalf Of Thomas Stüfe > Sent: Donnerstag, 8. Februar 2018 15:42 > To: ppc-aix-port-...@openjdk.java.net; build-dev d...@openjdk.java.net> > Subject: RFR [xxs, aix]: JDK-8196488: [aix] TOC overflow for libjvm.so in > fastdebug build > > Hi, > > may I please have reviews for this tiny fix: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8196488 > webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8196488-aix-toc- > overflow-in-fastdebug/webrev.00/webrev/ > > Thanks and Kind Regards, Thomas