Re: RFR: JDK-8197571 Change storage location for generated-configure.sh

2018-02-12 Thread Thomas Stüfe
On Mon, Feb 12, 2018 at 4:38 PM, Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > > On 2018-02-12 14:57, Thomas Stüfe wrote: > > > > On Mon, Feb 12, 2018 at 2:53 PM, Magnus Ihse Bursie < > magnus.ihse.bur...@oracle.com> wrote: > >> On 2018-02-12 14:47, Thomas Stüfe wrote: >> >> Hi Magn

Re: RFR: JDK-8197571 Change storage location for generated-configure.sh

2018-02-12 Thread Magnus Ihse Bursie
On 2018-02-12 14:57, Thomas Stüfe wrote: On Mon, Feb 12, 2018 at 2:53 PM, Magnus Ihse Bursie mailto:magnus.ihse.bur...@oracle.com>> wrote: On 2018-02-12 14:47, Thomas Stüfe wrote: Hi Magnus, Thanks a lot for fixing this! I tried my configuration as described in earlier ma

Re: RFR: JDK-8197571 Change storage location for generated-configure.sh

2018-02-12 Thread Tim Bell
Magnus: Looks good to me as well. /Tim On 02/12/18 06:31, Volker Simonis wrote: Hi Magnus, thanks for doing this change. It was actually on my TODO list but I somehow forgot about it :) The change looks good. Thumb up from me, Volker On Mon, Feb 12, 2018 at 2:09 PM, Magnus Ihse Bursie wrot

Re: RFR: JDK-8197571 Change storage location for generated-configure.sh

2018-02-12 Thread Volker Simonis
Hi Magnus, thanks for doing this change. It was actually on my TODO list but I somehow forgot about it :) The change looks good. Thumb up from me, Volker On Mon, Feb 12, 2018 at 2:09 PM, Magnus Ihse Bursie wrote: > In JDK-8195689, the generated-configure.sh was no longer checked in, but > local

Re: RFR: JDK-8197571 Change storage location for generated-configure.sh

2018-02-12 Thread Thomas Stüfe
On Mon, Feb 12, 2018 at 2:53 PM, Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > On 2018-02-12 14:47, Thomas Stüfe wrote: > > Hi Magnus, > > Thanks a lot for fixing this! I tried my configuration as described in > earlier mails, and the configure scripts gets now created in the output

Re: RFR: JDK-8197571 Change storage location for generated-configure.sh

2018-02-12 Thread Magnus Ihse Bursie
On 2018-02-12 14:47, Thomas Stüfe wrote: Hi Magnus, Thanks a lot for fixing this! I tried my configuration as described in earlier mails, and the configure scripts gets now created in the output directory as expected. Some notes: - would it be possible to write out the path name of the gene

Re: RFR: JDK-8197571 Change storage location for generated-configure.sh

2018-02-12 Thread Thomas Stüfe
Hi Magnus, Thanks a lot for fixing this! I tried my configuration as described in earlier mails, and the configure scripts gets now created in the output directory as expected. Some notes: - would it be possible to write out the path name of the generated configure shell script? - No concern of

RFR: JDK-8197571 Change storage location for generated-configure.sh

2018-02-12 Thread Magnus Ihse Bursie
In JDK-8195689, the generated-configure.sh was no longer checked in, but locally generated. The selected location for generation ($TOPDIR/.build) was not unproblematic for some use cases. This patch attempts remedy this. The new behaviour will be this:  * If run from $TOPDIR, the storage direct