Re: RFR: JDK-8198627 JDK-8198318 broke readlink testing

2018-02-26 Thread Magnus Ihse Bursie
I apologize for the extra work my mistake caused you. :( /Magnus > 23 feb. 2018 kl. 16:19 skrev Volker Simonis : > > Good patch, Magnus! > > We've been affected by this as well but instead of digging deeper into > the problem we've installed "readlink" on our AIX build machines, > where it wasn

Re: RFR: JDK-8198627 JDK-8198318 broke readlink testing

2018-02-23 Thread Phil Race
+1 . This fixed it for me when I tried it yesterday. -phil. On 02/23/2018 06:52 AM, Erik Joelsson wrote: Looks good and thanks for picking this up! I never got around to it yesterday. /Erik On 2018-02-23 05:24, Magnus Ihse Bursie wrote: The if line introduced in JDK-8198318 is missing a "

Re: RFR: JDK-8198627 JDK-8198318 broke readlink testing

2018-02-23 Thread Volker Simonis
Good patch, Magnus! We've been affected by this as well but instead of digging deeper into the problem we've installed "readlink" on our AIX build machines, where it wasn't available until now. Good to know that "readlink" is still not a mandatory requirement for the build :) On Fri, Feb 23, 201

Re: RFR: JDK-8198627 JDK-8198318 broke readlink testing

2018-02-23 Thread Tim Bell
Magnus- Looks good to me as well. Thanks- /Tim On 02/23/18 06:52, Erik Joelsson wrote: Looks good and thanks for picking this up! I never got around to it yesterday. /Erik On 2018-02-23 05:24, Magnus Ihse Bursie wrote: The if line introduced in JDK-8198318 is missing a "test". Thanks to J

Re: RFR: JDK-8198627 JDK-8198318 broke readlink testing

2018-02-23 Thread Erik Joelsson
Looks good and thanks for picking this up! I never got around to it yesterday. /Erik On 2018-02-23 05:24, Magnus Ihse Bursie wrote: The if line introduced in JDK-8198318 is missing a "test". Thanks to Jon and Erik for discovering the problem and the solution. Bug: https://bugs.openjdk.java.n

RFR: JDK-8198627 JDK-8198318 broke readlink testing

2018-02-23 Thread Magnus Ihse Bursie
The if line introduced in JDK-8198318 is missing a "test". Thanks to Jon and Erik for discovering the problem and the solution. Bug: https://bugs.openjdk.java.net/browse/JDK-8198627 Patch inline: diff --git a/make/autoconf/basics.m4 b/make/autoconf/basics.m4 --- a/make/autoconf/basics.m4 +++ b/m