Re: RFR: JDK-8199224 Refactor add_native_source in SetupNativeCompilation

2018-03-07 Thread Erik Joelsson
Looks good. Nice cleanup! /Erik On 2018-03-07 06:02, Magnus Ihse Bursie wrote: The function add_native_source has been with us since the original version of the build-infra system. It needs to be adapted to modern standards, and to have the flag setting unified so it happens in only one plac

RFR: JDK-8199224 Refactor add_native_source in SetupNativeCompilation

2018-03-07 Thread Magnus Ihse Bursie
The function add_native_source has been with us since the original version of the build-infra system. It needs to be adapted to modern standards, and to have the flag setting unified so it happens in only one place. I have verified using BUILD_COMPARE that this does not affect the generated o