Re: (11) RFR (S) JDK-8198312: VS2017: Upgrade HOTSPOT_BUILD_COMPILER in vm_version.cpp

2018-02-23 Thread Erik Joelsson

Looks good!

/Erik


On 2018-02-23 11:39, Lois Foltan wrote:

On 2/23/2018 2:31 PM, Erik Joelsson wrote:


On 2018-02-23 11:16, Lois Foltan wrote:

On 2/23/2018 1:05 PM, Erik Joelsson wrote:


Hello Lois,

This looks good, but I would suggest to also add 1900 for VS2015, 
for completeness.
Thanks for the review Erik!  I have updated the webrev to add 1900, 
however, I couldn't find a release # for VS2015, since all 
documentation I could find seemed to indicated that only 2015 and 
updates 1-3 were released.  If you have more info on this let me know!


My installation of 2015 was put in "Microsoft Visual Studio 14.0" 
following the pattern of previous versions (12.0, 11.0, 10.0 etc), so 
I think that would be the appropriate number here. Otherwise I think 
this looks good.


Got it, hopefully final webrev at 
http://cr.openjdk.java.net/~lfoltan/bug_jdk8198312.2/webrev/

Thanks again!
Lois



/Erik

http://cr.openjdk.java.net/~lfoltan/bug_jdk8198312.1/webrev/

Thanks,
Lois



/Erik


On 2018-02-23 09:54, Lois Foltan wrote:
Please review this small fix to set HOTSPOT_BUILD_COMPILER 
correctly for VS2017.


open webrev at 
http://cr.openjdk.java.net/~lfoltan/bug_jdk8198312/webrev/

bug link https://bugs.openjdk.java.net/browse/JDK-8198312

Testing: hs-tier(1-3), jdk-tier(1-3) complete

Thanks,
Lois













Re: (11) RFR (S) JDK-8198312: VS2017: Upgrade HOTSPOT_BUILD_COMPILER in vm_version.cpp

2018-02-23 Thread Lois Foltan

On 2/23/2018 2:31 PM, Erik Joelsson wrote:


On 2018-02-23 11:16, Lois Foltan wrote:

On 2/23/2018 1:05 PM, Erik Joelsson wrote:


Hello Lois,

This looks good, but I would suggest to also add 1900 for VS2015, 
for completeness.
Thanks for the review Erik!  I have updated the webrev to add 1900, 
however, I couldn't find a release # for VS2015, since all 
documentation I could find seemed to indicated that only 2015 and 
updates 1-3 were released.  If you have more info on this let me know!


My installation of 2015 was put in "Microsoft Visual Studio 14.0" 
following the pattern of previous versions (12.0, 11.0, 10.0 etc), so 
I think that would be the appropriate number here. Otherwise I think 
this looks good.


Got it, hopefully final webrev at 
http://cr.openjdk.java.net/~lfoltan/bug_jdk8198312.2/webrev/

Thanks again!
Lois



/Erik

http://cr.openjdk.java.net/~lfoltan/bug_jdk8198312.1/webrev/

Thanks,
Lois



/Erik


On 2018-02-23 09:54, Lois Foltan wrote:
Please review this small fix to set HOTSPOT_BUILD_COMPILER 
correctly for VS2017.


open webrev at 
http://cr.openjdk.java.net/~lfoltan/bug_jdk8198312/webrev/

bug link https://bugs.openjdk.java.net/browse/JDK-8198312

Testing: hs-tier(1-3), jdk-tier(1-3) complete

Thanks,
Lois











Re: (11) RFR (S) JDK-8198312: VS2017: Upgrade HOTSPOT_BUILD_COMPILER in vm_version.cpp

2018-02-23 Thread Lois Foltan

Thanks again for the review Erik!
Lois

On 2/23/2018 2:44 PM, Erik Joelsson wrote:


Looks good!

/Erik


On 2018-02-23 11:39, Lois Foltan wrote:

On 2/23/2018 2:31 PM, Erik Joelsson wrote:


On 2018-02-23 11:16, Lois Foltan wrote:

On 2/23/2018 1:05 PM, Erik Joelsson wrote:


Hello Lois,

This looks good, but I would suggest to also add 1900 for VS2015, 
for completeness.
Thanks for the review Erik!  I have updated the webrev to add 1900, 
however, I couldn't find a release # for VS2015, since all 
documentation I could find seemed to indicated that only 2015 and 
updates 1-3 were released.  If you have more info on this let me know!


My installation of 2015 was put in "Microsoft Visual Studio 14.0" 
following the pattern of previous versions (12.0, 11.0, 10.0 etc), 
so I think that would be the appropriate number here. Otherwise I 
think this looks good.


Got it, hopefully final webrev at 
http://cr.openjdk.java.net/~lfoltan/bug_jdk8198312.2/webrev/

Thanks again!
Lois



/Erik

http://cr.openjdk.java.net/~lfoltan/bug_jdk8198312.1/webrev/

Thanks,
Lois



/Erik


On 2018-02-23 09:54, Lois Foltan wrote:
Please review this small fix to set HOTSPOT_BUILD_COMPILER 
correctly for VS2017.


open webrev at 
http://cr.openjdk.java.net/~lfoltan/bug_jdk8198312/webrev/

bug link https://bugs.openjdk.java.net/browse/JDK-8198312

Testing: hs-tier(1-3), jdk-tier(1-3) complete

Thanks,
Lois















Re: (11) RFR (S) JDK-8198312: VS2017: Upgrade HOTSPOT_BUILD_COMPILER in vm_version.cpp

2018-02-23 Thread Erik Joelsson

On 2018-02-23 11:16, Lois Foltan wrote:

On 2/23/2018 1:05 PM, Erik Joelsson wrote:


Hello Lois,

This looks good, but I would suggest to also add 1900 for VS2015, for 
completeness.
Thanks for the review Erik!  I have updated the webrev to add 1900, 
however, I couldn't find a release # for VS2015, since all 
documentation I could find seemed to indicated that only 2015 and 
updates 1-3 were released.  If you have more info on this let me know!


My installation of 2015 was put in "Microsoft Visual Studio 14.0" 
following the pattern of previous versions (12.0, 11.0, 10.0 etc), so I 
think that would be the appropriate number here. Otherwise I think this 
looks good.


/Erik

http://cr.openjdk.java.net/~lfoltan/bug_jdk8198312.1/webrev/

Thanks,
Lois



/Erik


On 2018-02-23 09:54, Lois Foltan wrote:
Please review this small fix to set HOTSPOT_BUILD_COMPILER correctly 
for VS2017.


open webrev at 
http://cr.openjdk.java.net/~lfoltan/bug_jdk8198312/webrev/

bug link https://bugs.openjdk.java.net/browse/JDK-8198312

Testing: hs-tier(1-3), jdk-tier(1-3) complete

Thanks,
Lois









Re: (11) RFR (S) JDK-8198312: VS2017: Upgrade HOTSPOT_BUILD_COMPILER in vm_version.cpp

2018-02-23 Thread Lois Foltan

On 2/23/2018 1:05 PM, Erik Joelsson wrote:


Hello Lois,

This looks good, but I would suggest to also add 1900 for VS2015, for 
completeness.
Thanks for the review Erik!  I have updated the webrev to add 1900, 
however, I couldn't find a release # for VS2015, since all documentation 
I could find seemed to indicated that only 2015 and updates 1-3 were 
released.  If you have more info on this let me know!


http://cr.openjdk.java.net/~lfoltan/bug_jdk8198312.1/webrev/

Thanks,
Lois



/Erik


On 2018-02-23 09:54, Lois Foltan wrote:
Please review this small fix to set HOTSPOT_BUILD_COMPILER correctly 
for VS2017.


open webrev at 
http://cr.openjdk.java.net/~lfoltan/bug_jdk8198312/webrev/

bug link https://bugs.openjdk.java.net/browse/JDK-8198312

Testing: hs-tier(1-3), jdk-tier(1-3) complete

Thanks,
Lois







Re: (11) RFR (S) JDK-8198312: VS2017: Upgrade HOTSPOT_BUILD_COMPILER in vm_version.cpp

2018-02-23 Thread Erik Joelsson

Hello Lois,

This looks good, but I would suggest to also add 1900 for VS2015, for 
completeness.


/Erik


On 2018-02-23 09:54, Lois Foltan wrote:
Please review this small fix to set HOTSPOT_BUILD_COMPILER correctly 
for VS2017.


open webrev at http://cr.openjdk.java.net/~lfoltan/bug_jdk8198312/webrev/
bug link https://bugs.openjdk.java.net/browse/JDK-8198312

Testing: hs-tier(1-3), jdk-tier(1-3) complete

Thanks,
Lois