Re: [11] RFR (XXS): 8206903: Unable to build Client VM with JVMCI

2018-07-12 Thread Erik Joelsson

Sure I can push it for you.

/Erik


On 2018-07-12 03:59, Aleksei Voitylov wrote:

Erik, Vladimir,

thank you for review. Could either of you sponsor the change?

-Aleksei


On 11/07/2018 19:30, Vladimir Kozlov wrote:

+1

Vladimir

On 7/11/18 9:28 AM, Erik Joelsson wrote:

Looks good.

/Erik


On 2018-07-11 08:38, Aleksei Voitylov wrote:

Hi,

I suggest to disable JVMCI in default Client VM build and leave it 
in Server VM. It’s hard to justify its presence in default Client 
VM. There is no Tiered Compilation support in Client VM.


It also crashes Client VM during build.

webrev: 
http://cr.openjdk.java.net/~dchuyko/aleksei.voitylov/8206903/webrev.01/ 


bug: https://bugs.openjdk.java.net/browse/JDK-8206903

OK for 11?

Thanks,

-Aleksei









Re: [11] RFR (XXS): 8206903: Unable to build Client VM with JVMCI

2018-07-12 Thread Aleksei Voitylov

Erik, Vladimir,

thank you for review. Could either of you sponsor the change?

-Aleksei


On 11/07/2018 19:30, Vladimir Kozlov wrote:

+1

Vladimir

On 7/11/18 9:28 AM, Erik Joelsson wrote:

Looks good.

/Erik


On 2018-07-11 08:38, Aleksei Voitylov wrote:

Hi,

I suggest to disable JVMCI in default Client VM build and leave it 
in Server VM. It’s hard to justify its presence in default Client 
VM. There is no Tiered Compilation support in Client VM.


It also crashes Client VM during build.

webrev: 
http://cr.openjdk.java.net/~dchuyko/aleksei.voitylov/8206903/webrev.01/

bug: https://bugs.openjdk.java.net/browse/JDK-8206903

OK for 11?

Thanks,

-Aleksei







Re: [11] RFR (XXS): 8206903: Unable to build Client VM with JVMCI

2018-07-11 Thread Vladimir Kozlov

+1

Vladimir

On 7/11/18 9:28 AM, Erik Joelsson wrote:

Looks good.

/Erik


On 2018-07-11 08:38, Aleksei Voitylov wrote:

Hi,

I suggest to disable JVMCI in default Client VM build and leave it in Server VM. It’s hard to justify its presence in 
default Client VM. There is no Tiered Compilation support in Client VM.


It also crashes Client VM during build.

webrev: http://cr.openjdk.java.net/~dchuyko/aleksei.voitylov/8206903/webrev.01/
bug: https://bugs.openjdk.java.net/browse/JDK-8206903

OK for 11?

Thanks,

-Aleksei





Re: [11] RFR (XXS): 8206903: Unable to build Client VM with JVMCI

2018-07-11 Thread Erik Joelsson

Looks good.

/Erik


On 2018-07-11 08:38, Aleksei Voitylov wrote:

Hi,

I suggest to disable JVMCI in default Client VM build and leave it in 
Server VM. It’s hard to justify its presence in default Client VM. 
There is no Tiered Compilation support in Client VM.


It also crashes Client VM during build.

webrev: 
http://cr.openjdk.java.net/~dchuyko/aleksei.voitylov/8206903/webrev.01/

bug: https://bugs.openjdk.java.net/browse/JDK-8206903

OK for 11?

Thanks,

-Aleksei