Re: [9] RFR[XS] 8166096: variable tracking size limit exceeded in jvmciCompilerToVM.cpp

2016-09-19 Thread Vladimir Kozlov

Thank you, Erik

Vladimir

On 9/19/16 12:58 AM, Erik Joelsson wrote:

Looks ok to me.

/Erik


On 2016-09-17 03:17, Vladimir Kozlov wrote:

https://bugs.openjdk.java.net/browse/JDK-8166096

+++ b/make/lib/JvmOverrideFiles.gmkFri Sep 16 18:14:06 2016 -0700
@@ -31,6 +31,7 @@

 ifeq ($(TOOLCHAIN_TYPE), gcc)
   BUILD_LIBJVM_vmStructs.cpp_CXXFLAGS := -fno-var-tracking-assignments -O0
+  BUILD_LIBJVM_jvmciCompilerToVM.cpp_CXXFLAGS := -fno-var-tracking-assignments
 endif

 ifeq ($(OPENJDK_TARGET_OS), linux)


Remove annoying Hotspot compilation warning:

hotspot/src/share/vm/jvmci/jvmciCompilerToVM.cpp: In static member function 
'static objArrayHandle
CompilerToVM::initialize_intrinsics(Thread*)':
hotspot/src/share/vm/jvmci/jvmciCompilerToVM.cpp:206:16: note: variable 
tracking size limit exceeded with
-fvar-tracking-assignments, retrying without
 objArrayHandle CompilerToVM::initialize_intrinsics(TRAPS) {

Thanks,
Vladimir




Re: [9] RFR[XS] 8166096: variable tracking size limit exceeded in jvmciCompilerToVM.cpp

2016-09-19 Thread Vladimir Kozlov

Thank you, David, for review.

I don't think we can do anything more here. It is number of intrinsics which overflow some internal buffer related to 
var-tracking-assignments in gcc during compilation:


  VM_INTRINSICS_DO(VM_INTRINSIC_INFO, VM_SYMBOL_IGNORE, VM_SYMBOL_IGNORE, 
VM_SYMBOL_IGNORE, VM_ALIAS_IGNORE)

Thanks,
Vladimir

On 9/18/16 10:01 PM, David Holmes wrote:

On 17/09/2016 11:17 AM, Vladimir Kozlov wrote:

https://bugs.openjdk.java.net/browse/JDK-8166096

+++ b/make/lib/JvmOverrideFiles.gmkFri Sep 16 18:14:06 2016 -0700
@@ -31,6 +31,7 @@

 ifeq ($(TOOLCHAIN_TYPE), gcc)
   BUILD_LIBJVM_vmStructs.cpp_CXXFLAGS := -fno-var-tracking-assignments -O0
+  BUILD_LIBJVM_jvmciCompilerToVM.cpp_CXXFLAGS :=
-fno-var-tracking-assignments
 endif

 ifeq ($(OPENJDK_TARGET_OS), linux)


Remove annoying Hotspot compilation warning:


Seems reasonable as a short term silencer, but ... does it imply the code needs 
to be changed somehow?

Thanks,
David


hotspot/src/share/vm/jvmci/jvmciCompilerToVM.cpp: In static member
function 'static objArrayHandle
CompilerToVM::initialize_intrinsics(Thread*)':
hotspot/src/share/vm/jvmci/jvmciCompilerToVM.cpp:206:16: note: variable
tracking size limit exceeded with -fvar-tracking-assignments, retrying
without
 objArrayHandle CompilerToVM::initialize_intrinsics(TRAPS) {

Thanks,
Vladimir


Re: [9] RFR[XS] 8166096: variable tracking size limit exceeded in jvmciCompilerToVM.cpp

2016-09-19 Thread Erik Joelsson

Looks ok to me.

/Erik


On 2016-09-17 03:17, Vladimir Kozlov wrote:

https://bugs.openjdk.java.net/browse/JDK-8166096

+++ b/make/lib/JvmOverrideFiles.gmkFri Sep 16 18:14:06 2016 -0700
@@ -31,6 +31,7 @@

 ifeq ($(TOOLCHAIN_TYPE), gcc)
   BUILD_LIBJVM_vmStructs.cpp_CXXFLAGS := 
-fno-var-tracking-assignments -O0
+  BUILD_LIBJVM_jvmciCompilerToVM.cpp_CXXFLAGS := 
-fno-var-tracking-assignments

 endif

 ifeq ($(OPENJDK_TARGET_OS), linux)


Remove annoying Hotspot compilation warning:

hotspot/src/share/vm/jvmci/jvmciCompilerToVM.cpp: In static member 
function 'static objArrayHandle 
CompilerToVM::initialize_intrinsics(Thread*)':
hotspot/src/share/vm/jvmci/jvmciCompilerToVM.cpp:206:16: note: 
variable tracking size limit exceeded with -fvar-tracking-assignments, 
retrying without

 objArrayHandle CompilerToVM::initialize_intrinsics(TRAPS) {

Thanks,
Vladimir




Re: [9] RFR[XS] 8166096: variable tracking size limit exceeded in jvmciCompilerToVM.cpp

2016-09-18 Thread David Holmes

On 17/09/2016 11:17 AM, Vladimir Kozlov wrote:

https://bugs.openjdk.java.net/browse/JDK-8166096

+++ b/make/lib/JvmOverrideFiles.gmkFri Sep 16 18:14:06 2016 -0700
@@ -31,6 +31,7 @@

 ifeq ($(TOOLCHAIN_TYPE), gcc)
   BUILD_LIBJVM_vmStructs.cpp_CXXFLAGS := -fno-var-tracking-assignments -O0
+  BUILD_LIBJVM_jvmciCompilerToVM.cpp_CXXFLAGS :=
-fno-var-tracking-assignments
 endif

 ifeq ($(OPENJDK_TARGET_OS), linux)


Remove annoying Hotspot compilation warning:


Seems reasonable as a short term silencer, but ... does it imply the 
code needs to be changed somehow?


Thanks,
David


hotspot/src/share/vm/jvmci/jvmciCompilerToVM.cpp: In static member
function 'static objArrayHandle
CompilerToVM::initialize_intrinsics(Thread*)':
hotspot/src/share/vm/jvmci/jvmciCompilerToVM.cpp:206:16: note: variable
tracking size limit exceeded with -fvar-tracking-assignments, retrying
without
 objArrayHandle CompilerToVM::initialize_intrinsics(TRAPS) {

Thanks,
Vladimir