Hi Volker,
On Fri, 2018-04-13 at 09:03 +0200, Volker Simonis wrote:
> Hi Severin,
>
> I'm currently looking at the AIX-side of this bug.
>
> The problem I see with your solution is that it uses LDFLAGS (which is
> generic) to filter out Linux specific linker flags. If we would extend
> this to
Hi Severin,
I'm currently looking at the AIX-side of this bug.
The problem I see with your solution is that it uses LDFLAGS (which is
generic) to filter out Linux specific linker flags. If we would extend
this to AIX, we would have to add yet another substitution for AIX
which filters out
Yes, I think this should be removed for AIX as we have
done for Solaris + Linux, and I could have done that but
I also had no way to test it .. without that capability
I ran more risk of breaking AIX than fixing a problem that
apparently hasn't been seen there. I am not sure if *headful*
tests
Hi Magnus,
On Tue, 2018-04-10 at 22:57 +0200, Magnus Ihse Bursie wrote:
> On 2018-04-10 13:25, Severin Gehwolf wrote:
> > Hi Erik,
> >
> > On Mon, 2018-04-09 at 09:20 -0700, Erik Joelsson wrote:
> > > Hello Severin,
> > >
> > > I'm ok with this solution for now.
> >
> > Thanks for the review!
On Tue, 2018-04-10 at 09:34 -0700, Erik Joelsson wrote:
> Looks good. Thanks!
Thanks, Erik.
Cheers,
Severin
> /Erik
>
>
> On 2018-04-10 04:25, Severin Gehwolf wrote:
> > Hi Erik,
> >
> > On Mon, 2018-04-09 at 09:20 -0700, Erik Joelsson wrote:
> > > Hello Severin,
> > >
> > > I'm ok with
On Tue, 2018-04-10 at 14:51 -0700, Sergey Bylokhov wrote:
> LIBS_aix := -lawt_headless,
> I guess that AIX team should have a similar fix.
Possibly. I have no way of testing it, though. So will leave it to AIX
folk to have a look. My experience was that it isn't easily
reproducible. Some
+1
On 10/04/2018 13:57, Magnus Ihse Bursie wrote:
On 2018-04-10 13:25, Severin Gehwolf wrote:
Hi Erik,
On Mon, 2018-04-09 at 09:20 -0700, Erik Joelsson wrote:
Hello Severin,
I'm ok with this solution for now.
Thanks for the review!
Could you please reduce the indentation on line 652. In
LIBS_aix := -lawt_headless,
I guess that AIX team should have a similar fix.
On 10/04/2018 09:34, Erik Joelsson wrote:
Looks good. Thanks!
/Erik
On 2018-04-10 04:25, Severin Gehwolf wrote:
Hi Erik,
On Mon, 2018-04-09 at 09:20 -0700, Erik Joelsson wrote:
Hello Severin,
I'm ok with this
On 2018-04-10 13:25, Severin Gehwolf wrote:
Hi Erik,
On Mon, 2018-04-09 at 09:20 -0700, Erik Joelsson wrote:
Hello Severin,
I'm ok with this solution for now.
Thanks for the review!
Could you please reduce the indentation on line 652. In the build system
we like 4 spaces for continuation
On 2018-04-10 04:30, Severin Gehwolf wrote:
On Mon, 2018-04-09 at 15:39 +0200, Severin Gehwolf wrote:
Hi,
Could somebody please review this build fix for libfontmanager.so. The
issue for us is that with some LDFLAGS the build breaks as described in
bug JDK-8196218. However, we cannot link to
Looks good. Thanks!
/Erik
On 2018-04-10 04:25, Severin Gehwolf wrote:
Hi Erik,
On Mon, 2018-04-09 at 09:20 -0700, Erik Joelsson wrote:
Hello Severin,
I'm ok with this solution for now.
Thanks for the review!
Could you please reduce the indentation on line 652. In the build system
we
On Mon, 2018-04-09 at 15:39 +0200, Severin Gehwolf wrote:
> Hi,
>
> Could somebody please review this build fix for libfontmanager.so. The
> issue for us is that with some LDFLAGS the build breaks as described in
> bug JDK-8196218. However, we cannot link to a providing library at
> build-time
Hi Erik,
On Mon, 2018-04-09 at 09:20 -0700, Erik Joelsson wrote:
> Hello Severin,
>
> I'm ok with this solution for now.
Thanks for the review!
> Could you please reduce the indentation on line 652. In the build system
> we like 4 spaces for continuation indent [1]
Done. New webrev at:
Hello Severin,
I'm ok with this solution for now.
Could you please reduce the indentation on line 652. In the build system
we like 4 spaces for continuation indent [1]
/Erik
[1] http://openjdk.java.net/groups/build/doc/code-conventions.html
On 2018-04-09 06:39, Severin Gehwolf wrote:
Hi,
14 matches
Mail list logo
