Re: RFR: JDK-8198323 testing.md not updated for repository layout change
Hello, Nice fixes, some grammar notes: building.md: 872: provide -> provides testing.md: 57: JTReg test -> JTReg tests 68: tests roots -> test roots 77: "Here too can just `hotspot` be used as an alias for `hotspot/jtreg`" reads weird (and is missing punctuation), how about: "`hotspot` can be used as an alias for `hotspot/jtreg` here as well." /Erik On 2018-03-02 04:48, Magnus Ihse Bursie wrote: In make/doc/testing.md, the descriptions of the TEST option for jtreg tests has not been updated to account for the repository layout change. For example, "hotspot/test:hotspot_gc" should be "test/hotspot/jtreg:hotspot_gc". Bug: https://bugs.openjdk.java.net/browse/JDK-8198323 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8198323-update-testing-documentation/webrev.01 /Magnus
Re: RFR: JDK-8198323 testing.md not updated for repository layout change
On 03/02/2018 01:48 PM, Magnus Ihse Bursie wrote: In make/doc/testing.md, the descriptions of the TEST option for jtreg tests has not been updated to account for the repository layout change. For example, "hotspot/test:hotspot_gc" should be "test/hotspot/jtreg:hotspot_gc". Bug: https://bugs.openjdk.java.net/browse/JDK-8198323 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8198323-update-testing-documentation/webrev.01 +example, `:tier1` will expand to `jtreg:$(TOPDIR)/test/jdk:tier1 +jtreg:$(TOPDIR)/test/langtools:tier1 jtreg:$(TOPDIR)/test/nashorn:tier1 +jtreg:$(TOPDIR)/test/jaxp:tier1`. :tier1 will now actually include `jtreg:$(TOPDIR)/test/hotspot:tier1` as well since Christian's commit: http://hg.openjdk.java.net/jdk/jdk/rev/75f4ad82866c While you are at it, you might want to change all occurrences of VM_OTIONS to VM_OPTIONS :) Thanks for updating the documentation! Erik /Magnus